{"id":14912,"url":"https://patchwork.libcamera.org/api/1.1/patches/14912/?format=json","web_url":"https://patchwork.libcamera.org/patch/14912/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211130213411.20149-2-djrscally@gmail.com>","date":"2021-11-30T21:34:10","name":"[libcamera-devel,1/2] libipa: Add CameraSensorHelper for ov2680","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"def6fed7e333b540d93c601b818c351eaf7a3936","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/1.1/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14912/mbox/","series":[{"id":2787,"url":"https://patchwork.libcamera.org/api/1.1/series/2787/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2787","date":"2021-11-30T21:34:09","name":"Add support for OV2680 driver","version":1,"mbox":"https://patchwork.libcamera.org/series/2787/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14912/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14912/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97EF2BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Nov 2021 21:34:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBD2C60726;\n\tTue, 30 Nov 2021 22:34:33 +0100 (CET)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB9A3605C4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 22:34:31 +0100 (CET)","by mail-wr1-x42c.google.com with SMTP id a18so47508204wrn.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 13:34:31 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tp13sm3519642wmi.0.2021.11.30.13.34.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Nov 2021 13:34:31 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nVM5R1nC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=kTvLjJS9WG2McZQABpbwOF0yPio+OC/y+/XehGfEp3Q=;\n\tb=nVM5R1nCICdkvo2rr7pAS1T5vyvQS+Fdt5w1IB2K5PiGnxKNg5sQfkp9Gj8T/cU2h9\n\thZ3EtD7N/i9rQoLF92KnYkYWbXgGRbrkHbOQqezSSCWFE13N1WRDHZCQdyo48JOk2uSs\n\tU3wwDlIB5jDVb+W6megTE0wSsov5bCkftYeARVZ73FwFuuMcWKwvjE7H6YUN4EsTatlz\n\tKb2vL7gvgjjCtruTh4stuJ09KAPrDKmMpByUmQNRfU9NEGWdv6TYwqMukxzCa0j+4TsH\n\tDQygtkvuW/8fxpV+5CDnTxsrqQ3sRes9Fwl265rdXwp9DXk0r0BdyUZ/54legrWhLNgk\n\tGojw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=kTvLjJS9WG2McZQABpbwOF0yPio+OC/y+/XehGfEp3Q=;\n\tb=nzEadzIy0Mgr/TUJawLpVt4oNKXVSCAO8mVAn699LzY99stHZ9jvMSxiXAAegQelxu\n\tf9+D3wu0k1ofz+X6ENmcnwfkdVsoyX0Im9AQqr8sz0XqB2/kGBr3JJW7JQeiHBBpFd03\n\tUwMkpmo5pUfjKYndqet8TcKXCEFW6lr6ZrIgBgcNxhoLRdUsbjoww3fb2T1OekLSvHMn\n\tcIvS3kqfzSXVNxYbfQnIvjsODFPhCkZQd9Dh+wd3qasdrslwYLj//av14QHWxRjlYdnK\n\tdOndZ6tZPSMr3ICUDV2qIvG5z7GIGjx7q0VQyV1PrhT7dGrma8jaceXOOwpZY74N7uev\n\tMOJQ==","X-Gm-Message-State":"AOAM5331L5EzNa8ifgBLZarZP/cpj1pzk6tHtdb8pBArrZ8apXTNOmGM\n\t0Q3XXpE61actKfOIN6pHaB+UrkxNbrw=","X-Google-Smtp-Source":"ABdhPJx1cVRJ4aVopqo4YSBQ9Ltib3Cj3YKgUNmGC5Zj787b4wgXpfYPLVARbALCzTbHM0vMMb9B+w==","X-Received":"by 2002:adf:8b0e:: with SMTP id\n\tn14mr1601818wra.281.1638308071529; \n\tTue, 30 Nov 2021 13:34:31 -0800 (PST)","From":"Daniel Scally <djrscally@gmail.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Nov 2021 21:34:10 +0000","Message-Id":"<20211130213411.20149-2-djrscally@gmail.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20211130213411.20149-1-djrscally@gmail.com>","References":"<20211130213411.20149-1-djrscally@gmail.com>","Subject":"[libcamera-devel] [PATCH 1/2] libipa: Add CameraSensorHelper for\n\tov2680","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add a CameraSensorHelperOv2680 class. The OV2680 is found in concert\nwith an IPU3 on the Lenovo Miix 510. The constants set are a bit of a\nguess, as the datasheet doesn't document the gain control field any\nfurther than giving its width in bits, but the default is 0x10 so we\nassume that to be 1x gain.\n\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 0b0eb503..fd951505 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -305,6 +305,16 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n \n+class CameraSensorHelperOv2680 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv2680()\n+\t{\n+\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 16 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"ov2680\", CameraSensorHelperOv2680)\n+\n class CameraSensorHelperOv5670 : public CameraSensorHelper\n {\n public:\n","prefixes":["libcamera-devel","1/2"]}