{"id":14880,"url":"https://patchwork.libcamera.org/api/1.1/patches/14880/?format=json","web_url":"https://patchwork.libcamera.org/patch/14880/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211130071058.47834-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-30T07:10:58","name":"[libcamera-devel,v1.1] ipa: rkisp1: Initialize numCells in constructor","commit_ref":"437cc396685a8c50974688b814b08d36e086a9b1","pull_url":null,"state":"accepted","archived":false,"hash":"61e9e31d1867642bcc35ca298268f397252354aa","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14880/mbox/","series":[{"id":2779,"url":"https://patchwork.libcamera.org/api/1.1/series/2779/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2779","date":"2021-11-30T07:10:58","name":"[libcamera-devel,v1.1] ipa: rkisp1: Initialize numCells in constructor","version":1,"mbox":"https://patchwork.libcamera.org/series/2779/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14880/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14880/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 034AEBF415\n\tfor ;\n\tTue, 30 Nov 2021 07:11:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32341605B4;\n\tTue, 30 Nov 2021 08:11:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C61DE604FC\n\tfor ;\n\tTue, 30 Nov 2021 08:11:02 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:699a:a10f:5b1e:89b7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47B608F0;\n\tTue, 30 Nov 2021 08:11:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tUaBKJci\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638256262;\n\tbh=hKLep240VxNo0La3mct+ZFRNgmiLKbS3Bjgm3bkgDio=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tUaBKJciSdoxfbeuG1Mf6CpcHc9VynKfPNZmkRmy0NrwubGoF1y8NQddFyGSbmUTO\n\t4L96bIgBVRheIoAFDe4rxa3+IlGypsNvD95Ks0/JSkZrKg4KzN7ZblU2IKFozTKcH6\n\t1IV6BxkK36O5TlbY1uw2dtDgD7ZbE4oizNqV/WTY=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Nov 2021 08:10:58 +0100","Message-Id":"<20211130071058.47834-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211130064547.37598-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211130064547.37598-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1.1] ipa: rkisp1: Initialize numCells in\n\tconstructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The non-static class member \"numCells_\" is not initialized in the\nconstructor. Fix it.\n\nReported-by: Coverity CID 365801\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Umang Jain \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 650fe2dae..d6abdc310 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -53,7 +53,7 @@ static constexpr uint32_t kNumStartupFrames = 10;\n static constexpr double kRelativeLuminanceTarget = 0.4;\n \n Agc::Agc()\n-\t: frameCount_(0), filteredExposure_(0s)\n+\t: frameCount_(0), numCells_(0), filteredExposure_(0s)\n {\n }\n \n","prefixes":["libcamera-devel","v1.1"]}