{"id":14861,"url":"https://patchwork.libcamera.org/api/1.1/patches/14861/?format=json","web_url":"https://patchwork.libcamera.org/patch/14861/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211130033820.18235-7-laurent.pinchart@ideasonboard.com>","date":"2021-11-30T03:38:04","name":"[libcamera-devel,v4,06/22] libcamera: base: file_descriptor: Add constructor from UniqueFD","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"15714b62a076e77db0d2fdc4d88057e57b0c10a8","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14861/mbox/","series":[{"id":2776,"url":"https://patchwork.libcamera.org/api/1.1/series/2776/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2776","date":"2021-11-30T03:37:58","name":"libcamera: Introduce UniqueFD","version":4,"mbox":"https://patchwork.libcamera.org/series/2776/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14861/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14861/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 535CEBF415\n\tfor ;\n\tTue, 30 Nov 2021 03:39:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC71F605C3;\n\tTue, 30 Nov 2021 04:39:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1709605C1\n\tfor ;\n\tTue, 30 Nov 2021 04:38:50 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E0FB8F0;\n\tTue, 30 Nov 2021 04:38:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hbll/GVc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638243530;\n\tbh=AgBMBdKWljtF8MTtTz0SyFFV23uh+ZB8kLA+21V30ws=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Hbll/GVcD2N0hFyu1yL0TNT0Lr3cK0dyg749EBrzru23r2ftCDQy85Uy8T7cw9Pfe\n\tdQL1Rj2z/WhwXYxwXuazSPdqNCsxXjACmFesgwT70/AwILfxiMz9UImn1xZu5bDfNV\n\twfJm0CP0crwBCZ05zT20LF4XuyWFp9L7PbP0alTA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Nov 2021 05:38:04 +0200","Message-Id":"<20211130033820.18235-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211130033820.18235-1-laurent.pinchart@ideasonboard.com>","References":"<20211130033820.18235-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 06/22] libcamera: base:\n\tfile_descriptor: Add constructor from UniqueFD","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hirokazu Honda \n\nAdd a FileDescriptor constructor that takes a UniqueFD, transfering\nownership of the file descriptor to the FileDescriptor.\n\nSigned-off-by: Hirokazu Honda \nSigned-off-by: Laurent Pinchart \nReviewed-by: Hirokazu Honda \nReviewed-by: Jacopo Mondi \n---\nChanges since v2:\n\n- Pass UniqueFD by value\n---\n include/libcamera/base/file_descriptor.h | 3 +++\n src/libcamera/base/file_descriptor.cpp | 13 +++++++++++++\n 2 files changed, 16 insertions(+)","diff":"diff --git a/include/libcamera/base/file_descriptor.h b/include/libcamera/base/file_descriptor.h\nindex 5d1594e80801..74292eba04f5 100644\n--- a/include/libcamera/base/file_descriptor.h\n+++ b/include/libcamera/base/file_descriptor.h\n@@ -11,11 +11,14 @@\n \n namespace libcamera {\n \n+class UniqueFD;\n+\n class FileDescriptor final\n {\n public:\n \texplicit FileDescriptor(const int &fd = -1);\n \texplicit FileDescriptor(int &&fd);\n+\texplicit FileDescriptor(UniqueFD fd);\n \tFileDescriptor(const FileDescriptor &other);\n \tFileDescriptor(FileDescriptor &&other);\n \t~FileDescriptor();\ndiff --git a/src/libcamera/base/file_descriptor.cpp b/src/libcamera/base/file_descriptor.cpp\nindex 98d4b4bfd24f..da696b2501cd 100644\n--- a/src/libcamera/base/file_descriptor.cpp\n+++ b/src/libcamera/base/file_descriptor.cpp\n@@ -13,6 +13,7 @@\n #include \n \n #include \n+#include \n \n /**\n * \\file base/file_descriptor.h\n@@ -109,6 +110,18 @@ FileDescriptor::FileDescriptor(int &&fd)\n \tfd = -1;\n }\n \n+/**\n+ * \\brief Create a FileDescriptor taking ownership of a given UniqueFD \\a fd\n+ * \\param[in] fd UniqueFD\n+ *\n+ * Construct a FileDescriptor from UniqueFD by taking ownership of the \\a fd.\n+ * The original \\a fd becomes invalid.\n+ */\n+FileDescriptor::FileDescriptor(UniqueFD fd)\n+\t: FileDescriptor(fd.release())\n+{\n+}\n+\n /**\n * \\brief Copy constructor, create a FileDescriptor from a copy of \\a other\n * \\param[in] other The other FileDescriptor\n","prefixes":["libcamera-devel","v4","06/22"]}