{"id":14794,"url":"https://patchwork.libcamera.org/api/1.1/patches/14794/?format=json","web_url":"https://patchwork.libcamera.org/patch/14794/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211126050810.1871781-4-hiroh@chromium.org>","date":"2021-11-26T05:08:10","name":"[libcamera-devel,v8,3/3] libcamera: pipeline: ipu3: Apply a requested test pattern mode","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"660e41bd8a41efd99a17729e2cd424737fd94679","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14794/mbox/","series":[{"id":2759,"url":"https://patchwork.libcamera.org/api/1.1/series/2759/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2759","date":"2021-11-26T05:08:07","name":"Enable to apply test pattern mode in IPU3","version":8,"mbox":"https://patchwork.libcamera.org/series/2759/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14794/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14794/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C1D2BDB13\n\tfor ;\n\tFri, 26 Nov 2021 05:08:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDC6B6049A;\n\tFri, 26 Nov 2021 06:08:25 +0100 (CET)","from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BB7F60492\n\tfor ;\n\tFri, 26 Nov 2021 06:08:23 +0100 (CET)","by mail-pj1-x1029.google.com with SMTP id\n\ty14-20020a17090a2b4e00b001a5824f4918so9094531pjc.4\n\tfor ;\n\tThu, 25 Nov 2021 21:08:23 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:139c:952e:8861:d909])\n\tby smtp.gmail.com with ESMTPSA id\n\tk6sm9280248pjt.14.2021.11.25.21.08.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 25 Nov 2021 21:08:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"e55YqXkb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=oOLVLe+hX0g+Qrj/5QThziAsLyhcjI7qFpkEZYN0EjA=;\n\tb=e55YqXkb7MvGfFqWA/tlDewrEexEi7IRBhabSls5GxwHXu4x5FpJp9C/9GuqWyTrHm\n\tjfK/2V4MxWMBmvhls1c1cdOZhbeCIhnHzw8zeQk1liKncrGRhS5WxUMbiC5W1XpsSy16\n\ts2UL/sVCjHpPbDc9OU2rsj9b7+tSFMHb931rM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=oOLVLe+hX0g+Qrj/5QThziAsLyhcjI7qFpkEZYN0EjA=;\n\tb=PQIZimPCI6AZyX5Bz6g7IpAJVlUzCIvTnUWS1LVMEDMMpYUbVKq2b+OiMX7hPAHUGP\n\tS24GtP0cis59lVuTJjUAcTCWWgDTOA0T/a1kSFDzIHgKAhkytcxLaBAFZuDFCBT72AJq\n\tl6B4Iz2LDngHX6zEYTDjGAzQ02s9HdkBUsK6U0ablvxlv6v/4Hnt9v1UnsPO+qaD8VPL\n\tKjbYHVMGWEF3Dkww2ZiFUUmOs2bT9UlN9duVzp6g4gHPr+SZnc/b+jP0qEhxFY7QOPyH\n\tVpkHjAaf+O+p4oXA1ktX4ivV1BDqHc+NTfj/jJ3wH6ePESenZZyICe+K3pldNNXDTXLt\n\tJlCw==","X-Gm-Message-State":"AOAM532cudWnT5mAiQDYPN74SE3P5sHRAj3yiSpHKsJUIdm5wxgpRcXq\n\tVz0iFxoSEYxnHu8RLBHoCNIIp972D/pc6g==","X-Google-Smtp-Source":"ABdhPJx1kwtTqog9Bojqt8XWk2ZRazXjDvL0tkZgDRgo2qSoRDWTqi3quIri1p49awouhZu+ApQKGg==","X-Received":"by 2002:a17:90b:4d8f:: with SMTP id\n\toj15mr12737068pjb.127.1637903301768; \n\tThu, 25 Nov 2021 21:08:21 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 26 Nov 2021 14:08:10 +0900","Message-Id":"<20211126050810.1871781-4-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.0.rc2.393.gf8c9666880-goog","In-Reply-To":"<20211126050810.1871781-1-hiroh@chromium.org>","References":"<20211126050810.1871781-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 3/3] libcamera: pipeline: ipu3: Apply a\n\trequested test pattern mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This introduces a way to set controls immediately for a capture\nin ipu3 pipeline handler. It enables to apply a test pattern mode\nper frame.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Jacopo Mondi \nReviewed-by: Jean-Michel Hautbois \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 55 +++++++++++++++++++++++++++-\n 1 file changed, 53 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 25490dcf..31f5f9dd 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -59,6 +59,7 @@ public:\n \tvoid statBufferReady(FrameBuffer *buffer);\n \tvoid queuePendingRequests();\n \tvoid cancelPendingRequests();\n+\tvoid frameStart(uint32_t sequence);\n \n \tCIO2Device cio2_;\n \tImgUDevice *imgu_;\n@@ -76,7 +77,10 @@ public:\n \n \tstd::unique_ptr ipa_;\n \n+\t/* Requests before queueing cio2 device. */\n \tstd::queue pendingRequests_;\n+\t/* Requests queued in cio2 device and before passing imgu device. */\n+\tstd::queue processingRequests_;\n \n \tControlInfoMap ipaControls_;\n \n@@ -823,6 +827,8 @@ void IPU3CameraData::cancelPendingRequests()\n \t\tpipe()->completeRequest(request);\n \t\tpendingRequests_.pop();\n \t}\n+\n+\tprocessingRequests_ = {};\n }\n \n void IPU3CameraData::queuePendingRequests()\n@@ -853,6 +859,8 @@ void IPU3CameraData::queuePendingRequests()\n \n \t\tinfo->rawBuffer = rawBuffer;\n \n+\t\tprocessingRequests_.push(request);\n+\n \t\tipa::ipu3::IPU3Event ev;\n \t\tev.op = ipa::ipu3::EventProcessControls;\n \t\tev.frame = info->id;\n@@ -1121,8 +1129,8 @@ int PipelineHandlerIPU3::registerCameras()\n \t\tdata->delayedCtrls_ =\n \t\t\tstd::make_unique(cio2->sensor()->device(),\n \t\t\t\t\t\t\t params);\n-\t\tdata->cio2_.frameStart().connect(data->delayedCtrls_.get(),\n-\t\t\t\t\t\t &DelayedControls::applyControls);\n+\t\tdata->cio2_.frameStart().connect(data.get(),\n+\t\t\t\t\t\t &IPU3CameraData::frameStart);\n \n \t\t/* Convert the sensor rotation to a transformation */\n \t\tint32_t rotation = 0;\n@@ -1414,6 +1422,49 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tipa_->processEvent(ev);\n }\n \n+void IPU3CameraData::frameStart(uint32_t sequence)\n+{\n+\t/*\n+\t * Handle the start of frame exposure signal.\n+\t *\n+\t * Inspect the list of pending requests waiting for a RAW frame to be\n+\t * produced and apply controls for the 'next' one.\n+\t *\n+\t * Some controls need to be applied immediately, such as the\n+\t * TestPatternMode one. Other controls are handled through the delayed\n+\t * controls class.\n+\t */\n+\n+\tdelayedCtrls_->applyControls(sequence);\n+\n+\tif (!processingRequests_.empty()) {\n+\t\t/* Handle controls which are to be set ready for the next frame to start. */\n+\t\tRequest *request = processingRequests_.front();\n+\t\tprocessingRequests_.pop();\n+\n+\t\t/* Assumes applying the test pattern mode affects immediately. */\n+\t\tif (!request->controls().contains(controls::draft::TestPatternMode))\n+\t\t\treturn;\n+\t\tconst int32_t testPatternMode = request->controls().get(\n+\t\t\tcontrols::draft::TestPatternMode);\n+\n+\t\tLOG(IPU3, Debug) << \"Apply test pattern mode: \"\n+\t\t\t\t << testPatternMode;\n+\n+\t\tint ret = cio2_.sensor()->setTestPatternMode(\n+\t\t\tstatic_cast(\n+\t\t\t\ttestPatternMode));\n+\t\tif (ret) {\n+\t\t\tLOG(IPU3, Error) << \"Failed to set test pattern mode: \"\n+\t\t\t\t\t << ret;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\trequest->metadata().set(controls::draft::TestPatternMode,\n+\t\t\t\t\ttestPatternMode);\n+\t}\n+}\n+\n REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v8","3/3"]}