{"id":14780,"url":"https://patchwork.libcamera.org/api/1.1/patches/14780/?format=json","web_url":"https://patchwork.libcamera.org/patch/14780/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211125131224.927640-2-umang.jain@ideasonboard.com>","date":"2021-11-25T13:12:23","name":"[libcamera-devel,v2,1/2] android: camera_device: Provide toString() helper for stream_type","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ec76f3c8ba213a78209dfacfcca7253ef23409bb","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14780/mbox/","series":[{"id":2755,"url":"https://patchwork.libcamera.org/api/1.1/series/2755/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2755","date":"2021-11-25T13:12:22","name":"Improve stream type logging","version":2,"mbox":"https://patchwork.libcamera.org/series/2755/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14780/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14780/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76F27BF415\n\tfor ;\n\tThu, 25 Nov 2021 13:12:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3360B6038A;\n\tThu, 25 Nov 2021 14:12:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CC9760231\n\tfor ;\n\tThu, 25 Nov 2021 14:12:37 +0100 (CET)","from perceval.ideasonboard.com (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F63790E;\n\tThu, 25 Nov 2021 14:12:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dY55Ap+g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637845956;\n\tbh=idN1gzWVOJ0dF/QtSg/Tq3HzgFp1FOOxsE0dD53h8Jc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dY55Ap+g95tiM7KRnI5Luk7ihvBaHFHdCVI7BeaSXVBvuXXvvQaqf9F34Y+vtF7u5\n\tAVOynFW6y08PlH3kimDErfGAt8So8/mRqBnCy9cYhu03CyFE/BXHx3Tq3RGYx9BsTn\n\tw7Y3hJzBWsXMdr5PS4oA3gN2nK1u2s/vtkwSh2pg=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 25 Nov 2021 18:42:23 +0530","Message-Id":"<20211125131224.927640-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211125131224.927640-1-umang.jain@ideasonboard.com>","References":"<20211125131224.927640-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/2] android: camera_device: Provide\n\ttoString() helper for stream_type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide a directionToString() helper to return a human-friendly name\nfor camera3_stream_t->stream_type. Replace the int value being printed\nin configureStreams() INFO log with directionToString().\n\nSigned-off-by: Umang Jain \nReviewed-by: Jacopo Mondi \nReviewed-by: Hirokazu Honda \nReviewed-by: Kieran Bingham \n---\n src/android/camera_device.cpp | 17 ++++++++++++++++-\n 1 file changed, 16 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex f2e0bdbd..ad4bf07c 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -175,6 +175,21 @@ const char *rotationToString(int rotation)\n \treturn \"INVALID\";\n }\n \n+const char *directionToString(int stream_type)\n+{\n+\tswitch (stream_type) {\n+\tcase CAMERA3_STREAM_OUTPUT:\n+\t\treturn \"Output\";\n+\tcase CAMERA3_STREAM_INPUT:\n+\t\treturn \"Input\";\n+\tcase CAMERA3_STREAM_BIDIRECTIONAL:\n+\t\treturn \"Bidirectional\";\n+\tdefault:\n+\t\tLOG(HAL, Warning) << \"Unknown stream type: \" << stream_type;\n+\t\treturn \"Unknown\";\n+\t}\n+}\n+\n #if defined(OS_CHROMEOS)\n /*\n * Check whether the crop_rotate_scale_degrees values for all streams in\n@@ -548,7 +563,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\tPixelFormat format = capabilities_.toPixelFormat(stream->format);\n \n \t\tLOG(HAL, Info) << \"Stream #\" << i\n-\t\t\t << \", direction: \" << stream->stream_type\n+\t\t\t << \", direction: \" << directionToString(stream->stream_type)\n \t\t\t << \", width: \" << stream->width\n \t\t\t << \", height: \" << stream->height\n \t\t\t << \", format: \" << utils::hex(stream->format)\n","prefixes":["libcamera-devel","v2","1/2"]}