{"id":14768,"url":"https://patchwork.libcamera.org/api/1.1/patches/14768/?format=json","web_url":"https://patchwork.libcamera.org/patch/14768/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211125054259.24792-8-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-25T05:42:55","name":"[libcamera-devel,v5,07/11] ipa: rkisp1: Use the Algorithm class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"14544295bb21975ea9a080d9c204ff654ade5e84","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14768/mbox/","series":[{"id":2752,"url":"https://patchwork.libcamera.org/api/1.1/series/2752/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2752","date":"2021-11-25T05:42:48","name":"Introduce AGC for RkISP1","version":5,"mbox":"https://patchwork.libcamera.org/series/2752/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14768/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14768/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12CF7C324F\n\tfor ;\n\tThu, 25 Nov 2021 05:43:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F85460423;\n\tThu, 25 Nov 2021 06:43:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E7C76038B\n\tfor ;\n\tThu, 25 Nov 2021 06:43:05 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:d9a5:5e40:3323:d95])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC0D890E;\n\tThu, 25 Nov 2021 06:43:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wBIvJMxH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637818985;\n\tbh=8fl7Lehagj28Qb4w6d+e/+6wU0+qsFUeaY0oOnOy/gM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wBIvJMxH7sLXOjXTgSkZ6VP/KTW2hRqskRqCtDodqQSOb2A0rkrpw9EKLyM5Ubm+w\n\tt/zPbMvqclPMOGgrtW0puzZ+hyhxd9fjTvOPoAIM/wOu61qeW1YgnUdBoV7p6zBKg/\n\t5KtqhLhqQ0dSAItHaYeFYbTFZ5lypApH8VBFsP3Y=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 25 Nov 2021 06:42:55 +0100","Message-Id":"<20211125054259.24792-8-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211125054259.24792-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211125054259.24792-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 07/11] ipa: rkisp1: Use the Algorithm\n\tclass","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that libipa offers a templated class for Algorithm, use it in\nRkISP1.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n\n---\nv4: use #pragma once\n---\n src/ipa/rkisp1/algorithms/algorithm.h | 26 ++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/meson.build | 4 ++++\n src/ipa/rkisp1/meson.build | 4 ++++\n src/ipa/rkisp1/rkisp1.cpp | 7 ++++++-\n 4 files changed, 40 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/rkisp1/algorithms/algorithm.h\n create mode 100644 src/ipa/rkisp1/algorithms/meson.build","diff":"diff --git a/src/ipa/rkisp1/algorithms/algorithm.h b/src/ipa/rkisp1/algorithms/algorithm.h\nnew file mode 100644\nindex 00000000..d46c3188\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/algorithm.h\n@@ -0,0 +1,26 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Ideas On Board\n+ *\n+ * algorithm.h - RkISP1 control algorithm interface\n+ */\n+\n+#pragma once\n+\n+#include \n+\n+#include \n+\n+#include \n+\n+#include \"ipa_context.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp1 {\n+\n+using Algorithm = libcamera::ipa::Algorithm;\n+\n+} /* namespace ipa::rkisp1 */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/meson.build b/src/ipa/rkisp1/algorithms/meson.build\nnew file mode 100644\nindex 00000000..1c6c59cf\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/meson.build\n@@ -0,0 +1,4 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+rkisp1_ipa_algorithms = files([\n+])\ndiff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\nindex 3683c922..8c822fbb 100644\n--- a/src/ipa/rkisp1/meson.build\n+++ b/src/ipa/rkisp1/meson.build\n@@ -1,5 +1,7 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+subdir('algorithms')\n+\n ipa_name = 'ipa_rkisp1'\n \n rkisp1_ipa_sources = files([\n@@ -7,6 +9,8 @@ rkisp1_ipa_sources = files([\n 'rkisp1.cpp',\n ])\n \n+rkisp1_ipa_sources += rkisp1_ipa_algorithms\n+\n mod = shared_module(ipa_name,\n [rkisp1_ipa_sources, libcamera_generated_ipa_headers],\n name_prefix : '',\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 34c3f9a2..225f1847 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -25,9 +25,11 @@\n \n #include \n \n-#include \"ipa_context.h\"\n+#include \"algorithms/algorithm.h\"\n #include \"libipa/camera_sensor_helper.h\"\n \n+#include \"ipa_context.h\"\n+\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPARkISP1)\n@@ -82,6 +84,9 @@ private:\n \n \t/* Local parameter storage */\n \tstruct IPAContext context_;\n+\n+\t/* Maintain the algorithms used by the IPA */\n+\tstd::list> algorithms_;\n };\n \n int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision)\n","prefixes":["libcamera-devel","v5","07/11"]}