{"id":14742,"url":"https://patchwork.libcamera.org/api/1.1/patches/14742/?format=json","web_url":"https://patchwork.libcamera.org/patch/14742/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211123224015.3619282-12-kieran.bingham@ideasonboard.com>","date":"2021-11-23T22:40:11","name":"[libcamera-devel,11/15] lc-compliance: Convert to pragma once","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a7a710dbd98861067cee246551cddf06dc8e2bf3","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/14742/mbox/","series":[{"id":2749,"url":"https://patchwork.libcamera.org/api/1.1/series/2749/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2749","date":"2021-11-23T22:40:00","name":"Use pragma once","version":1,"mbox":"https://patchwork.libcamera.org/series/2749/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14742/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14742/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6204DC3250\n\tfor ;\n\tTue, 23 Nov 2021 22:40:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 144EF6039C;\n\tTue, 23 Nov 2021 23:40:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FECC603FC\n\tfor ;\n\tTue, 23 Nov 2021 23:40:23 +0100 (CET)","from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFE36A1B;\n\tTue, 23 Nov 2021 23:40:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aHcLWJgy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637707222;\n\tbh=MTitkI/27Pj5UnW8Vgx+DW2Y2pw2fF6eTJy3KbMUnKg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aHcLWJgyQK7DodOtOtjR8u9n6a13GKHWy96yFxqDvg7pJYCsxMRrkRfqsgTwZT+rZ\n\tDxY/yHuodNAUToFdjVJ2m6uo3T71DuDT9wR09fzCiEZMDPme6N+J/wXNOd66QTHRxb\n\teWAFF+4xRjKNdPk5LvYd0iANXqIAq/h/2TfQ2bd4=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 23 Nov 2021 22:40:11 +0000","Message-Id":"<20211123224015.3619282-12-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>","References":"<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 11/15] lc-compliance: Convert to pragma\n\tonce","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nSigned-off-by: Kieran Bingham \n---\n src/lc-compliance/environment.h | 6 ++----\n src/lc-compliance/simple_capture.h | 6 ++----\n 2 files changed, 4 insertions(+), 8 deletions(-)","diff":"diff --git a/src/lc-compliance/environment.h b/src/lc-compliance/environment.h\nindex ba308732396e..0debbcce7150 100644\n--- a/src/lc-compliance/environment.h\n+++ b/src/lc-compliance/environment.h\n@@ -4,8 +4,8 @@\n *\n * environment.h - Common environment for tests\n */\n-#ifndef __LC_COMPLIANCE_ENVIRONMENT_H__\n-#define __LC_COMPLIANCE_ENVIRONMENT_H__\n+\n+#pragma once\n \n #include \n \n@@ -25,5 +25,3 @@ private:\n \tstd::string cameraId_;\n \tlibcamera::CameraManager *cm_;\n };\n-\n-#endif /* __LC_COMPLIANCE_ENVIRONMENT_H__ */\ndiff --git a/src/lc-compliance/simple_capture.h b/src/lc-compliance/simple_capture.h\nindex 100ffd6637ad..9d31f7cb2e53 100644\n--- a/src/lc-compliance/simple_capture.h\n+++ b/src/lc-compliance/simple_capture.h\n@@ -4,8 +4,8 @@\n *\n * simple_capture.h - Simple capture helper\n */\n-#ifndef __LC_COMPLIANCE_SIMPLE_CAPTURE_H__\n-#define __LC_COMPLIANCE_SIMPLE_CAPTURE_H__\n+\n+#pragma once\n \n #include \n \n@@ -63,5 +63,3 @@ private:\n \tunsigned int captureCount_;\n \tunsigned int captureLimit_;\n };\n-\n-#endif /* __LC_COMPLIANCE_SIMPLE_CAPTURE_H__ */\n","prefixes":["libcamera-devel","11/15"]}