{"id":14663,"url":"https://patchwork.libcamera.org/api/1.1/patches/14663/?format=json","web_url":"https://patchwork.libcamera.org/patch/14663/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211119210239.18540-2-laurent.pinchart@ideasonboard.com>","date":"2021-11-19T21:02:35","name":"[libcamera-devel,v2,1/5] ipa: ipu3: agc: Drop kMaxLuminance constant","commit_ref":"65628512df0f4bd1e4b2816f080d648fce3e3ab0","pull_url":null,"state":"accepted","archived":false,"hash":"3d9c74afe56d72e1723bb5c373bede054e5cdaf1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14663/mbox/","series":[{"id":2738,"url":"https://patchwork.libcamera.org/api/1.1/series/2738/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2738","date":"2021-11-19T21:02:34","name":"ipa: ipu3: agc: Misc improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/2738/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14663/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14663/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE17EBF415\n\tfor ;\n\tFri, 19 Nov 2021 21:03:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FC55603B5;\n\tFri, 19 Nov 2021 22:03:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C3F460233\n\tfor ;\n\tFri, 19 Nov 2021 22:03:05 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 449821C72\n\tfor ;\n\tFri, 19 Nov 2021 22:03:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IpvSD2sk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637355785;\n\tbh=rxvkaSWwq7rCGBvSitrsNFQ825869nmLjV8jJ8rxnFI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=IpvSD2sk3rVRSVTnbZMRwblgYlyEpc2t7iemfQYMV6/1kuSbGg7u4syvhyPY3I22p\n\tzEuwUSL9H50Rlx0AFMjTZhnFtAZiT4vWbvl9mT4zgu3qAOFKqBgUoNcg1euP/CjUTw\n\ti0k8bW6PRabWMBtqBgSc6Kp3KhVf8yRMFJ2DVSSU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Nov 2021 23:02:35 +0200","Message-Id":"<20211119210239.18540-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211119210239.18540-1-laurent.pinchart@ideasonboard.com>","References":"<20211119210239.18540-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/5] ipa: ipu3: agc: Drop kMaxLuminance\n\tconstant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The kMaxLuminance constant is badly named, it's not a maximum luminance,\nbut the maximum integer value output by the AWB statistics engine for\nper-channel averages. The constant is used in a single place, hardcoding\nthe value is actually more readable.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \n---\n src/ipa/ipu3/algorithms/agc.cpp | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex bd02c474611c..43a39ffd57d6 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -61,9 +61,6 @@ static constexpr double kEvGainTarget = 0.5;\n /* Number of frames to wait before calculating stats on minimum exposure */\n static constexpr uint32_t kNumStartupFrames = 10;\n \n-/* Maximum luminance used for brightness normalization */\n-static constexpr uint32_t kMaxLuminance = 255;\n-\n /*\n * Normalized luma value target.\n *\n@@ -298,8 +295,7 @@ double Agc::computeInitialY(IPAFrameContext &frameContext,\n \t\t greenSum * frameContext.awb.gains.green * .587 +\n \t\t blueSum * frameContext.awb.gains.blue * .114;\n \n-\t/* Return the normalized relative luminance. */\n-\treturn Y_sum / (grid.height * grid.width) / kMaxLuminance;\n+\treturn Y_sum / (grid.height * grid.width) / 255;\n }\n \n /**\n","prefixes":["libcamera-devel","v2","1/5"]}