{"id":14644,"url":"https://patchwork.libcamera.org/api/1.1/patches/14644/?format=json","web_url":"https://patchwork.libcamera.org/patch/14644/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211119102559.56522-2-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-19T10:25:58","name":"[libcamera-devel,1/2] libipa: Round gain code before returning the value","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b5c1c429f8d901e5fea7f4bd18cb87a92dabc7c3","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14644/mbox/","series":[{"id":2733,"url":"https://patchwork.libcamera.org/api/1.1/series/2733/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2733","date":"2021-11-19T10:25:57","name":"libipa: Fix doc and imx219","version":1,"mbox":"https://patchwork.libcamera.org/series/2733/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14644/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14644/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52C42BDB13\n\tfor ;\n\tFri, 19 Nov 2021 10:26:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 027046037A;\n\tFri, 19 Nov 2021 11:26:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4531160233\n\tfor ;\n\tFri, 19 Nov 2021 11:26:10 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:db30:8e54:a96:9838])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E32F71974;\n\tFri, 19 Nov 2021 11:26:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JxO3yNp+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637317570;\n\tbh=SSb3qYmndLEnttp29l6Fr35d5hdTWH76Sr0H6uo5QPM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JxO3yNp+R5FEliqFVcHbJ9AeOBtl/noRww9YfQJeO6ScNpdDutg8XAHqW1Weq6YbG\n\tl4x59z/L8YpKxuFbCVq93RkNBbN29oH9+Pu6J+toZQh90RN/oLwYxBnWnVN+xctJei\n\tkLPpFGmdG4hcwMnAv8FP7iSlW0/oUJwOKwki0UCA=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Nov 2021 11:25:58 +0100","Message-Id":"<20211119102559.56522-2-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211119102559.56522-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211119102559.56522-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] libipa: Round gain code before\n\treturning the value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We can have the case where the gain is very close to 1, as coded in\ndouble, and after gainCode() returns, the value as an uint32_t is 0. In\norder to avoid that, always round the value halfway cases away from zero\nbefore returning.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 0b0eb503..67cf6913 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -7,6 +7,8 @@\n */\n #include \"camera_sensor_helper.h\"\n \n+#include \n+\n #include \n \n /**\n@@ -61,8 +63,8 @@ uint32_t CameraSensorHelper::gainCode(double gain) const\n \tASSERT(analogueGainConstants_.m0 == 0 || analogueGainConstants_.m1 == 0);\n \tASSERT(analogueGainConstants_.type == AnalogueGainLinear);\n \n-\treturn (analogueGainConstants_.c0 - analogueGainConstants_.c1 * gain) /\n-\t (analogueGainConstants_.m1 * gain - analogueGainConstants_.m0);\n+\treturn std::round((analogueGainConstants_.c0 - analogueGainConstants_.c1 * gain) /\n+\t\t\t (analogueGainConstants_.m1 * gain - analogueGainConstants_.m0));\n }\n \n /**\n","prefixes":["libcamera-devel","1/2"]}