{"id":14628,"url":"https://patchwork.libcamera.org/api/1.1/patches/14628/?format=json","web_url":"https://patchwork.libcamera.org/patch/14628/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211118151933.15627-4-david.plowman@raspberrypi.com>","date":"2021-11-18T15:19:29","name":"[libcamera-devel,v6,3/7] libcamera: Convert between ColorSpace class and V4L2 formats","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a2a4360eb9fb83040a8f210a9781aad00339c664","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14628/mbox/","series":[{"id":2726,"url":"https://patchwork.libcamera.org/api/1.1/series/2726/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2726","date":"2021-11-18T15:19:26","name":"Colour spaces","version":6,"mbox":"https://patchwork.libcamera.org/series/2726/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14628/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14628/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D6C6C324E\n\tfor ;\n\tThu, 18 Nov 2021 15:20:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70752603BE;\n\tThu, 18 Nov 2021 16:20:33 +0100 (CET)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A38826038A\n\tfor ;\n\tThu, 18 Nov 2021 16:20:27 +0100 (CET)","by mail-wm1-x32f.google.com with SMTP id i12so5666025wmq.4\n\tfor ;\n\tThu, 18 Nov 2021 07:20:27 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12sm147367wro.33.2021.11.18.07.20.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Nov 2021 07:20:26 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"b2Tt3jev\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dPpf98qt/hshLduLmlaFBnisRdBSpv5pU9YXKDl3Xjs=;\n\tb=b2Tt3jevLf9oa759VttX/WPtaOpnbDh5s1YQ+S4vu+aedyN2TDBDuQk2PvmuZAQtml\n\tRacMG6ksPPuI+7AAz6V/ZqJaNQLdCVgCftCmZtGVtfdsO9/vRyz2bJ6mIBelGmIOGEFS\n\tHG5dVgUvMvC+oIZGjLuce9mwqTlWe+wWUigTnJK0BjMua0wF/PwQESfOBPeTpo6yt2UI\n\tDrKFNDxfkUf/w0Y41k8CNTdwwQk3FXTtDrK56vX9COpH9JSa1j3FB7nc41N+Zg1BEoG2\n\tTh6Cx3RvYG3diaKomVawJRPR5e5PJcV2PixUuqxZkpsroKMW56iBBCt5BMHTlOu5cW3J\n\t6ZGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dPpf98qt/hshLduLmlaFBnisRdBSpv5pU9YXKDl3Xjs=;\n\tb=O8YFz5UAQ8GN2rS690SdKwFUzBV7MOj6Q+RcQsvO8iU1UL0okXV9cI4+sA6ZmZz0VB\n\tpDjS1L9IBl8VmJY9oGh1/Ry8atepS4+fBt0mJMmhgNtMwQrniEj9o8KHynO9185M/Jo+\n\tRuaOnfrY1yQJK4aYTAspYZ28NLy6n2obrf1DzAZUF1BJqPWmZQXt0YzOxOjp14LjMnJI\n\ts4KXI8mRYYvR94os0OGkmFiRgD2GP1u3SKqQYnWXy9rKILrNfvOLAvedAQJ1XCRNAPWm\n\t0U8q/3pfaqMUW8HPxdmHnk15RY0CRGeFHKRJkUQO1DPyAq7YTjAKZE2VO4C28LjB5wbX\n\tOx5w==","X-Gm-Message-State":"AOAM531FnWIHB9jRjRAa1dDvRZBNSK23wM2ZSKns6/cuttdPG3SnfDdW\n\tEz+Ev0uQYbbTnkuT/wo6phZabQ==","X-Google-Smtp-Source":"ABdhPJzzFR0pe5uoUdfZMWv3D0N3BD2HJFfwtBzQpBp+ILSdbj9eFHpKpoNCZxBjeYQWQ6wxuOAD5A==","X-Received":"by 2002:a05:600c:510d:: with SMTP id\n\to13mr10941598wms.104.1637248827302; \n\tThu, 18 Nov 2021 07:20:27 -0800 (PST)","From":"David Plowman ","To":"laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com,\n\thverkuil-cisco@xs4all.nl, tfiga@google.com, jacopo@jmondi.org,\n\tnaush@raspberrypi.com, libcamera-devel@lists.libcamera.org","Date":"Thu, 18 Nov 2021 15:19:29 +0000","Message-Id":"<20211118151933.15627-4-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20211118151933.15627-1-david.plowman@raspberrypi.com>","References":"<20211118151933.15627-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 3/7] libcamera: Convert between\n\tColorSpace class and V4L2 formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"These methods are added to the base V4L2Device class so that they can\nbe shared both by the video device class and subdevices.\n\nWith the ColorSpace class, the color space and related other fields\nare stored together, corresponding to a number of fields in the\nvarious different V4L2 format structures. Template methods are\ntherefore a convenient implementation, and we must explicitly\ninstantiate the templates that will be needed.\n\nNote that unset color spaces are converted to requests for the\ndevice's \"default\" color space.\n\nSigned-off-by: David Plowman \n---\n include/libcamera/internal/v4l2_device.h | 7 +\n src/libcamera/v4l2_device.cpp | 190 +++++++++++++++++++++++\n 2 files changed, 197 insertions(+)","diff":"diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex f21bc370..89ff6120 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -17,6 +17,7 @@\n #include \n #include \n \n+#include \n #include \n \n namespace libcamera {\n@@ -44,6 +45,12 @@ public:\n \n \tvoid updateControlInfo();\n \n+\ttemplate\n+\tstatic std::optional toColorSpace(const T &v4l2Format);\n+\n+\ttemplate\n+\tstatic int fromColorSpace(const std::optional &colorSpace, T &v4l2Format);\n+\n protected:\n \tV4L2Device(const std::string &deviceNode);\n \t~V4L2Device();\ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 9c783c9c..4d6985aa 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -16,6 +16,8 @@\n #include \n #include \n \n+#include \n+\n #include \n #include \n #include \n@@ -731,4 +733,192 @@ void V4L2Device::eventAvailable()\n \tframeStart.emit(event.u.frame_sync.frame_sequence);\n }\n \n+static const std::map v4l2ToColorSpace = {\n+\t{ V4L2_COLORSPACE_RAW, ColorSpace::Raw },\n+\t{ V4L2_COLORSPACE_JPEG, ColorSpace::Jpeg },\n+\t{ V4L2_COLORSPACE_SRGB, ColorSpace::Srgb },\n+\t{ V4L2_COLORSPACE_SMPTE170M, ColorSpace::Smpte170m },\n+\t{ V4L2_COLORSPACE_REC709, ColorSpace::Rec709 },\n+\t{ V4L2_COLORSPACE_BT2020, ColorSpace::Rec2020 },\n+};\n+\n+static const std::map v4l2ToYcbcrEncoding = {\n+\t{ V4L2_YCBCR_ENC_601, ColorSpace::YcbcrEncoding::Rec601 },\n+\t{ V4L2_YCBCR_ENC_709, ColorSpace::YcbcrEncoding::Rec709 },\n+\t{ V4L2_YCBCR_ENC_BT2020, ColorSpace::YcbcrEncoding::Rec2020 },\n+};\n+\n+static const std::map v4l2ToTransferFunction = {\n+\t{ V4L2_XFER_FUNC_NONE, ColorSpace::TransferFunction::Linear },\n+\t{ V4L2_XFER_FUNC_SRGB, ColorSpace::TransferFunction::Srgb },\n+\t{ V4L2_XFER_FUNC_709, ColorSpace::TransferFunction::Rec709 },\n+};\n+\n+static const std::map v4l2ToRange = {\n+\t{ V4L2_QUANTIZATION_FULL_RANGE, ColorSpace::Range::Full },\n+\t{ V4L2_QUANTIZATION_LIM_RANGE, ColorSpace::Range::Limited },\n+};\n+\n+static const std::vector> colorSpaceToV4l2 = {\n+\t{ ColorSpace::Raw, V4L2_COLORSPACE_RAW },\n+\t{ ColorSpace::Jpeg, V4L2_COLORSPACE_JPEG },\n+\t{ ColorSpace::Srgb, V4L2_COLORSPACE_SRGB },\n+\t{ ColorSpace::Smpte170m, V4L2_COLORSPACE_SMPTE170M },\n+\t{ ColorSpace::Rec709, V4L2_COLORSPACE_REC709 },\n+\t{ ColorSpace::Rec2020, V4L2_COLORSPACE_BT2020 },\n+};\n+\n+static const std::map primariesToV4l2 = {\n+\t{ ColorSpace::Primaries::Raw, V4L2_COLORSPACE_RAW },\n+\t{ ColorSpace::Primaries::Smpte170m, V4L2_COLORSPACE_SMPTE170M },\n+\t{ ColorSpace::Primaries::Rec709, V4L2_COLORSPACE_REC709 },\n+\t{ ColorSpace::Primaries::Rec2020, V4L2_COLORSPACE_BT2020 },\n+};\n+\n+static const std::map ycbcrEncodingToV4l2 = {\n+\t{ ColorSpace::YcbcrEncoding::Rec601, V4L2_YCBCR_ENC_601 },\n+\t{ ColorSpace::YcbcrEncoding::Rec709, V4L2_YCBCR_ENC_709 },\n+\t{ ColorSpace::YcbcrEncoding::Rec2020, V4L2_YCBCR_ENC_BT2020 },\n+};\n+\n+static const std::map transferFunctionToV4l2 = {\n+\t{ ColorSpace::TransferFunction::Linear, V4L2_XFER_FUNC_NONE },\n+\t{ ColorSpace::TransferFunction::Srgb, V4L2_XFER_FUNC_SRGB },\n+\t{ ColorSpace::TransferFunction::Rec709, V4L2_XFER_FUNC_709 },\n+};\n+\n+static const std::map rangeToV4l2 = {\n+\t{ ColorSpace::Range::Full, V4L2_QUANTIZATION_FULL_RANGE },\n+\t{ ColorSpace::Range::Limited, V4L2_QUANTIZATION_LIM_RANGE },\n+};\n+\n+/**\n+ * \\brief Convert the color space fields in a V4L2 format to a ColorSpace\n+ * \\param[in] v4l2Format A V4L2 format containing color space information\n+ *\n+ * The colorspace, ycbcr_enc, xfer_func and quantization fields within a\n+ * V4L2 format structure are converted to a corresponding ColorSpace.\n+ *\n+ * If any V4L2 fields are not recognised then we return an \"unset\"\n+ * color space.\n+ *\n+ * \\return The ColorSpace corresponding to the input V4L2 format\n+ */\n+template\n+std::optional V4L2Device::toColorSpace(const T &v4l2Format)\n+{\n+\tauto itColor = v4l2ToColorSpace.find(v4l2Format.colorspace);\n+\tif (itColor == v4l2ToColorSpace.end())\n+\t\treturn std::nullopt;\n+\n+\t/* This sets all the color space fields to the correct \"default\" values. */\n+\tColorSpace colorSpace = itColor->second;\n+\n+\tif (v4l2Format.ycbcr_enc != V4L2_YCBCR_ENC_DEFAULT) {\n+\t\tauto itYcbcrEncoding = v4l2ToYcbcrEncoding.find(v4l2Format.ycbcr_enc);\n+\t\tif (itYcbcrEncoding == v4l2ToYcbcrEncoding.end())\n+\t\t\treturn std::nullopt;\n+\n+\t\tcolorSpace.ycbcrEncoding = itYcbcrEncoding->second;\n+\t}\n+\n+\tif (v4l2Format.xfer_func != V4L2_XFER_FUNC_DEFAULT) {\n+\t\tauto itTransfer = v4l2ToTransferFunction.find(v4l2Format.xfer_func);\n+\t\tif (itTransfer == v4l2ToTransferFunction.end())\n+\t\t\treturn std::nullopt;\n+\n+\t\tcolorSpace.transferFunction = itTransfer->second;\n+\t}\n+\n+\tif (v4l2Format.quantization != V4L2_QUANTIZATION_DEFAULT) {\n+\t\tauto itRange = v4l2ToRange.find(v4l2Format.quantization);\n+\t\tif (itRange == v4l2ToRange.end())\n+\t\t\treturn std::nullopt;\n+\n+\t\tcolorSpace.range = itRange->second;\n+\t}\n+\n+\treturn colorSpace;\n+}\n+\n+template std::optional V4L2Device::toColorSpace(const struct v4l2_pix_format &);\n+template std::optional V4L2Device::toColorSpace(const struct v4l2_pix_format_mplane &);\n+template std::optional V4L2Device::toColorSpace(const struct v4l2_mbus_framefmt &);\n+\n+/**\n+ * \\brief Fill in the color space fields of a V4L2 format from a ColorSpace\n+ * \\param[in] colorSpace The ColorSpace to be converted\n+ * \\param[out] v4l2Format A V4L2 format containing color space information\n+ *\n+ * The colorspace, ycbcr_enc, xfer_func and quantization fields within a\n+ * V4L2 format structure are filled in from a corresponding ColorSpace.\n+ *\n+ * An error is returned if any of the V4L2 fields do not support the\n+ * value given in the ColorSpace. Such fields are set to the V4L2\n+ * \"default\" values, but all other fields are still filled in where\n+ * possible.\n+ *\n+ * If the color space is completely unset, \"default\" V4L2 values are used\n+ * everywhere, so a driver would then choose its preferred color space.\n+ *\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+template\n+int V4L2Device::fromColorSpace(const std::optional &colorSpace, T &v4l2Format)\n+{\n+\tint ret = 0;\n+\n+\tv4l2Format.colorspace = V4L2_COLORSPACE_DEFAULT;\n+\tv4l2Format.ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;\n+\tv4l2Format.xfer_func = V4L2_XFER_FUNC_DEFAULT;\n+\tv4l2Format.quantization = V4L2_QUANTIZATION_DEFAULT;\n+\n+\tif (!colorSpace)\n+\t\treturn ret;\n+\n+\tauto itColor = std::find_if(colorSpaceToV4l2.begin(), colorSpaceToV4l2.end(),\n+\t\t\t\t [&colorSpace](const auto &item) {\n+\t\t\t\t\t return colorSpace == item.first;\n+\t\t\t\t });\n+\tif (itColor != colorSpaceToV4l2.end()) {\n+\t\tv4l2Format.colorspace = itColor->second;\n+\t\t/* Leaving all the other fields as \"default\" should be fine. */\n+\t\treturn ret;\n+\t}\n+\n+\t/*\n+\t * If the colorSpace doesn't precisely match a standard color space,\n+\t * then we must choose a V4L2 colorspace with matching primaries.\n+\t */\n+\tauto itPrimaries = primariesToV4l2.find(colorSpace->primaries);\n+\tif (itPrimaries != primariesToV4l2.end())\n+\t\tv4l2Format.colorspace = itPrimaries->second;\n+\telse\n+\t\tret = -1;\n+\n+\tauto itYcbcrEncoding = ycbcrEncodingToV4l2.find(colorSpace->ycbcrEncoding);\n+\tif (itYcbcrEncoding != ycbcrEncodingToV4l2.end())\n+\t\tv4l2Format.ycbcr_enc = itYcbcrEncoding->second;\n+\telse\n+\t\tret = -1;\n+\n+\tauto itTransfer = transferFunctionToV4l2.find(colorSpace->transferFunction);\n+\tif (itTransfer != transferFunctionToV4l2.end())\n+\t\tv4l2Format.xfer_func = itTransfer->second;\n+\telse\n+\t\tret = -1;\n+\n+\tauto itRange = rangeToV4l2.find(colorSpace->range);\n+\tif (itRange != rangeToV4l2.end())\n+\t\tv4l2Format.quantization = itRange->second;\n+\telse\n+\t\tret = -1;\n+\n+\treturn ret;\n+}\n+\n+template int V4L2Device::fromColorSpace(const std::optional &, struct v4l2_pix_format &);\n+template int V4L2Device::fromColorSpace(const std::optional &, struct v4l2_pix_format_mplane &);\n+template int V4L2Device::fromColorSpace(const std::optional &, struct v4l2_mbus_framefmt &);\n+\n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v6","3/7"]}