{"id":14609,"url":"https://patchwork.libcamera.org/api/1.1/patches/14609/?format=json","web_url":"https://patchwork.libcamera.org/patch/14609/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211115161205.24335-4-david.plowman@raspberrypi.com>","date":"2021-11-15T16:12:01","name":"[libcamera-devel,v5,3/7] libcamera: Convert between ColorSpace class and V4L2 formats","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"77a639e06db803f5e6916f2b8b20aca0ffa466c5","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14609/mbox/","series":[{"id":2719,"url":"https://patchwork.libcamera.org/api/1.1/series/2719/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2719","date":"2021-11-15T16:11:58","name":"Colour spaces","version":5,"mbox":"https://patchwork.libcamera.org/series/2719/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14609/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14609/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E708FBF415\n\tfor ;\n\tMon, 15 Nov 2021 16:13:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D83B60378;\n\tMon, 15 Nov 2021 17:13:07 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DC32603B5\n\tfor ;\n\tMon, 15 Nov 2021 17:13:00 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id z200so14467944wmc.1\n\tfor ;\n\tMon, 15 Nov 2021 08:13:00 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tj40sm16315615wms.16.2021.11.15.08.12.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 15 Nov 2021 08:12:59 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"SVDT0CdL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ron3Qwrj+ZdHUA2wy9RhvrSwsJz/Iu9EfWpAou0UGIc=;\n\tb=SVDT0CdLxXi8aCC3BPK82DDg81ZHfsyAZxZTW2Pmog+vuN8WOGcKcl4p9s7OEEjZ4L\n\tu2TzLWq34nGUpXcvLDeCmqTpW6aNctll7s8zOZE5qRNKHqGXOHm5UIaoLlIu/o3zV/TS\n\tz4uACIyNlQsdccPMKPyk1I+efQ2Y5X1xffXVU2aUEm5sE+p5/TbhoFT0sKhPEyZ/MDkS\n\txSf4yQzvhQjBNdTilUE1K9YoYgAEA45p/2euspUw0hU2jev3uG3ykVVhlu4kLR9yZj8o\n\tYqUmhIjlWW305jYeGreJjmObxomqIY/y8O+Fm76DPd2lzsDd3wu/xBQ6WmzOPw1PayhV\n\tdpUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ron3Qwrj+ZdHUA2wy9RhvrSwsJz/Iu9EfWpAou0UGIc=;\n\tb=CqZJ4zebQFr/v9KPEsteBMZwp0pMnMPr0Gra/LqfsgX/7yvqBWWTWhzAggwaTXXP9f\n\tfK/YA7P7uzHn6g42bv/lr0ghI1zP3KjskiEEaiAh0juHIQV7fLXpguE0+32aR7GqepZs\n\t1NoFqErEqQhxsdHSu+vNcoWC36MX19lIBv7qaX2tV3+So/CpFVV9kfTqLxJs+c2dTEzn\n\tb8XgwaePFEVHkq2JsH+TO7yvaI2tNv7w+AR3nfUT9TImhmwD1J38PwQo7JLdOYIX6Q7R\n\tJuQbwAsVTJO+YH8w43A1c1yMqQ0cd9VREPykLbPa+Gi0REgprrUnhbm9qT3T65H2Bth8\n\tmFpA==","X-Gm-Message-State":"AOAM530e0bs+rfVQiUiWvYy6npHLvrxfDyoC+5pTM0CRcXuGy/4YjJyC\n\trurtC3OhKQv7p3eR/4XL+GAa3Q==","X-Google-Smtp-Source":"ABdhPJyt34JW8D7D2kDHVxQmDUYI2FPOw8LtftUURiG9ktdpOijzgfXTalEEUHAmkhy7i3AbWapMZg==","X-Received":"by 2002:a7b:cb55:: with SMTP id\n\tv21mr43652039wmj.83.1636992779865; \n\tMon, 15 Nov 2021 08:12:59 -0800 (PST)","From":"David Plowman ","To":"hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,\n\tkieran.bingham@ideasonboard.com, jacopo@jmondi.org, tfiga@google.com, \n\tnaush@raspberrypi.com, libcamera-devel@lists.libcamera.org","Date":"Mon, 15 Nov 2021 16:12:01 +0000","Message-Id":"<20211115161205.24335-4-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20211115161205.24335-1-david.plowman@raspberrypi.com>","References":"<20211115161205.24335-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 3/7] libcamera: Convert between\n\tColorSpace class and V4L2 formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"These methods are added to the base V4L2Device class so that they can\nbe shared both by the video device class and subdevices.\n\nWith the ColorSpace class, the color space and related other fields\nare stored together, corresponding to a number of fields in the\nvarious different V4L2 format structures. Template methods are\ntherefore a convenient implementation.\n\nNote that we must explicitly instantiate the templates that will be\nneeded.\n\nSigned-off-by: David Plowman \n---\n include/libcamera/internal/v4l2_device.h | 7 +\n src/libcamera/v4l2_device.cpp | 171 +++++++++++++++++++++++\n 2 files changed, 178 insertions(+)","diff":"diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex f21bc370..24fc4984 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -17,6 +17,7 @@\n #include \n #include \n \n+#include \n #include \n \n namespace libcamera {\n@@ -44,6 +45,12 @@ public:\n \n \tvoid updateControlInfo();\n \n+\ttemplate\n+\tstatic ColorSpace toColorSpace(const T &v4l2Format);\n+\n+\ttemplate\n+\tstatic int fromColorSpace(const ColorSpace &colorSpace, T &v4l2Format);\n+\n protected:\n \tV4L2Device(const std::string &deviceNode);\n \t~V4L2Device();\ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 9c783c9c..34ec2bf3 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -16,6 +16,8 @@\n #include \n #include \n \n+#include \n+\n #include \n #include \n #include \n@@ -731,4 +733,173 @@ void V4L2Device::eventAvailable()\n \tframeStart.emit(event.u.frame_sync.frame_sequence);\n }\n \n+static const std::map v4l2ToColorSpace = {\n+\t{ V4L2_COLORSPACE_RAW, ColorSpace::Raw },\n+\t{ V4L2_COLORSPACE_JPEG, ColorSpace::Jpeg },\n+\t{ V4L2_COLORSPACE_SRGB, ColorSpace::Jpeg },\n+\t{ V4L2_COLORSPACE_SMPTE170M, ColorSpace::Smpte170m },\n+\t{ V4L2_COLORSPACE_REC709, ColorSpace::Rec709 },\n+\t{ V4L2_COLORSPACE_BT2020, ColorSpace::Rec2020 },\n+};\n+\n+static const std::map v4l2ToYcbcrEncoding = {\n+\t{ V4L2_YCBCR_ENC_601, ColorSpace::YcbcrEncoding::Rec601 },\n+\t{ V4L2_YCBCR_ENC_709, ColorSpace::YcbcrEncoding::Rec709 },\n+\t{ V4L2_YCBCR_ENC_BT2020, ColorSpace::YcbcrEncoding::Rec2020 },\n+};\n+\n+static const std::map v4l2ToTransferFunction = {\n+\t{ V4L2_XFER_FUNC_NONE, ColorSpace::TransferFunction::Linear },\n+\t{ V4L2_XFER_FUNC_SRGB, ColorSpace::TransferFunction::Srgb },\n+\t{ V4L2_XFER_FUNC_709, ColorSpace::TransferFunction::Rec709 },\n+};\n+\n+static const std::map v4l2ToRange = {\n+\t{ V4L2_QUANTIZATION_FULL_RANGE, ColorSpace::Range::Full },\n+\t{ V4L2_QUANTIZATION_LIM_RANGE, ColorSpace::Range::Limited },\n+};\n+\n+static const std::vector> colorSpaceToV4l2 = {\n+\t{ ColorSpace::Raw, V4L2_COLORSPACE_RAW },\n+\t{ ColorSpace::Jpeg, V4L2_COLORSPACE_JPEG },\n+\t{ ColorSpace::Smpte170m, V4L2_COLORSPACE_SMPTE170M },\n+\t{ ColorSpace::Rec709, V4L2_COLORSPACE_REC709 },\n+\t{ ColorSpace::Rec2020, V4L2_COLORSPACE_BT2020 },\n+};\n+\n+static const std::map primariesToV4l2 = {\n+\t{ ColorSpace::Primaries::Raw, V4L2_COLORSPACE_RAW },\n+\t{ ColorSpace::Primaries::Smpte170m, V4L2_COLORSPACE_SMPTE170M },\n+\t{ ColorSpace::Primaries::Rec709, V4L2_COLORSPACE_REC709 },\n+\t{ ColorSpace::Primaries::Rec2020, V4L2_COLORSPACE_BT2020 },\n+};\n+\n+static const std::map ycbcrEncodingToV4l2 = {\n+\t{ ColorSpace::YcbcrEncoding::Rec601, V4L2_YCBCR_ENC_601 },\n+\t{ ColorSpace::YcbcrEncoding::Rec709, V4L2_YCBCR_ENC_709 },\n+\t{ ColorSpace::YcbcrEncoding::Rec2020, V4L2_YCBCR_ENC_BT2020 },\n+};\n+\n+static const std::map transferFunctionToV4l2 = {\n+\t{ ColorSpace::TransferFunction::Linear, V4L2_XFER_FUNC_NONE },\n+\t{ ColorSpace::TransferFunction::Srgb, V4L2_XFER_FUNC_SRGB },\n+\t{ ColorSpace::TransferFunction::Rec709, V4L2_XFER_FUNC_709 },\n+};\n+\n+static const std::map rangeToV4l2 = {\n+\t{ ColorSpace::Range::Full, V4L2_QUANTIZATION_FULL_RANGE },\n+\t{ ColorSpace::Range::Limited, V4L2_QUANTIZATION_LIM_RANGE },\n+};\n+\n+/**\n+ * \\brief Convert the color space fields in a V4L2 format to a ColorSpace\n+ * \\param[in] v4l2Format A V4L2 format containing color space information\n+ *\n+ * The colorspace, ycbcr_enc, xfer_func and quantization fields within a\n+ * V4L2 format structure are converted to a corresponding ColorSpace.\n+ *\n+ * If any V4L2 fields are not recognised those are marked as undefined in\n+ * the ColorSpace, but other fields are still initialised where possible.\n+ * This situation can be detected using the returned value's\n+ * ColorSpace::isFullyDefined() method.\n+ *\n+ * \\return The ColorSpace corresponding to the input V4L2 format\n+ */\n+template\n+ColorSpace V4L2Device::toColorSpace(const T &v4l2Format)\n+{\n+\tColorSpace colorSpace;\n+\n+\tauto itColor = v4l2ToColorSpace.find(v4l2Format.colorspace);\n+\tif (itColor != v4l2ToColorSpace.end())\n+\t\tcolorSpace = itColor->second;\n+\n+\tauto itYcbcrEncoding = v4l2ToYcbcrEncoding.find(v4l2Format.ycbcr_enc);\n+\tif (itYcbcrEncoding != v4l2ToYcbcrEncoding.end())\n+\t\tcolorSpace.ycbcrEncoding = itYcbcrEncoding->second;\n+\n+\tauto itTransfer = v4l2ToTransferFunction.find(v4l2Format.xfer_func);\n+\tif (itTransfer != v4l2ToTransferFunction.end())\n+\t\tcolorSpace.transferFunction = itTransfer->second;\n+\n+\tauto itRange = v4l2ToRange.find(v4l2Format.quantization);\n+\tif (itRange != v4l2ToRange.end())\n+\t\tcolorSpace.range = itRange->second;\n+\n+\treturn colorSpace;\n+}\n+\n+template ColorSpace V4L2Device::toColorSpace(const struct v4l2_pix_format &);\n+template ColorSpace V4L2Device::toColorSpace(const struct v4l2_pix_format_mplane &);\n+template ColorSpace V4L2Device::toColorSpace(const struct v4l2_mbus_framefmt &);\n+\n+/**\n+ * \\brief Fill in the color space fields of a V4L2 format from a ColorSpace\n+ * \\param[in] colorSpace The ColorSpace to be converted\n+ * \\param[out] v4l2Format A V4L2 format containing color space information\n+ *\n+ * The colorspace, ycbcr_enc, xfer_func and quantization fields within a\n+ * V4L2 format structure are filled in from a corresponding ColorSpace.\n+ *\n+ * An error is returned if any of the V4L2 fields do not support the\n+ * value given in the ColorSpace. Such fields are set to the V4L2\n+ * \"default\" values, but all other fields are still filled in where\n+ * possible.\n+ *\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+template\n+int V4L2Device::fromColorSpace(const ColorSpace &colorSpace, T &v4l2Format)\n+{\n+\tint ret = 0;\n+\n+\tv4l2Format.colorspace = V4L2_COLORSPACE_DEFAULT;\n+\tv4l2Format.ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;\n+\tv4l2Format.xfer_func = V4L2_XFER_FUNC_DEFAULT;\n+\tv4l2Format.quantization = V4L2_QUANTIZATION_DEFAULT;\n+\n+\tauto itColor = std::find_if(colorSpaceToV4l2.begin(), colorSpaceToV4l2.end(),\n+\t\t\t\t [&colorSpace](const auto &item) {\n+\t\t\t\t\t return colorSpace == item.first;\n+\t\t\t\t });\n+\tif (itColor != colorSpaceToV4l2.end()) {\n+\t\tv4l2Format.colorspace = itColor->second;\n+\t\treturn ret;\n+\t}\n+\n+\t/*\n+\t * If the colorSpace doesn't precisely match a standard color space,\n+\t * then we must choose a V4L2 colorspace with matching primaries.\n+\t */\n+\tauto itPrimaries = primariesToV4l2.find(colorSpace.primaries);\n+\tif (itPrimaries != primariesToV4l2.end())\n+\t\tv4l2Format.colorspace = itPrimaries->second;\n+\telse\n+\t\tret = -1;\n+\n+\tauto itYcbcrEncoding = ycbcrEncodingToV4l2.find(colorSpace.ycbcrEncoding);\n+\tif (itYcbcrEncoding != ycbcrEncodingToV4l2.end())\n+\t\tv4l2Format.ycbcr_enc = itYcbcrEncoding->second;\n+\telse\n+\t\tret = -1;\n+\n+\tauto itTransfer = transferFunctionToV4l2.find(colorSpace.transferFunction);\n+\tif (itTransfer != transferFunctionToV4l2.end())\n+\t\tv4l2Format.xfer_func = itTransfer->second;\n+\telse\n+\t\tret = -1;\n+\n+\tauto itRange = rangeToV4l2.find(colorSpace.range);\n+\tif (itRange != rangeToV4l2.end())\n+\t\tv4l2Format.quantization = itRange->second;\n+\telse\n+\t\tret = -1;\n+\n+\treturn ret;\n+}\n+\n+template int V4L2Device::fromColorSpace(const ColorSpace &, struct v4l2_pix_format &);\n+template int V4L2Device::fromColorSpace(const ColorSpace &, struct v4l2_pix_format_mplane &);\n+template int V4L2Device::fromColorSpace(const ColorSpace &, struct v4l2_mbus_framefmt &);\n+\n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v5","3/7"]}