{"id":14596,"url":"https://patchwork.libcamera.org/api/1.1/patches/14596/?format=json","web_url":"https://patchwork.libcamera.org/patch/14596/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211113084947.21892-7-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-13T08:49:39","name":"[libcamera-devel,v5,06/14] ipa: ipu3: agc: Refactor ev gain calculation and testing","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"23c19e095c36aff65ec8f686ee46cc340ac240df","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14596/mbox/","series":[{"id":2717,"url":"https://patchwork.libcamera.org/api/1.1/series/2717/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2717","date":"2021-11-13T08:49:33","name":"IPA: IPU3: Introduce per-frame controls","version":5,"mbox":"https://patchwork.libcamera.org/series/2717/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14596/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14596/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E80BBDB1C\n\tfor ;\n\tSat, 13 Nov 2021 08:50:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DE01603BE;\n\tSat, 13 Nov 2021 09:49:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 016D960371\n\tfor ;\n\tSat, 13 Nov 2021 09:49:52 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:4d35:9445:6881:4ffd])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B14FA1875;\n\tSat, 13 Nov 2021 09:49:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"af6abFfk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636793391;\n\tbh=CYzs0lL4OB90psMr5a0ZMVciVBGNeZuxkR+LeIfhqEA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=af6abFfk+5nFFk7WUGZ8ULaX/ZCRNU1wAJushrUBm1HGF4rKVlAq5yKRds+EJpCjc\n\txPy3Wb97cOkyvHbCQgb5xznlzPsNNf+2dZcHfI0CUT3exSt7D6+Pg8ANjbmYD/DTVn\n\twKsV//34bjXDndK+1ua3HJ9AjOJjV5Bew1ZO6z70=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 13 Nov 2021 09:49:39 +0100","Message-Id":"<20211113084947.21892-7-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211113084947.21892-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211113084947.21892-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 06/14] ipa: ipu3: agc: Refactor ev gain\n\tcalculation and testing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When we compute the new gain, we use the iqMean_ and estimate an\nexposure value gain to apply. Return early when the gain is less than\n1%.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Paul Elder \n---\n src/ipa/ipu3/algorithms/agc.cpp | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 74bce7bb..61ca8b3f 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -188,14 +188,6 @@ void Agc::filterExposure()\n */\n void Agc::computeExposure(IPAFrameContext &frameContext)\n {\n-\n-\t/* Are we correctly exposed ? */\n-\tif (std::abs(iqMean_ - kEvGainTarget * knumHistogramBins) <= 1) {\n-\t\tLOG(IPU3Agc, Debug) << \"We are well exposed (iqMean = \"\n-\t\t\t\t << iqMean_ << \")\";\n-\t\treturn;\n-\t}\n-\n \t/* Get the effective exposure and gain applied on the sensor. */\n \tuint32_t exposure = frameContext.sensor.exposure;\n \tdouble analogueGain = frameContext.sensor.gain;\n@@ -203,6 +195,12 @@ void Agc::computeExposure(IPAFrameContext &frameContext)\n \t/* Estimate the gain needed to have the proportion wanted */\n \tdouble evGain = kEvGainTarget * knumHistogramBins / iqMean_;\n \n+\tif (std::abs(evGain - 1.0) < 0.01) {\n+\t\tLOG(IPU3Agc, Debug) << \"We are well exposed (iqMean = \"\n+\t\t\t\t << iqMean_ << \")\";\n+\t\treturn;\n+\t}\n+\n \t/* extracted from Rpi::Agc::computeTargetExposure */\n \t/* Calculate the shutter time in seconds */\n \tutils::Duration currentShutter = exposure * lineDuration_;\n","prefixes":["libcamera-devel","v5","06/14"]}