{"id":14572,"url":"https://patchwork.libcamera.org/api/1.1/patches/14572/?format=json","web_url":"https://patchwork.libcamera.org/patch/14572/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211111140928.136111-3-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-11T14:09:16","name":"[libcamera-devel,v4,02/14] ipu3: ipa: Report effective sensor controls with statistics to IPA","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"01b7ebec9cf05bdd7267d536edaaaedfe15fa9e2","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14572/mbox/","series":[{"id":2714,"url":"https://patchwork.libcamera.org/api/1.1/series/2714/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2714","date":"2021-11-11T14:09:14","name":"IPA: IPU3: Introduce per-frame controls","version":4,"mbox":"https://patchwork.libcamera.org/series/2714/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14572/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14572/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A40CBBDB1C\n\tfor ;\n\tThu, 11 Nov 2021 14:09:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53035603BE;\n\tThu, 11 Nov 2021 15:09:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 958416034D\n\tfor ;\n\tThu, 11 Nov 2021 15:09:31 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e627:8337:a781:d98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B5711253;\n\tThu, 11 Nov 2021 15:09:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RaWAoleY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636639771;\n\tbh=Mu1TU/yh1YDWahDJAs7Sa7vaoW7Kmpa57HarVGJRSUw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RaWAoleYpJIQGsBj56hJk6B24Xhv4yYeAPP+Sz1rkZTuFYD38hbB0WRSQL5ROCC8q\n\tX2qJnUK2TzmFS62dcQoMbaDqznoU1NTr+nP35pJkEsRCna0GB6kXbTckRYTmfb3vuS\n\t923oVaFTcI5p4XxLkCq3yMg2G+N/dFWfJEjwJ1Os=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 11 Nov 2021 15:09:16 +0100","Message-Id":"<20211111140928.136111-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 02/14] ipu3: ipa: Report effective\n\tsensor controls with statistics to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Han-Lin Chen \n\nThe Intel close sourced IPA requires the effective controls applied to\nthe sensor when the statistics are generated. Report effective sensor controls\nwith the statistics to IPA.\n\nSigned-off-by: Han-Lin Chen \n[Jean-Michel: Reword s/stastistics/statistics and move reset after IPA\nstart]\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \n---\n src/libcamera/pipeline/ipu3/frames.h | 4 ++++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n 2 files changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\nindex 3ef7e445..614701e2 100644\n--- a/src/libcamera/pipeline/ipu3/frames.h\n+++ b/src/libcamera/pipeline/ipu3/frames.h\n@@ -14,6 +14,8 @@\n \n #include \n \n+#include \n+\n namespace libcamera {\n \n class FrameBuffer;\n@@ -34,6 +36,8 @@ public:\n \t\tFrameBuffer *paramBuffer;\n \t\tFrameBuffer *statBuffer;\n \n+\t\tControlList effectiveSensorControls;\n+\n \t\tbool paramDequeued;\n \t\tbool metadataProcessed;\n \t};\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 8816efc5..c984ed12 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -767,6 +767,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n \tif (ret)\n \t\tgoto error;\n \n+\tdata->delayedCtrls_->reset();\n+\n \t/*\n \t * Start the ImgU video devices, buffers will be queued to the\n \t * ImgU output and viewfinder when requests will be queued.\n@@ -1363,6 +1365,8 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \trequest->metadata().set(controls::SensorTimestamp,\n \t\t\t\tbuffer->metadata().timestamp);\n \n+\tinfo->effectiveSensorControls = delayedCtrls_->get(buffer->metadata().sequence);\n+\n \tif (request->findBuffer(&rawStream_))\n \t\tpipe()->completeBuffer(request, buffer);\n \n@@ -1419,6 +1423,7 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tev.frame = info->id;\n \tev.bufferId = info->statBuffer->cookie();\n \tev.frameTimestamp = request->metadata().get(controls::SensorTimestamp);\n+\tev.sensorControls = info->effectiveSensorControls;\n \tipa_->processEvent(ev);\n }\n \n","prefixes":["libcamera-devel","v4","02/14"]}