{"id":14539,"url":"https://patchwork.libcamera.org/api/1.1/patches/14539/?format=json","web_url":"https://patchwork.libcamera.org/patch/14539/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211110195901.85597-13-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-10T19:58:59","name":"[libcamera-devel,v2,12/14] ipa: ipu3: Cache line duration at configure call","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"dec5046c12a786f4a42ee7aa0aed25cfa4397c8f","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14539/mbox/","series":[{"id":2708,"url":"https://patchwork.libcamera.org/api/1.1/series/2708/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2708","date":"2021-11-10T19:58:47","name":"IPA: IPU3: Introduce per-frame controls","version":2,"mbox":"https://patchwork.libcamera.org/series/2708/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14539/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14539/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAFE7C3252\n\tfor ;\n\tWed, 10 Nov 2021 19:59:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9AFF6603B5;\n\tWed, 10 Nov 2021 20:59:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 682256035A\n\tfor ;\n\tWed, 10 Nov 2021 20:59:08 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:7713:3465:89e6:c5cd])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28F198BB;\n\tWed, 10 Nov 2021 20:59:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A4MIGnoS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636574348;\n\tbh=Y5+8e0if8PJu2nwjoP6woC2NVmFfYH6j/iRq9KhM31k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A4MIGnoSEoUn9vWdpyqrt0QD/fH2Hb3yaMGkRhVtijdJZvMf0VejpuwwoYrvxrJWL\n\tLppAECwORKdePGqGUZnKcUzWhMtnfjP9/EPUZAZtKhg2CRdKs5RqMqjJrVggzjWhk2\n\t+Dp6dVccuzHkrxj4V2rujK2TVKqjQX1RgAtoo2nA=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 10 Nov 2021 20:58:59 +0100","Message-Id":"<20211110195901.85597-13-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 12/14] ipa: ipu3: Cache line duration\n\tat configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We use the line duration several times in the IPAIPU3. Instead of\nrecalculating it each time, cache the value as a utils::Duration. When\nthe value is needed in double, call the intern count() function to get\nit.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/ipu3.cpp | 17 +++++++++--------\n 1 file changed, 9 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex eb8c0dc4..68a97e8e 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -174,6 +174,8 @@ private:\n \tuint32_t minGain_;\n \tuint32_t maxGain_;\n \n+\tutils::Duration lineDuration_;\n+\n \t/* Interface to the Camera Helper */\n \tstd::unique_ptr camHelper_;\n \n@@ -195,8 +197,8 @@ void IPAIPU3::updateSessionConfiguration(const IPACameraSensorInfo &sensorInfo,\n \tint32_t minExposure = v4l2Exposure.min().get();\n \tint32_t maxExposure = v4l2Exposure.max().get();\n \n-\tutils::Duration lineDuration = sensorInfo.lineLength * 1.0s\n-\t\t\t\t / sensorInfo.pixelRate;\n+\tlineDuration_ = sensorInfo.lineLength * 1.0s\n+\t\t / sensorInfo.pixelRate;\n \n \tconst ControlInfo &v4l2Gain = sensorControls.find(V4L2_CID_ANALOGUE_GAIN)->second;\n \tint32_t minGain = v4l2Gain.min().get();\n@@ -209,8 +211,8 @@ void IPAIPU3::updateSessionConfiguration(const IPACameraSensorInfo &sensorInfo,\n \t *\n \t * \\todo take VBLANK into account for maximum shutter speed\n \t */\n-\tcontext_.configuration.agc.minShutterSpeed = minExposure * lineDuration;\n-\tcontext_.configuration.agc.maxShutterSpeed = maxExposure * lineDuration;\n+\tcontext_.configuration.agc.minShutterSpeed = minExposure * lineDuration_;\n+\tcontext_.configuration.agc.maxShutterSpeed = maxExposure * lineDuration_;\n \tcontext_.configuration.agc.minAnalogueGain = camHelper_->gain(minGain);\n \tcontext_.configuration.agc.maxAnalogueGain = camHelper_->gain(maxGain);\n }\n@@ -239,11 +241,10 @@ void IPAIPU3::updateControls(const IPACameraSensorInfo &sensorInfo,\n \t * exposure min, max and default and convert it from lines to\n \t * microseconds.\n \t */\n-\tdouble lineDuration = sensorInfo.lineLength / (sensorInfo.pixelRate / 1e6);\n \tconst ControlInfo &v4l2Exposure = sensorControls.find(V4L2_CID_EXPOSURE)->second;\n-\tint32_t minExposure = v4l2Exposure.min().get() * lineDuration;\n-\tint32_t maxExposure = v4l2Exposure.max().get() * lineDuration;\n-\tint32_t defExposure = v4l2Exposure.def().get() * lineDuration;\n+\tint32_t minExposure = v4l2Exposure.min().get() * lineDuration_.count();\n+\tint32_t maxExposure = v4l2Exposure.max().get() * lineDuration_.count();\n+\tint32_t defExposure = v4l2Exposure.def().get() * lineDuration_.count();\n \tcontrols[&controls::ExposureTime] = ControlInfo(minExposure, maxExposure,\n \t\t\t\t\t\t\tdefExposure);\n \n","prefixes":["libcamera-devel","v2","12/14"]}