{"id":14531,"url":"https://patchwork.libcamera.org/api/1.1/patches/14531/?format=json","web_url":"https://patchwork.libcamera.org/patch/14531/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211110195901.85597-4-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-10T19:58:50","name":"[libcamera-devel,v2,03/14] ipa: ipu3: Use sensor controls to update frameContext","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ad03a38295c56a42ff5d93d50d69131f6ac6f15d","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14531/mbox/","series":[{"id":2708,"url":"https://patchwork.libcamera.org/api/1.1/series/2708/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2708","date":"2021-11-10T19:58:47","name":"IPA: IPU3: Introduce per-frame controls","version":2,"mbox":"https://patchwork.libcamera.org/series/2708/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14531/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14531/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6573ABDB1C\n\tfor ;\n\tWed, 10 Nov 2021 19:59:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2B9C6035F;\n\tWed, 10 Nov 2021 20:59:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4E8E6035D\n\tfor ;\n\tWed, 10 Nov 2021 20:59:06 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:7713:3465:89e6:c5cd])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 617BC119F;\n\tWed, 10 Nov 2021 20:59:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YTOlUJRO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636574346;\n\tbh=7IODOKBDi/ZsBc6GXmQAqV6fx53ViiQkcWxUqo0OejU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YTOlUJROh60DEfj2Zh3nHIcspv4xbLPt3d3IkEEilRVV2k1reOLiYh6cOsolXO6n1\n\tlbbDsrzkkUkU2Wo9B56ERuz6ZsXWcl6ww9DoABgM6WTF8ZpVlQr46sVJ6KDFJ9kbg4\n\t5FP4WfpJhpBDzGN3wSRNPxgRTE28Iz6qLt/tpvxM=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 10 Nov 2021 20:58:50 +0100","Message-Id":"<20211110195901.85597-4-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 03/14] ipa: ipu3: Use sensor controls\n\tto update frameContext","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The pipeline handler populates the new sensorControls ControlList, to\nhave the effective exposure and gain values for the current frame. This\nis done when a statistics buffer is received.\n\nMake those values the frameContext::agc values for the frame when the\nEventStatReady event is received.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/ipu3.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex bcc3863b..1111f200 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -549,6 +549,10 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n \t\tconst ipu3_uapi_stats_3a *stats =\n \t\t\treinterpret_cast(mem.data());\n \n+\t\t/* \\todo move those into processControls ? */\n+\t\tcontext_.frameContext.agc.exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n+\t\tcontext_.frameContext.agc.gain = camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n+\n \t\tparseStatistics(event.frame, event.frameTimestamp, stats);\n \t\tbreak;\n \t}\n","prefixes":["libcamera-devel","v2","03/14"]}