{"id":14515,"url":"https://patchwork.libcamera.org/api/1.1/patches/14515/?format=json","web_url":"https://patchwork.libcamera.org/patch/14515/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211110100802.349623-1-naush@raspberrypi.com>","date":"2021-11-10T10:08:00","name":"[libcamera-devel,1/3] pipeline: raspberrypi: Add const qualifer in isRaw()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bea63309db0714abca4b5bcbdb271f58de5f418c","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14515/mbox/","series":[{"id":2703,"url":"https://patchwork.libcamera.org/api/1.1/series/2703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2703","date":"2021-11-10T10:08:00","name":"[libcamera-devel,1/3] pipeline: raspberrypi: Add const qualifer in isRaw()","version":1,"mbox":"https://patchwork.libcamera.org/series/2703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14515/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14515/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0C96BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 10:08:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D708360369;\n\tWed, 10 Nov 2021 11:08:08 +0100 (CET)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D1D260128\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Nov 2021 11:08:07 +0100 (CET)","by mail-wm1-x32e.google.com with SMTP id\n\t67-20020a1c1946000000b0030d4c90fa87so1533790wmz.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Nov 2021 02:08:07 -0800 (PST)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:8747:6ef9:ee17:3d59])\n\tby smtp.gmail.com with ESMTPSA id\n\td11sm21969133wrs.38.2021.11.10.02.08.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Nov 2021 02:08:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"U520UgS4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=OKJ83LIZfKI/rMNx9S3vEJe8UFBnXztTDF+aa2w7T3w=;\n\tb=U520UgS41XZXV+D75XUCAcdkx8QeCGPmZOm/LZlJkIvgmffhpRTT+Ao3AGV0aT99fn\n\tGXR9yuWR7ljIfH29j2YheFGpwuW4K0g76uq9IgzGePtSbH8h1gk08RgxGzDAods6AuGH\n\to3f1CEPWUcOFJaZNDk2mOWmCkqq0PSQZPxTjzyqtHzdtRkbiAagv7/IcbG+MNIGv3YNd\n\tPXA7yp99TW1txkoNIVlkzxWP1juaqLxCdntkY1C0fJk+RZW6CVoB2sCXfW97qmDCT9sh\n\thA3tgK+rd9YBkekydId96+AHYNR2mmx2yVihP3FJiGPS1E0GsFTHederneQrbDx78/3j\n\tBKyw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=OKJ83LIZfKI/rMNx9S3vEJe8UFBnXztTDF+aa2w7T3w=;\n\tb=rbcfoc06g1mXtrJ393KONALpOD+/8ZFQVcfQ++u3F1ViQ9KN0ZND4vn6p+jZTycOaz\n\tpfTDpbyoBBlLNJmv61h5d9LzpEYwQopK+ZkcH47K2AzxUqTf6Ar2HWkQYQ6pR9uZm3n9\n\tMes4MuDwMA1l++2hRNTikEDBY8Feafjlxh7Y/xiUAe8A4LWJeNhTqt/kMj7HUubguhDR\n\tPI9N7RyspKp44TpMXkTdu8C+GKLONVyRqkZD237wPhh82d7cuyIWyVuX62fCJgswsXIh\n\tmhrf9Gi7ZYoKGShPZ9vgz/KCvqt/XKs3s/qSrjQudtVBDOGNvs22HgeIp7DaSwCQk/5u\n\tMDpA==","X-Gm-Message-State":"AOAM532myyx5qwQeU9Dso5LCLYCJZ6kTzjc/J7DPMvHJCVQ2+x8nRSXc\n\tiGP2F42RBVXI6XMN0VZcUScQATHTHIV2w4A4","X-Google-Smtp-Source":"ABdhPJyVzNgFeaphjIxrSg8vku8YiuG3xnMpYZJ55l8TAbiazieKsR3SvMphIiOsanYIhUW49LH6Pg==","X-Received":"by 2002:a05:600c:253:: with SMTP id\n\t19mr14957968wmj.179.1636538887058; \n\tWed, 10 Nov 2021 02:08:07 -0800 (PST)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 10 Nov 2021 10:08:00 +0000","Message-Id":"<20211110100802.349623-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Roman Stratiienko <r.stratiienko@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"This function does not modify the pixFmt parameter, so use a const qualifier.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 5e1f227398a9..11d3c2b120dd 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,\n \treturn deviceFormat;\n }\n \n-bool isRaw(PixelFormat &pixFmt)\n+bool isRaw(const PixelFormat &pixFmt)\n {\n \t/*\n \t * The isRaw test might be redundant right now the pipeline handler only\n","prefixes":["libcamera-devel","1/3"]}