{"id":14479,"url":"https://patchwork.libcamera.org/api/1.1/patches/14479/?format=json","web_url":"https://patchwork.libcamera.org/patch/14479/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211108131350.130665-11-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-08T13:13:38","name":"[libcamera-devel,10/22] ipu3: Move delayedControls reset after IPA is started","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4e99f2032ee654926bb8785d27bb7112fcb9e2d4","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14479/mbox/","series":[{"id":2696,"url":"https://patchwork.libcamera.org/api/1.1/series/2696/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2696","date":"2021-11-08T13:13:28","name":"IPA: IPU3: Introduce per-frame controls","version":1,"mbox":"https://patchwork.libcamera.org/series/2696/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14479/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14479/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9C13C3250\n\tfor ;\n\tMon, 8 Nov 2021 13:14:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B4EA60451;\n\tMon, 8 Nov 2021 14:14:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 327EB6036E\n\tfor ;\n\tMon, 8 Nov 2021 14:14:01 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EBEE218CE;\n\tMon, 8 Nov 2021 14:14:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QSFJnQR0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636377241;\n\tbh=Pai8YVjZRK0wB27hmZvREjBbgZ7WIqWptOPn3cGDj4M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QSFJnQR0PsGUMT1ydykjKlcV151bUK7fP6DuWBFLeg+diNFZonYS7y922np7/Ni/Q\n\toyJn6P9zVNkYAFdywuHQDcAfcxPjVhrtlf8TgkZ50XhxfPsLqYG/leDitcOlTZomC4\n\tBhPDhsj96pmlW0c9o6aM3GKLb7SXe6fJ7Mmzfz6E=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Nov 2021 14:13:38 +0100","Message-Id":"<20211108131350.130665-11-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 10/22] ipu3: Move delayedControls reset\n\tafter IPA is started","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We can call configure multiple times and we don't need to reset\ndelayedControls for each of the configure calls. Reset it after the IPA\nis started.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 6a7f5b9a..3fcfa777 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -667,8 +667,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \t}\n \n-\tdata->delayedCtrls_->reset();\n-\n \treturn updateControls(data);\n }\n \n@@ -769,6 +767,12 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n \tif (ret)\n \t\tgoto error;\n \n+\t/*\n+\t * Reset the delayed controls with the gain and exposure values set by\n+\t * the IPA.\n+\t */\n+\tdata->delayedCtrls_->reset();\n+\n \t/*\n \t * Start the ImgU video devices, buffers will be queued to the\n \t * ImgU output and viewfinder when requests will be queued.\n","prefixes":["libcamera-devel","10/22"]}