{"id":14459,"url":"https://patchwork.libcamera.org/api/1.1/patches/14459/?format=json","web_url":"https://patchwork.libcamera.org/patch/14459/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211104135805.5269-3-david.plowman@raspberrypi.com>","date":"2021-11-04T13:58:00","name":"[libcamera-devel,v5,2/7] libcamera: Add ColorSpace fields to StreamConfiguration","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"721865036c40d698c5350fead92bdfdb95e63940","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14459/mbox/","series":[{"id":2691,"url":"https://patchwork.libcamera.org/api/1.1/series/2691/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2691","date":"2021-11-04T13:57:58","name":"Colour spaces","version":5,"mbox":"https://patchwork.libcamera.org/series/2691/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14459/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14459/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A001BDB1C\n\tfor ;\n\tThu, 4 Nov 2021 13:58:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBA8560362;\n\tThu, 4 Nov 2021 14:58:27 +0100 (CET)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68D3960344\n\tfor ;\n\tThu, 4 Nov 2021 14:58:24 +0100 (CET)","by mail-wm1-x334.google.com with SMTP id\n\tz11-20020a1c7e0b000000b0030db7b70b6bso7292594wmc.1\n\tfor ;\n\tThu, 04 Nov 2021 06:58:24 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\ti20sm2264736wmq.41.2021.11.04.06.58.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Nov 2021 06:58:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"l3E5JKlR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=nUVlWu72PlyE29kbK+yxhDq/7AfELhGkPOIcJt8NS14=;\n\tb=l3E5JKlRgqmxB4ItgFU3li7im056VsVT3kbyu/9+p0QSGqQG9GOc8nOWkAecZdO44O\n\tICdOBYaE5+KJVs4fqG0ha3nA6kLvEcvL3EpnomW0DTWsaRJxZ5bBUJUsIwsoZqMtEvfZ\n\tL9rKJ8NfRj0XLDpFeVh+dGfFo8dfURxIKrLps2PNvSercGA0HlCRHvduPm7E/OzP3Sgd\n\tbZCiDy4CsSoyKlz95j7jPF6kn/DqKjpaTyFZA99Fscbi0LixaKKy+q7G6Vtw9xKA9HdR\n\tKqDS/SiGMqFWgStIxQNcr7C8s0p8NchHAIa2elC2lbwAHypUJFUdGC2WoNAQpgKkjd0o\n\t2xZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=nUVlWu72PlyE29kbK+yxhDq/7AfELhGkPOIcJt8NS14=;\n\tb=UTzMRwBi8Q9YkYy7Q6BgMTEQYf91gwuyh3gOSPkYZKxyjlYZkCPyZzXr9ykWi6ozd/\n\tcovGBgHhi/XCq1Cx8aoW82pjyhFVKDlcYacpV53ijv7gCLCLnU7HTPxqmvICgqla8lgY\n\tEhOaowzHk3OwDJp/LRxBsvjJkp1rLDgS8iU2pWeBlGxSuLeqb/9fofpc1+fJ9/OvrGxS\n\tG8AKyNCMun+IrdjQc8b5waPl6/Zx7xMKWB01xnlInDA6VYE2wfS9i92Ksvlv2De24Yh5\n\t9qoU4FNa3SjHDyM9jINy+2BSA/228TuFx9+jjsj2mZP9iSdEjeSP34lFn7cfwbnGfAJm\n\t1nFQ==","X-Gm-Message-State":"AOAM5336WHbwF8qtpv4T7P9Z7xabJDBZNfQkGRRRRTYmbFSLPvZ/fKVj\n\tALSqAfreFKrO6KG4A/i6mGhUEGztZVTtrg==","X-Google-Smtp-Source":"ABdhPJz5RoVezjsWUIXmEDcTpdTef/8w8MgwspipUqka7F0LHX0EIgE2fqJ+bvCeF1jubHan9ad6EQ==","X-Received":"by 2002:a7b:cc8f:: with SMTP id\n\tp15mr20505767wma.158.1636034303888; \n\tThu, 04 Nov 2021 06:58:23 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 4 Nov 2021 13:58:00 +0000","Message-Id":"<20211104135805.5269-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20211104135805.5269-1-david.plowman@raspberrypi.com>","References":"<20211104135805.5269-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 2/7] libcamera: Add ColorSpace fields\n\tto StreamConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This is so that applications can choose appropriate color spaces which\nwill then be passed down to the V4L2 devices.\n\nThere are two fields: the \"requestedColorSpace\" which is the one an\napplication wants, and the \"actualColorSpace\" which is what the\nunderlying hardware can deliver, and which is filled in by the\nvalidate() method.\n\nSigned-off-by: David Plowman \n---\n include/libcamera/stream.h | 4 ++++\n src/libcamera/stream.cpp | 25 +++++++++++++++++++++++++\n 2 files changed, 29 insertions(+)","diff":"diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 0c55e716..fe491ff5 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -12,6 +12,7 @@\n #include \n #include \n \n+#include \n #include \n #include \n #include \n@@ -47,6 +48,9 @@ struct StreamConfiguration {\n \n \tunsigned int bufferCount;\n \n+\tColorSpace requestedColorSpace;\n+\tColorSpace actualColorSpace;\n+\n \tStream *stream() const { return stream_; }\n \tvoid setStream(Stream *stream) { stream_ = stream; }\n \tconst StreamFormats &formats() const { return formats_; }\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex b421e17e..1ddbbb8c 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -329,6 +329,31 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n * \\brief Requested number of buffers to allocate for the stream\n */\n \n+/**\n+ * \\var StreamConfiguration::requestedColorSpace\n+ * \\brief The ColorSpace this stream should have\n+ *\n+ * The generateConfiguration method will generate reasonable default\n+ * values (ColorSpace::Jpeg for stills, ColorSpace::Rec709 for video and\n+ * ColorSpace::Raw for raw streams) but applications are free to overwrite\n+ * this value.\n+ */\n+\n+/**\n+ * \\var StreamConfiguration::actualColorSpace\n+ * \\brief The ColorSpace the will be used for this stream\n+ *\n+ * This field is filled in by CameraConfiguration::validate().\n+ * Normally this should match the requestedColorSpace, but it may differ\n+ * if the hardware does not support it.\n+ *\n+ * In general cameras may have different constraints here, for example,\n+ * they may require all output streams to share the same color space.\n+ * Sometimes the fields within this color space may report \"Undefined\"\n+ * values if the hardware drivers are going to use a color space that\n+ * is not recognised by the ColorSpace class.\n+ */\n+\n /**\n * \\fn StreamConfiguration::stream()\n * \\brief Retrieve the stream associated with the configuration\n","prefixes":["libcamera-devel","v5","2/7"]}