{"id":14317,"url":"https://patchwork.libcamera.org/api/1.1/patches/14317/?format=json","web_url":"https://patchwork.libcamera.org/patch/14317/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211026095534.90348-7-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-26T09:55:21","name":"[libcamera-devel,v4,06/19] ipa: ipu3: awb: Reword accumulator documentation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"af6f4544939903f59526a0faa326c6c0920b01e9","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14317/mbox/","series":[{"id":2656,"url":"https://patchwork.libcamera.org/api/1.1/series/2656/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2656","date":"2021-10-26T09:55:15","name":"Document IPU3 IPA","version":4,"mbox":"https://patchwork.libcamera.org/series/2656/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14317/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14317/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1E45BDB1C\n\tfor ;\n\tTue, 26 Oct 2021 09:55:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1911C64889;\n\tTue, 26 Oct 2021 11:55:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A675C6487B\n\tfor ;\n\tTue, 26 Oct 2021 11:55:45 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E638DBF;\n\tTue, 26 Oct 2021 11:55:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"neTvf+Ac\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635242145;\n\tbh=Pcp9Mc6UW2yRJj7DFkomENi5B1HeAE+xxza0qDQCuxE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=neTvf+AcCcQ7sPMVZ6Z6b+h9f6jyzyvhhmX5Fr1VihwikjsaPoJZtzPvYAebH2iCf\n\t1nFqD0nL7wzv/MpG10iHPAdYMijdgk8wr3Z0yO3j5/eGJih2WpOy846W1Pw6P9k2ng\n\tnagQaZTw+a/HItsxmGIUC0mDBXThBDJQGtUUz57Q=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Oct 2021 11:55:21 +0200","Message-Id":"<20211026095534.90348-7-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211026095534.90348-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 06/19] ipa: ipu3: awb: Reword\n\taccumulator documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that we moved the diagram into the AWB class documentation, reword the\naccumulator documentation to make it clear it is not meant to be used\nonly in AWB.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/awb.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 8d22aceb..41fd5fc4 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -46,12 +46,12 @@ static constexpr uint32_t kMinCellsPerZoneRatio = 255 * 90 / 100;\n * \\struct Accumulator\n * \\brief RGB statistics for a given zone\n *\n- * The Accumulator structure stores the sum of the average of each cell in a\n- * zone of the image, as well as the number of cells which were unsaturated and\n- * therefore included in the average.\n+ * Accumulate red, green and blue values for each non-saturated item over a\n+ * zone. Items can for instance be pixels, but also the average of groups of\n+ * pixels, depending on who uses the accumulator.\n * \\todo move this description and structure into a common header\n *\n- * Cells which are saturated beyond the threshold defined in\n+ * Zones which are saturated beyond the threshold defined in\n * ipu3_uapi_awb_config_s are not included in the average.\n *\n * \\var Accumulator::counted\n","prefixes":["libcamera-devel","v4","06/19"]}