{"id":14304,"url":"https://patchwork.libcamera.org/api/1.1/patches/14304/?format=json","web_url":"https://patchwork.libcamera.org/patch/14304/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211026072148.164831-3-umang.jain@ideasonboard.com>","date":"2021-10-26T07:21:43","name":"[libcamera-devel,v8,2/7] android: post_processor_jpeg: Replace encoder_ nullptr check","commit_ref":"ed9eb080e9d723292596ee4d335e101b0ae75278","pull_url":null,"state":"accepted","archived":false,"hash":"9fe151849cb61b92eb44cbfe26e68309ec244e68","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14304/mbox/","series":[{"id":2654,"url":"https://patchwork.libcamera.org/api/1.1/series/2654/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2654","date":"2021-10-26T07:21:41","name":"Async Post Processor","version":8,"mbox":"https://patchwork.libcamera.org/series/2654/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14304/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14304/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27078BF415\n\tfor ;\n\tTue, 26 Oct 2021 07:22:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE45564874;\n\tTue, 26 Oct 2021 09:22:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 852796487B\n\tfor ;\n\tTue, 26 Oct 2021 09:22:00 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 330123F0;\n\tTue, 26 Oct 2021 09:21:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OtraZ0j5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635232920;\n\tbh=B9+YjgtLiWLIJqVqRmov1SYv0g0IK79oU0QLperGiWw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OtraZ0j5omYkFpoLw/CdVdHGRCA5k+Si2wiPe+sC/RPwXRXsmPKezJ4+OyIp6b4iK\n\tFSbTe+T+evWVgqMhLYaRHSoU0rdXINvm8H80lWrP0aU7IZrmWkd+2kFoUcJPv0/GlM\n\tqNbu5G8JS/SSH5wKsrwZfpmqbfyyVS5aLZqrJ1FU=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Oct 2021 12:51:43 +0530","Message-Id":"<20211026072148.164831-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211026072148.164831-1-umang.jain@ideasonboard.com>","References":"<20211026072148.164831-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 2/7] android: post_processor_jpeg:\n\tReplace encoder_ nullptr check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of simply returning if encoder_ is nullptr, fail hard\nvia an assertion. It is quite unlikely that encoder_ could only\nbe null as a result of a fatal bug in the code, so be loud about\nthe failure.\n\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \nReviewed-by: Hirokazu Honda \nReviewed-by: Kieran Bingham \n---\n src/android/jpeg/post_processor_jpeg.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 699576ef..49483836 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -102,9 +102,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n \t\t\t CameraBuffer *destination,\n \t\t\t Camera3RequestDescriptor *request)\n {\n-\tif (!encoder_)\n-\t\treturn 0;\n-\n+\tASSERT(encoder_);\n \tASSERT(destination->numPlanes() == 1);\n \n \tconst CameraMetadata &requestMetadata = request->settings_;\n","prefixes":["libcamera-devel","v8","2/7"]}