{"id":14303,"url":"https://patchwork.libcamera.org/api/1.1/patches/14303/?format=json","web_url":"https://patchwork.libcamera.org/patch/14303/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211026072148.164831-2-umang.jain@ideasonboard.com>","date":"2021-10-26T07:21:42","name":"[libcamera-devel,v8,1/7] android: camera_stream: Replace post-processor nullptr check","commit_ref":"d559905c5f4e844c742aaf31c56883e60f15699a","pull_url":null,"state":"accepted","archived":false,"hash":"6115da5402a5fce179ff181ce96ace089506fa0f","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14303/mbox/","series":[{"id":2654,"url":"https://patchwork.libcamera.org/api/1.1/series/2654/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2654","date":"2021-10-26T07:21:41","name":"Async Post Processor","version":8,"mbox":"https://patchwork.libcamera.org/series/2654/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14303/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14303/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68C45BF415\n\tfor ;\n\tTue, 26 Oct 2021 07:22:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A65D64878;\n\tTue, 26 Oct 2021 09:22:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63A8C60123\n\tfor ;\n\tTue, 26 Oct 2021 09:21:58 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EBDAA3F0;\n\tTue, 26 Oct 2021 09:21:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sYwbduH8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635232918;\n\tbh=Rfs5vxK5XN2WVTefTRqQ59wwjvesdClvoK29ikEUPZ4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sYwbduH86ktsnckH5N94oK6eY0dOEflCBbProh6RTlBI0ZH2eLPAkN5mk1WpV4c7B\n\tVOw4FoJCzXdV/SyKO6AeKb5g/ZsP7FpXOIsFgGKX9Dx6iOuQFoGzHiA2LWnvNUTg9L\n\tyKWsO3WhenqnthpLg4W+4qWA6lJZcT20h6Fqs9ho=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Oct 2021 12:51:42 +0530","Message-Id":"<20211026072148.164831-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211026072148.164831-1-umang.jain@ideasonboard.com>","References":"<20211026072148.164831-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 1/7] android: camera_stream: Replace\n\tpost-processor nullptr check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of checking postProcessor for nullptr, replace this\ncheck with an assertion that checks if the camera stream's\ntype is not Type::Direct. Since it makes no sense to call\nCameraStream::process() on a Type::Direct camera stream.\n\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \nReviewed-by: Hirokazu Honda \nReviewed-by: Kieran Bingham \n---\n src/android/camera_stream.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex f44a2717..5d991fe5 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -150,6 +150,8 @@ int CameraStream::process(const FrameBuffer &source,\n \t\t\t Camera3RequestDescriptor::StreamBuffer &dest,\n \t\t\t Camera3RequestDescriptor *request)\n {\n+\tASSERT(type_ != Type::Direct);\n+\n \t/* Handle waiting on fences on the destination buffer. */\n \tif (dest.fence != -1) {\n \t\tint ret = waitFence(dest.fence);\n@@ -163,9 +165,6 @@ int CameraStream::process(const FrameBuffer &source,\n \t\tdest.fence = -1;\n \t}\n \n-\tif (!postProcessor_)\n-\t\treturn 0;\n-\n \t/*\n \t * \\todo Buffer mapping and processing should be moved to a\n \t * separate thread.\n","prefixes":["libcamera-devel","v8","1/7"]}