{"id":14296,"url":"https://patchwork.libcamera.org/api/1.1/patches/14296/?format=json","web_url":"https://patchwork.libcamera.org/patch/14296/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211025203833.122460-3-umang.jain@ideasonboard.com>","date":"2021-10-25T20:38:28","name":"[libcamera-devel,v7,2/7] android: post_processor_jpeg: Replace encoder_ nullptr check","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9fe151849cb61b92eb44cbfe26e68309ec244e68","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/14296/mbox/","series":[{"id":2653,"url":"https://patchwork.libcamera.org/api/1.1/series/2653/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2653","date":"2021-10-25T20:38:26","name":"Async Post Processor","version":7,"mbox":"https://patchwork.libcamera.org/series/2653/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14296/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14296/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E306BF415\n\tfor ;\n\tMon, 25 Oct 2021 20:38:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6147D6486E;\n\tMon, 25 Oct 2021 22:38:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8BFF60125\n\tfor ;\n\tMon, 25 Oct 2021 22:38:46 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34664E0A;\n\tMon, 25 Oct 2021 22:38:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"neXbSFkZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635194326;\n\tbh=B9+YjgtLiWLIJqVqRmov1SYv0g0IK79oU0QLperGiWw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=neXbSFkZEGGmu9q6Wsl5POguWhUjYTFqGcmxqswz3c/RhAdMZJDC1DbNBXfJj0Fir\n\tGH4ZTjXc8hZ/+6AkQrsZjlnwF0Usn4q27MuIXlwy8HdhSWBb6rXti/YFIMe2UGonLs\n\tO2h2YWabY0jEs7FMLruzBHxEqY6Fn8it7bFYimh4=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Oct 2021 02:08:28 +0530","Message-Id":"<20211025203833.122460-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211025203833.122460-1-umang.jain@ideasonboard.com>","References":"<20211025203833.122460-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 2/7] android: post_processor_jpeg:\n\tReplace encoder_ nullptr check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of simply returning if encoder_ is nullptr, fail hard\nvia an assertion. It is quite unlikely that encoder_ could only\nbe null as a result of a fatal bug in the code, so be loud about\nthe failure.\n\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \nReviewed-by: Hirokazu Honda \nReviewed-by: Kieran Bingham \n---\n src/android/jpeg/post_processor_jpeg.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 699576ef..49483836 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -102,9 +102,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n \t\t\t CameraBuffer *destination,\n \t\t\t Camera3RequestDescriptor *request)\n {\n-\tif (!encoder_)\n-\t\treturn 0;\n-\n+\tASSERT(encoder_);\n \tASSERT(destination->numPlanes() == 1);\n \n \tconst CameraMetadata &requestMetadata = request->settings_;\n","prefixes":["libcamera-devel","v7","2/7"]}