{"id":14287,"url":"https://patchwork.libcamera.org/api/1.1/patches/14287/?format=json","web_url":"https://patchwork.libcamera.org/patch/14287/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211023103302.152769-2-umang.jain@ideasonboard.com>","date":"2021-10-23T10:32:56","name":"[libcamera-devel,v6,1/7] android: camera_stream: Replace post-processor nullptr check","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4d26910af1d5bf06efd2f95fdf0c1c85c2ef6ec8","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14287/mbox/","series":[{"id":2652,"url":"https://patchwork.libcamera.org/api/1.1/series/2652/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2652","date":"2021-10-23T10:32:55","name":"Async Post Processor","version":6,"mbox":"https://patchwork.libcamera.org/series/2652/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14287/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14287/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B81F5BDB1C\n\tfor ;\n\tSat, 23 Oct 2021 10:33:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F22164875;\n\tSat, 23 Oct 2021 12:33:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C44364872\n\tfor ;\n\tSat, 23 Oct 2021 12:33:12 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.213])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30326547;\n\tSat, 23 Oct 2021 12:33:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d1jheNU4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634985191;\n\tbh=AlJReVeln4u9zXt1oUQuYkFTPfsRC8SFWObfcKIUMzE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=d1jheNU4xt7Llm1yoqxeaUbnHw1T7z2v0E/QS3gwJQE67QxltVy8pQF8cF7ToVWV7\n\t1+5mJ6djOhUQOSiQkwwZQq+iYHHDzIrUt5ozhj6Ew/73u7UK7wFsObyJs+U1/pD5SE\n\tl0fubRAvJFA4Sg6DKWRfN5Cuh2V9RHsqXmht1c8Y=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 23 Oct 2021 16:02:56 +0530","Message-Id":"<20211023103302.152769-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211023103302.152769-1-umang.jain@ideasonboard.com>","References":"<20211023103302.152769-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 1/7] android: camera_stream: Replace\n\tpost-processor nullptr check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of checking postProcessor for nullptr, replace this\ncheck with an assertion that checks if the camera stream's\ntype is not Type::Direct. Since it makes no sense to call\nCameraStream::process() on a Type::Direct camera stream.\n\nSigned-off-by: Umang Jain \n---\n src/android/camera_stream.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex f44a2717..ca25c4db 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -163,8 +163,7 @@ int CameraStream::process(const FrameBuffer &source,\n \t\tdest.fence = -1;\n \t}\n \n-\tif (!postProcessor_)\n-\t\treturn 0;\n+\tASSERT(type_ != Type::Direct);\n \n \t/*\n \t * \\todo Buffer mapping and processing should be moved to a\n","prefixes":["libcamera-devel","v6","1/7"]}