{"id":14275,"url":"https://patchwork.libcamera.org/api/1.1/patches/14275/?format=json","web_url":"https://patchwork.libcamera.org/patch/14275/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211022151218.111966-10-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-22T15:12:08","name":"[libcamera-devel,v3,09/19] ipa: ipu3: tonemapping: Implement configure call","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"6e88f4336f3af934071270e31212f3a4fc4526ea","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14275/mbox/","series":[{"id":2651,"url":"https://patchwork.libcamera.org/api/1.1/series/2651/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2651","date":"2021-10-22T15:11:59","name":"Document IPU3 IPA","version":3,"mbox":"https://patchwork.libcamera.org/series/2651/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14275/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14275/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1412BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Oct 2021 15:12:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72F1A68F6C;\n\tFri, 22 Oct 2021 17:12:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70D526023B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Oct 2021 17:12:24 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BECF51D;\n\tFri, 22 Oct 2021 17:12:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UNLnSBW8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634915544;\n\tbh=hh5m+fVCfWi2XclgjLkelSpKxXS13+1YFUvfn/9E26U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UNLnSBW89wcrOgkRehnKDxaWKZr4FitsfEkz2qEK0mfoY+LZrj5oTiAMJtiifGtsP\n\tj3Blybd6OZ4ohB1Ufsfa5YFaLero1Pv4mLvXEpDBhBKdc1mQUNrXj6oU4/VBDySl94\n\tN6sEBkPCPiB4zJ65H9MIGIHCp8XT3Vit22Vhl/j8=","From":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Oct 2021 17:12:08 +0200","Message-Id":"<20211022151218.111966-10-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 09/19] ipa: ipu3: tonemapping:\n\tImplement configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Let the algorithm perform its initial configuration. Implement\nconfigure() to set a default gamma value and let process do the updates\nneeded.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/tone_mapping.cpp | 16 ++++++++++++++++\n src/ipa/ipu3/algorithms/tone_mapping.h   |  1 +\n 2 files changed, 17 insertions(+)","diff":"diff --git a/src/ipa/ipu3/algorithms/tone_mapping.cpp b/src/ipa/ipu3/algorithms/tone_mapping.cpp\nindex 40337f9d..8fa8c7e9 100644\n--- a/src/ipa/ipu3/algorithms/tone_mapping.cpp\n+++ b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n@@ -19,6 +19,22 @@ ToneMapping::ToneMapping()\n {\n }\n \n+/**\n+ * \\brief Configure the tone mapping given a configInfo\n+ * \\param[in] context The shared IPA context\n+ * \\param[in] configInfo The IPA configuration data\n+ *\n+ * \\return 0\n+ */\n+int ToneMapping::configure(IPAContext &context,\n+\t\t\t   [[maybe_unused]] const IPAConfigInfo &configInfo)\n+{\n+\t/* Initialise tone mapping gamma value */\n+\tcontext.frameContext.toneMapping.gamma = 0.0;\n+\n+\treturn 0;\n+}\n+\n void ToneMapping::prepare([[maybe_unused]] IPAContext &context,\n \t\t\t  ipu3_uapi_params *params)\n {\ndiff --git a/src/ipa/ipu3/algorithms/tone_mapping.h b/src/ipa/ipu3/algorithms/tone_mapping.h\nindex 1dae4f9a..46dd6171 100644\n--- a/src/ipa/ipu3/algorithms/tone_mapping.h\n+++ b/src/ipa/ipu3/algorithms/tone_mapping.h\n@@ -18,6 +18,7 @@ class ToneMapping : public Algorithm\n public:\n \tToneMapping();\n \n+\tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n \tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n \n","prefixes":["libcamera-devel","v3","09/19"]}