{"id":14268,"url":"https://patchwork.libcamera.org/api/1.1/patches/14268/?format=json","web_url":"https://patchwork.libcamera.org/patch/14268/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211022151218.111966-3-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-22T15:12:01","name":"[libcamera-devel,v3,02/19] ipa: ipu3: Document IPAIPU3::configure","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"aa9264a0f15b5000c514d66f758cadc703dd5211","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14268/mbox/","series":[{"id":2651,"url":"https://patchwork.libcamera.org/api/1.1/series/2651/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2651","date":"2021-10-22T15:11:59","name":"Document IPU3 IPA","version":3,"mbox":"https://patchwork.libcamera.org/series/2651/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14268/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14268/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7043BBF415\n\tfor ;\n\tFri, 22 Oct 2021 15:12:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78DDC68F77;\n\tFri, 22 Oct 2021 17:12:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 333EC68F57\n\tfor ;\n\tFri, 22 Oct 2021 17:12:23 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D41BC1908;\n\tFri, 22 Oct 2021 17:12:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IFsCcNFF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634915542;\n\tbh=N6qigq+iU2JVYxZawHu7GOPQ2ZgvL2CmqVjaBOZPqQY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IFsCcNFF89r2qPMe2zZ4+/MPy74dZtOpeXCjmYfSONCidj279R3Fsnsh6yS4v9kyA\n\tyekX1y0v/pEYuXA5y5DAPmScyi3vNXxNKaQSakeOOwpuTx/5fPjVhgD+0uxIUmf+Ci\n\tG9kaTO/+B21GZMtVdE6yYa9DcHm0IpyVaDhtXYQ4=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Oct 2021 17:12:01 +0200","Message-Id":"<20211022151218.111966-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 02/19] ipa: ipu3: Document\n\tIPAIPU3::configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Further extend the documentation for the IPAIPU3::configure operation.\n\nSigned-off-by: Jean-Michel Hautbois \nSigned-off-by: Kieran Bingham \n---\n src/ipa/ipu3/ipu3.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b5438ed1..6e28a5aa 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -502,6 +502,21 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n \t\t\t << (int)bdsGrid.height << \" << \" << (int)bdsGrid.block_height_log2 << \")\";\n }\n \n+/**\n+ * \\brief Configure the IPU3 IPA\n+ * \\param[in] configInfo The IPA configuration data, received from the pipeline\n+ * handler\n+ * \\param[in] ipaControls The IPA controls to update\n+ *\n+ * Calculate the best grid for the statistics based on the Pipeline Handler BDS\n+ * output, and parse the minimum and maximum exposure and analogue gain control\n+ * values.\n+ *\n+ * \\todo Document what the BDS is, ideally in a block diagram of the ImgU.\n+ *\n+ * All algorithm modules are called to allow them to prepare the\n+ * \\a IPASessionConfiguration structure for the \\a IPAContext.\n+ */\n int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \t\t ControlInfoMap *ipaControls)\n {\n","prefixes":["libcamera-devel","v3","02/19"]}