{"id":14240,"url":"https://patchwork.libcamera.org/api/1.1/patches/14240/?format=json","web_url":"https://patchwork.libcamera.org/patch/14240/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211022073249.35084-5-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-22T07:32:39","name":"[libcamera-devel,v4,04/14] ipa: ipu3: awb: Change minimal green threshold value","commit_ref":"fac6734a4f1de85a58963d984300f45143508b3a","pull_url":null,"state":"accepted","archived":false,"hash":"ca25213f0e62be1cee92e26fcb343a2b98582774","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14240/mbox/","series":[{"id":2647,"url":"https://patchwork.libcamera.org/api/1.1/series/2647/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2647","date":"2021-10-22T07:32:35","name":"ipa: ipu3: Fix AGC bugs","version":4,"mbox":"https://patchwork.libcamera.org/series/2647/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14240/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14240/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDC2CC324E\n\tfor ;\n\tFri, 22 Oct 2021 07:33:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88F3868F70;\n\tFri, 22 Oct 2021 09:33:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3F8968F5B\n\tfor ;\n\tFri, 22 Oct 2021 09:32:54 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 970EC89A;\n\tFri, 22 Oct 2021 09:32:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qrtTONJy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634887974;\n\tbh=lNJYWZ32b26zSrgbjCIddUZ/9wlJ8wdRHrYYB6zdqRc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qrtTONJy+fGsNCHto9OSeY7pcL9j0Zyjr7IGqMer+AhQxBLws+/eD655comV4D3i7\n\tFDKxB789mckvr0SzXXIcZaJBkEli86Pm84k17Ty9iseF4mHpfTgEnM6vHYar7XvD7b\n\t9AudOAo8lqDhkkhWzgm7I6i4cY2KRLisM+kS6ry8=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Oct 2021 09:32:39 +0200","Message-Id":"<20211022073249.35084-5-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 04/14] ipa: ipu3: awb: Change minimal\n\tgreen threshold value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When zones are used for the grey world algorithm, they are only\nconsidered if their average green value is at least 32/255 to exclude\nzones that are too dark and don't provide relevant colour information\n(on the opposite side of the spectrum, saturated regions are excluded by\nthe ImgU statistics engine).\n\nThe algorithm requires a minimal number of zones that meet this criteria\nin order to run. Now that we correct the black level, the 32/255 minimal\nvalue is a bit high and prevents the algorithm for running in low-light\nconditions. Lower the value to 16/255 to fix it.\n\nSigned-off-by: Jean-Michel Hautbois \nAcked-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/awb.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex c5976c6f..91364a04 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -17,7 +17,14 @@ namespace ipa::ipu3::algorithms {\n \n LOG_DEFINE_CATEGORY(IPU3Awb)\n \n-static constexpr uint32_t kMinGreenLevelInZone = 32;\n+/*\n+ * When zones are used for the grey world algorithm, they are only considered if\n+ * their average green value is at least 16/255 (after black level subtraction)\n+ * to exclude zones that are too dark and don't provide relevant colour\n+ * information (on the opposite side of the spectrum, saturated regions are\n+ * excluded by the ImgU statistics engine).\n+ */\n+static constexpr uint32_t kMinGreenLevelInZone = 16;\n \n /*\n * Minimum proportion of non-saturated cells in a zone for the zone to be used\n","prefixes":["libcamera-devel","v4","04/14"]}