{"id":14228,"url":"https://patchwork.libcamera.org/api/1.1/patches/14228/?format=json","web_url":"https://patchwork.libcamera.org/patch/14228/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211021164401.110033-9-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-21T16:43:55","name":"[libcamera-devel,v3,08/14] ipa: ipu3: agc: Use filtered exposure values","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"57f193f81c8eb4f93e96c5a15ea9ec1b3b6325fc","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14228/mbox/","series":[{"id":2646,"url":"https://patchwork.libcamera.org/api/1.1/series/2646/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2646","date":"2021-10-21T16:43:47","name":"ipa: ipu3: Fix AGC bugs","version":3,"mbox":"https://patchwork.libcamera.org/series/2646/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14228/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14228/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E55A6BF415\n\tfor ;\n\tThu, 21 Oct 2021 16:44:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 644FB68F6C;\n\tThu, 21 Oct 2021 18:44:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 252F168F56\n\tfor ;\n\tThu, 21 Oct 2021 18:44:07 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:f9d:5926:ad90:4996])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B885A276;\n\tThu, 21 Oct 2021 18:44:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F4E3Vf9+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634834646;\n\tbh=srdGptDZrbVSL5ezYI4sZ6vqkkOPFTP2tJfeJYCoLEA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=F4E3Vf9+b05uA+zAYNnJYuhKRnAqcHOqdNcfKgMQjkGwXY2nm9UseulLCIQAI//jP\n\tvXHFEYvSac/eSM1GQOn5XRhKeYK62JansC194h6lNC3gWBEMWPmr2zizXLw0panpV6\n\tU7/+oBiXd4PIys7GFPo70Ev2eyAK1wvqyy1N+xEU=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 21 Oct 2021 18:43:55 +0200","Message-Id":"<20211021164401.110033-9-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 08/14] ipa: ipu3: agc: Use filtered\n\texposure values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We are filtering the exposure value to limit the gain to apply, but we\nare not using the result.\n\nFix it.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/agc.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 984aed53..f5bb3328 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -158,17 +158,17 @@ void Agc::lockExposureGain(uint32_t &exposure, double &gain)\n \n \t\tutils::Duration newExposure = 0.0s;\n \t\tif (currentShutter < maxShutterSpeed) {\n-\t\t\texposure = std::clamp(exposure * currentExposure_ / currentExposureNoDg_,\n+\t\t\texposure = std::clamp(exposure * filteredExposure_ / currentExposureNoDg_,\n \t\t\t\t\t\t\tminExposureLines_,\n \t\t\t\t\t\t\tmaxExposureLines_);\n-\t\t\tnewExposure = currentExposure_ / exposure;\n-\t\t\tgain = std::clamp(gain * currentExposure_ / newExposure,\n+\t\t\tnewExposure = filteredExposure_ / exposure;\n+\t\t\tgain = std::clamp(gain * filteredExposure_ / newExposure,\n \t\t\t\t\t kMinGain, kMaxGain);\n \t\t} else {\n-\t\t\tgain = std::clamp(gain * currentExposure_ / currentExposureNoDg_,\n+\t\t\tgain = std::clamp(gain * filteredExposure_ / currentExposureNoDg_,\n \t\t\t\t\t kMinGain, kMaxGain);\n-\t\t\tnewExposure = currentExposure_ / gain;\n-\t\t\texposure = std::clamp(exposure * currentExposure_ / newExposure,\n+\t\t\tnewExposure = filteredExposure_ / gain;\n+\t\t\texposure = std::clamp(exposure * filteredExposure_ / newExposure,\n \t\t\t\t\t\t\tminExposureLines_,\n \t\t\t\t\t\t\tmaxExposureLines_);\n \t\t}\n","prefixes":["libcamera-devel","v3","08/14"]}