{"id":14226,"url":"https://patchwork.libcamera.org/api/1.1/patches/14226/?format=json","web_url":"https://patchwork.libcamera.org/patch/14226/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211021164401.110033-6-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-21T16:43:52","name":"[libcamera-devel,v3,05/14] ipa: ipu3: agc: Rename exposure values properly","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c72fc06640b653091f141f06a68fae644a728957","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14226/mbox/","series":[{"id":2646,"url":"https://patchwork.libcamera.org/api/1.1/series/2646/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2646","date":"2021-10-21T16:43:47","name":"ipa: ipu3: Fix AGC bugs","version":3,"mbox":"https://patchwork.libcamera.org/series/2646/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14226/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14226/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D755C324E\n\tfor ;\n\tThu, 21 Oct 2021 16:44:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4DB368F61;\n\tThu, 21 Oct 2021 18:44:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BCB168F5C\n\tfor ;\n\tThu, 21 Oct 2021 18:44:06 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:f9d:5926:ad90:4996])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F4BE1BF9;\n\tThu, 21 Oct 2021 18:44:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hgvib1VG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634834646;\n\tbh=l+Mz/wHRifSiN6OzVUIf7GYOxdpXJIVhxxPXpPt0Sko=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Hgvib1VGHk1qWMUdW0V+Ct2Yc4Y8bx9IYRp2o5cw9EXD79Ky5/YKULjdfhCbNuV4n\n\t+LBT5XYhAneC1+ch4tGqpIlcrAXcawDcwnTIFNCBvZky7BLcuP/1yAOmmKs9lIsPEX\n\toBkX7asI1n05ehUkAcpDIEaLS8B/4YjjzvhmFe9M=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 21 Oct 2021 18:43:52 +0200","Message-Id":"<20211021164401.110033-6-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 05/14] ipa: ipu3: agc: Rename exposure\n\tvalues properly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The exposure value is filtered in filterExposure() using the\ncurrentExposure_ and setting a prevExposure_ variable. This is misnamed\nas it is not the previous exposure, but a filtered value.\n\nRename it accordingly.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/agc.cpp | 28 ++++++++++++++--------------\n src/ipa/ipu3/algorithms/agc.h | 4 ++--\n 2 files changed, 16 insertions(+), 16 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 828e822c..62ea0916 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -49,7 +49,7 @@ static constexpr double kEvGainTarget = 0.5;\n \n Agc::Agc()\n \t: frameCount_(0), lastFrame_(0), iqMean_(0.0), lineDuration_(0s),\n-\t maxExposureTime_(0s), prevExposure_(0s), prevExposureNoDg_(0s),\n+\t maxExposureTime_(0s), filteredExposure_(0s), filteredExposureNoDg_(0s),\n \t currentExposure_(0s), currentExposureNoDg_(0s)\n {\n }\n@@ -100,24 +100,24 @@ void Agc::processBrightness(const ipu3_uapi_stats_3a *stats,\n void Agc::filterExposure()\n {\n \tdouble speed = 0.2;\n-\tif (prevExposure_ == 0s) {\n+\tif (filteredExposure_ == 0s) {\n \t\t/* DG stands for digital gain.*/\n-\t\tprevExposure_ = currentExposure_;\n-\t\tprevExposureNoDg_ = currentExposureNoDg_;\n+\t\tfilteredExposure_ = currentExposure_;\n+\t\tfilteredExposureNoDg_ = currentExposureNoDg_;\n \t} else {\n \t\t/*\n \t\t * If we are close to the desired result, go faster to avoid making\n \t\t * multiple micro-adjustments.\n \t\t * \\ todo: Make this customisable?\n \t\t */\n-\t\tif (prevExposure_ < 1.2 * currentExposure_ &&\n-\t\t prevExposure_ > 0.8 * currentExposure_)\n+\t\tif (filteredExposure_ < 1.2 * currentExposure_ &&\n+\t\t filteredExposure_ > 0.8 * currentExposure_)\n \t\t\tspeed = sqrt(speed);\n \n-\t\tprevExposure_ = speed * currentExposure_ +\n-\t\t\t\tprevExposure_ * (1.0 - speed);\n-\t\tprevExposureNoDg_ = speed * currentExposureNoDg_ +\n-\t\t\t\tprevExposureNoDg_ * (1.0 - speed);\n+\t\tfilteredExposure_ = speed * currentExposure_ +\n+\t\t\t\tfilteredExposure_ * (1.0 - speed);\n+\t\tfilteredExposureNoDg_ = speed * currentExposureNoDg_ +\n+\t\t\t\tfilteredExposureNoDg_ * (1.0 - speed);\n \t}\n \t/*\n \t * We can't let the no_dg exposure deviate too far below the\n@@ -125,10 +125,10 @@ void Agc::filterExposure()\n \t * in the ISP to hide it (which will cause nasty oscillation).\n \t */\n \tdouble fastReduceThreshold = 0.4;\n-\tif (prevExposureNoDg_ <\n-\t prevExposure_ * fastReduceThreshold)\n-\t\tprevExposureNoDg_ = prevExposure_ * fastReduceThreshold;\n-\tLOG(IPU3Agc, Debug) << \"After filtering, total_exposure \" << prevExposure_;\n+\tif (filteredExposureNoDg_ <\n+\t filteredExposure_ * fastReduceThreshold)\n+\t\tfilteredExposureNoDg_ = filteredExposure_ * fastReduceThreshold;\n+\tLOG(IPU3Agc, Debug) << \"After filtering, total_exposure \" << filteredExposure_;\n }\n \n void Agc::lockExposureGain(uint32_t &exposure, double &gain)\ndiff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\nindex e0c315fc..16b9fa0a 100644\n--- a/src/ipa/ipu3/algorithms/agc.h\n+++ b/src/ipa/ipu3/algorithms/agc.h\n@@ -44,8 +44,8 @@ private:\n \tutils::Duration lineDuration_;\n \tutils::Duration maxExposureTime_;\n \n-\tutils::Duration prevExposure_;\n-\tutils::Duration prevExposureNoDg_;\n+\tutils::Duration filteredExposure_;\n+\tutils::Duration filteredExposureNoDg_;\n \tutils::Duration currentExposure_;\n \tutils::Duration currentExposureNoDg_;\n \n","prefixes":["libcamera-devel","v3","05/14"]}