{"id":14205,"url":"https://patchwork.libcamera.org/api/1.1/patches/14205/?format=json","web_url":"https://patchwork.libcamera.org/patch/14205/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211020133353.2500082-2-kieran.bingham@ideasonboard.com>","date":"2021-10-20T13:33:52","name":"[libcamera-devel,v3,1/2] libcamera: camera: Create a CameraControlValidator","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"071b506689433371916a927e0088a41a20d53a19","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14205/mbox/","series":[{"id":2644,"url":"https://patchwork.libcamera.org/api/1.1/series/2644/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2644","date":"2021-10-20T13:33:51","name":"Camera Control Validator","version":3,"mbox":"https://patchwork.libcamera.org/series/2644/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14205/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14205/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7235BF415\n\tfor ;\n\tWed, 20 Oct 2021 13:34:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 425DC68F5F;\n\tWed, 20 Oct 2021 15:33:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A84868F57\n\tfor ;\n\tWed, 20 Oct 2021 15:33:57 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC8411447;\n\tWed, 20 Oct 2021 15:33:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h/omDgpB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634736837;\n\tbh=LRAvSNlbg6A/stOLEj+gCHTAMplXR0z/b7rJi2udFVM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=h/omDgpBb4uD7Xz1uG4lJd6UjA3IMtwnKQpscZhnbpIE5UaS2p2Rv/N+0iTjUbx5O\n\tRD4yPAQWa5xSsJCbIPiLOkFnB6SngrTxgwQu7VADrgG5xpMmR42Qu7JWlkvlx6Tlgz\n\tWa+Q8EKJXJUUpy4LmI/O9xp4qAuTeDyEgE6Y1EwM=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 20 Oct 2021 14:33:52 +0100","Message-Id":"<20211020133353.2500082-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20211020133353.2500082-1-kieran.bingham@ideasonboard.com>","References":"<20211020133353.2500082-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/2] libcamera: camera: Create a\n\tCameraControlValidator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Create a Camera specific CameraControlValidator for the Camera instance.\nThis will allow requests to use a single validor instance without having\nto construct their own.\n\nSigned-off-by: Kieran Bingham \n\n---\nv3:\n - Use a unique_ptr instead of deriving from the _o/O_PTRs\n\nv2:\n - Use LIBCAMERA_O_PTR() instead of _o()\n---\n include/libcamera/internal/camera.h | 6 ++++++\n src/libcamera/camera.cpp | 7 +++++++\n 2 files changed, 13 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 1a08da0cedc4..f0baaea07bdc 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -17,6 +17,8 @@\n \n #include \n \n+#include \"libcamera/internal/camera_controls.h\"\n+\n namespace libcamera {\n \n class PipelineHandler;\n@@ -38,6 +40,8 @@ public:\n \n \tuint32_t requestSequence_;\n \n+\tconst CameraControlValidator *validator() const { return validator_.get(); }\n+\n private:\n \tenum State {\n \t\tCameraAvailable,\n@@ -64,6 +68,8 @@ private:\n \n \tbool disconnected_;\n \tstd::atomic state_;\n+\n+\tstd::unique_ptr validator_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 71809bcd36a3..f84cdc522d0d 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -366,6 +366,12 @@ Camera::Private::~Private()\n * \\return The pipeline handler that created this camera\n */\n \n+/**\n+ * \\fn Camera::Private::validator()\n+ * \\brief Retrieve the control validator related to this camera\n+ * \\return The control validator associated with this camera\n+ */\n+\n /**\n * \\var Camera::Private::queuedRequests_\n * \\brief The list of queued and not yet completed requests\n@@ -665,6 +671,7 @@ Camera::Camera(std::unique_ptr d, const std::string &id,\n {\n \t_d()->id_ = id;\n \t_d()->streams_ = streams;\n+\t_d()->validator_ = std::make_unique(this);\n }\n \n Camera::~Camera()\n","prefixes":["libcamera-devel","v3","1/2"]}