{"id":14168,"url":"https://patchwork.libcamera.org/api/1.1/patches/14168/?format=json","web_url":"https://patchwork.libcamera.org/patch/14168/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211018132923.476242-8-umang.jain@ideasonboard.com>","date":"2021-10-18T13:29:19","name":"[libcamera-devel,07/11] android: camera_stream: Return non-const pointer from camera3Stream()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0200e72e6386c2a7e84491248b6329cc548c65e1","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/14168/mbox/","series":[{"id":2636,"url":"https://patchwork.libcamera.org/api/1.1/series/2636/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2636","date":"2021-10-18T13:29:12","name":"android: Overhaul request handling","version":1,"mbox":"https://patchwork.libcamera.org/series/2636/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14168/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14168/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1DA18C323E\n\tfor ;\n\tMon, 18 Oct 2021 13:29:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAD2C68F65;\n\tMon, 18 Oct 2021 15:29:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BBC968F66\n\tfor ;\n\tMon, 18 Oct 2021 15:29:43 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.238.109.14])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE7C91911;\n\tMon, 18 Oct 2021 15:29:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FC7xpu4t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634563783;\n\tbh=hfjpvSQqCs//72iNuuLxUjRm9PALFMcpyT8ckGvEmGM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FC7xpu4twwHcE5QI7xE+XDWAa8iq48JsccqXztoWZgFaMEcQ3NgG/21KGbRVvzvRf\n\tIF+Fpd807AXykjwyDy4ztoUMwd5GwSC8JeGJMgTmcpi7KtA1NhgAQ+lAYwFzRDGE96\n\ttGEdsRbijErn7mjF4n1HFzFIFsukJ0y+yD6YlNAs=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 18 Oct 2021 18:59:19 +0530","Message-Id":"<20211018132923.476242-8-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20211018132923.476242-1-umang.jain@ideasonboard.com>","References":"<20211018132923.476242-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 07/11] android: camera_stream: Return\n\tnon-const pointer from camera3Stream()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nThe camera3_stream_t instances are used to interact with the camera\nservice, whose API uses non-const pointers. Replace the const reference\nreturned by CameraStream::camera3Stream() with a non-const pointer. It\nturns out that nobody calls this function, but new users will be\nintroduced in subsequent commits.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_stream.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\nindex 197bd995..85064268 100644\n--- a/src/android/camera_stream.h\n+++ b/src/android/camera_stream.h\n@@ -114,7 +114,7 @@ public:\n \t\t camera3_stream_t *camera3Stream, unsigned int index);\n \n \tType type() const { return type_; }\n-\tconst camera3_stream_t &camera3Stream() const { return *camera3Stream_; }\n+\tcamera3_stream_t *camera3Stream() const { return camera3Stream_; }\n \tconst libcamera::StreamConfiguration &configuration() const;\n \tlibcamera::Stream *stream() const;\n \n","prefixes":["libcamera-devel","07/11"]}