{"id":14124,"url":"https://patchwork.libcamera.org/api/1.1/patches/14124/?format=json","web_url":"https://patchwork.libcamera.org/patch/14124/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211013154125.133419-9-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-13T15:41:20","name":"[libcamera-devel,08/13] ipa: ipu3: agc: Simplify division of exposure/gain","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"95999ff1d206927c82857450b108985c4bf7d06f","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14124/mbox/","series":[{"id":2623,"url":"https://patchwork.libcamera.org/api/1.1/series/2623/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2623","date":"2021-10-13T15:41:13","name":"ipa: ipu3: Fix AGC bugs","version":1,"mbox":"https://patchwork.libcamera.org/series/2623/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14124/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14124/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59D89C324C\n\tfor ;\n\tWed, 13 Oct 2021 15:41:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C521168F55;\n\tWed, 13 Oct 2021 17:41:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 708E568F56\n\tfor ;\n\tWed, 13 Oct 2021 17:41:32 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3857:aa01:4281:bd9f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9F2EFD2;\n\tWed, 13 Oct 2021 17:41:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nE0MY74+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634139691;\n\tbh=X36ki1ZFlNfuS3bFHEFOMnL+XUcH2ZXz6SHyBsfebGI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nE0MY74+BvQCBn7/N2/EosW62OaioJs3f2chDubwYuMOiyODsZ0DVUFI8YTRVmwl/\n\tt/CH0+l5Wux8/Jh9S0CyYz0MKv2H+rDME9OS70D9qoieOodUKsas6y0Hiif9++xQdj\n\tmEauerEWOv52uWIY5GrkgH/9bRiDl6lidZok7hoY=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 13 Oct 2021 17:41:20 +0200","Message-Id":"<20211013154125.133419-9-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20211013154125.133419-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211013154125.133419-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 08/13] ipa: ipu3: agc: Simplify division\n\tof exposure/gain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We are not using the filtered result from filterExposure() and we make\ncomplex assumptions when dividing the exposure and analogue gain values.\n\nUse the same mechanism as in RPiController::Agc::divideUpExposure() with\nthe fixed limits defined previously. This simplifies the understanding,\nand corrects a bug in the analogue gain calculus.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/agc.cpp | 37 ++++++++++++++++++++++++---------\n 1 file changed, 27 insertions(+), 10 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex e58a8a8d..3ec1c60c 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -153,17 +153,34 @@ void Agc::lockExposureGain(uint32_t &exposure, double &gain)\n \t\t/* \\todo: estimate if we need to desaturate */\n \t\tfilterExposure();\n \n-\t\tDuration newExposure = 0.0s;\n-\t\tif (currentShutter < kMaxShutterSpeed) {\n-\t\t\texposure = std::clamp(static_cast(exposure * currentExposure_ / currentExposureNoDg_), minExposureLines_, maxExposureLines_);\n-\t\t\tnewExposure = currentExposure_ / exposure;\n-\t\t\tgain = std::clamp(static_cast(gain * currentExposure_ / newExposure), kMinGain, kMaxGain);\n-\t\t} else if (currentShutter >= kMaxShutterSpeed) {\n-\t\t\tgain = std::clamp(static_cast(gain * currentExposure_ / currentExposureNoDg_), kMinGain, kMaxGain);\n-\t\t\tnewExposure = currentExposure_ / gain;\n-\t\t\texposure = std::clamp(static_cast(exposure * currentExposure_ / newExposure), minExposureLines_, maxExposureLines_);\n+\t\tDuration exposureValue = filteredExposure_;\n+\t\tDuration shutterTime = kMinShutterSpeed;\n+\t\tdouble stepGain = kMinGain;\n+\n+\t\tif (shutterTime * stepGain < exposureValue) {\n+\t\t\tDuration maxShutterMinGain = kMaxShutterSpeed * stepGain;\n+\t\t\tif (maxShutterMinGain >= exposureValue) {\n+\t\t\t\tLOG(IPU3Agc, Debug) << \"Setting shutterTime to \" << shutterTime;\n+\t\t\t\tshutterTime = exposureValue / stepGain;\n+\t\t\t} else {\n+\t\t\t\tshutterTime = kMaxShutterSpeed;\n+\t\t\t}\n+\n+\t\t\tDuration maxGainShutter = kMaxGain * shutterTime;\n+\t\t\tif (maxGainShutter >= exposureValue) {\n+\t\t\t\tstepGain = exposureValue / shutterTime;\n+\t\t\t\tLOG(IPU3Agc, Debug) << \"Setting analogue gain to \" << stepGain;\n+\t\t\t} else {\n+\t\t\t\tstepGain = kMaxGain;\n+\t\t\t}\n \t\t}\n-\t\tLOG(IPU3Agc, Debug) << \"Adjust exposure \" << exposure * lineDuration_ << \" and gain \" << gain;\n+\n+\t\tLOG(IPU3Agc, Debug) << \"Divided up shutter and gain are \"\n+\t\t\t\t<< shutterTime << \" and \"\n+\t\t\t\t<< stepGain;\n+\n+\t\texposure = shutterTime / lineDuration_;\n+\t\tgain = stepGain;\n \t}\n \tlastFrame_ = frameCount_;\n }\n","prefixes":["libcamera-devel","08/13"]}