{"id":14116,"url":"https://patchwork.libcamera.org/api/1.1/patches/14116/?format=json","web_url":"https://patchwork.libcamera.org/patch/14116/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211013154125.133419-2-jeanmichel.hautbois@ideasonboard.com>","date":"2021-10-13T15:41:13","name":"[libcamera-devel,01/13] ipa: ipu3: awb: Set a threshold for the green saturation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b369e4a341d55e5be44ada0efdb971c8bc1674af","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14116/mbox/","series":[{"id":2623,"url":"https://patchwork.libcamera.org/api/1.1/series/2623/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2623","date":"2021-10-13T15:41:13","name":"ipa: ipu3: Fix AGC bugs","version":1,"mbox":"https://patchwork.libcamera.org/series/2623/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14116/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14116/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E418BDC71\n\tfor ;\n\tWed, 13 Oct 2021 15:41:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0C0468F5B;\n\tWed, 13 Oct 2021 17:41:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 872B268F4B\n\tfor ;\n\tWed, 13 Oct 2021 17:41:31 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3857:aa01:4281:bd9f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8504CFD2;\n\tWed, 13 Oct 2021 17:41:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nk2BkoZF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634139690;\n\tbh=HaU6ToiP+F/GS3g82cTg6FONqzCVXh4xnPo3K3fQ89o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nk2BkoZFtAWLRG7if2BDJ92ev/00VZAKhWyPiV2PX7vGxeO79vTfJ6K05qmpT7/qU\n\ti0l0DbLf46T6mTacjJrebm13wi1k996HB3ZvjzzxtF5AOPGyfJDmteC5cj4qcvk/Ep\n\tOWUpNVjuiFh+ZmuOOZe1pN8iAEO2ETh/CYFxeiQ0=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 13 Oct 2021 17:41:13 +0200","Message-Id":"<20211013154125.133419-2-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20211013154125.133419-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211013154125.133419-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 01/13] ipa: ipu3: awb: Set a threshold for\n\tthe green saturation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We can have a saturation ratio per cell, giving the percentage of pixels\nover a threshold within a cell where 100% is set to 0xff.\n\nThe parameter structure 'ipu3_uapi_awb_config_s' contains four fields to\nset the threshold, one per channel.\nThe blue field is also used to configure the ImgU and make it calculate\nthe saturation ratio or not.\n\nSet a green value saturated when it is more than 230 (90% of the maximum\nvalue 255, coded as 8191).\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/awb.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex e2b18336..5574bd44 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -326,9 +326,9 @@ void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n \n void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n {\n-\tparams->acc_param.awb.config.rgbs_thr_gr = 8191;\n+\tparams->acc_param.awb.config.rgbs_thr_gr = (90 * 8191 / 100);\n \tparams->acc_param.awb.config.rgbs_thr_r = 8191;\n-\tparams->acc_param.awb.config.rgbs_thr_gb = 8191;\n+\tparams->acc_param.awb.config.rgbs_thr_gb = (90 * 8191 / 100);\n \tparams->acc_param.awb.config.rgbs_thr_b = IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT\n \t\t\t\t\t | IPU3_UAPI_AWB_RGBS_THR_B_EN\n \t\t\t\t\t | 8191;\n","prefixes":["libcamera-devel","01/13"]}