{"id":14101,"url":"https://patchwork.libcamera.org/api/1.1/patches/14101/?format=json","web_url":"https://patchwork.libcamera.org/patch/14101/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211012001325.1952-1-laurent.pinchart@ideasonboard.com>","date":"2021-10-12T00:13:25","name":"[libcamera-devel] libcamera: v4l2_subdevice: Set format field to V4L2_FIELD_NONE","commit_ref":"2f75a7e5b8c6258dc12e9e3128cb30133f66b4f9","pull_url":null,"state":"accepted","archived":false,"hash":"e027d491b751116f3077db5e15112ab3d5d69d2b","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14101/mbox/","series":[{"id":2614,"url":"https://patchwork.libcamera.org/api/1.1/series/2614/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2614","date":"2021-10-12T00:13:25","name":"[libcamera-devel] libcamera: v4l2_subdevice: Set format field to V4L2_FIELD_NONE","version":1,"mbox":"https://patchwork.libcamera.org/series/2614/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14101/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14101/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 429C1C323E\n\tfor ;\n\tTue, 12 Oct 2021 00:13:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9233A68F4C;\n\tTue, 12 Oct 2021 02:13:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BAB36027A\n\tfor ;\n\tTue, 12 Oct 2021 02:13:42 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B36DCF1\n\tfor ;\n\tTue, 12 Oct 2021 02:13:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KDDMk42Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633997621;\n\tbh=PBe5kPVyimTBHbf6+aiukqFox8WCMd2pVKlsaTUPcfs=;\n\th=From:To:Subject:Date:From;\n\tb=KDDMk42YSsG/44CQHutb+KMFKk2ZMCQ9vYaiL/B9n5xwkR5rWF8OSr02Sk1xKBJ/o\n\tgj5E5cVRNV/nDaeb5jYg08LOQ4WP0uRvCvYvqkPaw5jFweyUGewMvgGHw1x+ln2eyT\n\tQsmfiLos9fffHgbGgbHAhchc1YvWxsxcLKr8B8I8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 12 Oct 2021 03:13:25 +0300","Message-Id":"<20211012001325.1952-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_subdevice: Set format\n\tfield to V4L2_FIELD_NONE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libcamera doesn't support interlaced formats, set the field to\nV4L2_FIELD_NONE explicitly instead of relying on drivers to interpret\nV4L2_FIELD_ANY the way we want it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/v4l2_subdevice.cpp | 1 +\n 1 file changed, 1 insertion(+)\n\n\nbase-commit: fa7a95bf32c6a8ee87b67159d4238cbc8e6dc3a9","diff":"diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 8fe5e45b31ee..023e2328893d 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -425,6 +425,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tsubdevFmt.format.width = format->size.width;\n \tsubdevFmt.format.height = format->size.height;\n \tsubdevFmt.format.code = format->mbus_code;\n+\tsubdevFmt.format.field = V4L2_FIELD_NONE;\n \n \tint ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n \tif (ret) {\n","prefixes":["libcamera-devel"]}