{"id":14045,"url":"https://patchwork.libcamera.org/api/1.1/patches/14045/?format=json","web_url":"https://patchwork.libcamera.org/patch/14045/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211005073114.3997303-2-hiroh@chromium.org>","date":"2021-10-05T07:31:09","name":"[libcamera-devel,RFC,1/6] ipa: raspberrypi: agc: Remove using namespace in agc.hpp","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"603b6606442c4d633380c0ebe4be4e0d681ddccd","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14045/mbox/","series":[{"id":2602,"url":"https://patchwork.libcamera.org/api/1.1/series/2602/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2602","date":"2021-10-05T07:31:08","name":"Remove using namespace in header files","version":1,"mbox":"https://patchwork.libcamera.org/series/2602/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14045/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14045/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 617F3BDC71\n\tfor ;\n\tTue, 5 Oct 2021 07:31:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FFE1691BC;\n\tTue, 5 Oct 2021 09:31:28 +0200 (CEST)","from mail-pg1-x536.google.com (mail-pg1-x536.google.com\n\t[IPv6:2607:f8b0:4864:20::536])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F000691AD\n\tfor ;\n\tTue, 5 Oct 2021 09:31:26 +0200 (CEST)","by mail-pg1-x536.google.com with SMTP id e7so18994187pgk.2\n\tfor ;\n\tTue, 05 Oct 2021 00:31:26 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:debc:d0db:3bd8:f961])\n\tby smtp.gmail.com with ESMTPSA id\n\to14sm16761812pfh.145.2021.10.05.00.31.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 05 Oct 2021 00:31:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"oIG/GuAf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=sD+G4dXPqVKcTTthftsISBS4v0B+kI9t9hVidH3zJz0=;\n\tb=oIG/GuAf/BMP+JyGdokQxJjEovg6XKIb49XIZLAzaWCqKbwxNUtYJo3sgCjthPFPQF\n\t5zhcW9gM+ExBRGsn+0c+13KuYYwcxmbGq8PEPz0kkkFmDMkZGZ6pZ4Gp0C+060DmZaZH\n\tAyxZMzGqyh63qs7MCem/pKrPyu8SkUrBqYbzc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=sD+G4dXPqVKcTTthftsISBS4v0B+kI9t9hVidH3zJz0=;\n\tb=w4XTF5DnxdNYUNOmSKaLvP0HMiEjCwcWaM0uriooD4NxdPy1n4Xbnfs3VlVTu5kQh9\n\tIPu/tT0B+DQRJDtdnWOnABMvfmStnwOyRDjIPtdjF+ct3IoXtw/AXSLBP5xDYPDmc30O\n\tbTdUCFPKHQclcUCOef88Y3a/UUlSI5mfYUKlZ8gn53NAMWpMJTCmYAbLfX6wGkWaAEe2\n\tGMH0DsbsK0RZo49rjvEDwBDaCd4oMFzhFrFbYqug2AQ+yrbp3PJ1+t6ByYrKhkF8zOEG\n\tn2O+3DfnwKeQtiC3USb0Agtr6+b4NTivxw0QTkV9wf2vXo9TIFjuAbMQx3qJ2QCilqgp\n\tgIXQ==","X-Gm-Message-State":"AOAM530PeXmRsf0xS4To7gZej6IU4qBgmldihHviTXvJETotEl54Y+W9\n\tPEXB1Yb4l1CF5tQ5ijpbMGJp8r1mGb235Q==","X-Google-Smtp-Source":"ABdhPJyQvOTfpLdmNA4QypooDfIPSv+Q7q7/bPE8Ari6xvZ6y42Yd3SwiBSl4+hZvYvVgWU0CUsJrg==","X-Received":"by 2002:a05:6a00:16cb:b0:44b:bd38:e068 with SMTP id\n\tl11-20020a056a0016cb00b0044bbd38e068mr30476151pfc.34.1633419084782; \n\tTue, 05 Oct 2021 00:31:24 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Oct 2021 16:31:09 +0900","Message-Id":"<20211005073114.3997303-2-hiroh@chromium.org>","X-Mailer":"git-send-email 2.33.0.800.g4c38ced690-goog","In-Reply-To":"<20211005073114.3997303-1-hiroh@chromium.org>","References":"<20211005073114.3997303-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 1/6] ipa: raspberrypi: agc: Remove\n\tusing namespace in agc.hpp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"\"using namespace\" in a header file propagates the namespace to\nthe files including the header file. So it should be avoided.\nThis removes \"using namespace\" in agc.hpp.\n\nSigned-off-by: Hirokazu Honda \n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 7 +++++++\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 ++----\n 2 files changed, 9 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 289c1fce..f6a9cb0a 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -22,6 +22,7 @@\n using namespace RPiController;\n using namespace libcamera;\n using libcamera::utils::Duration;\n+using namespace std::literals::chrono_literals;\n \n LOG_DEFINE_CATEGORY(RPiAgc)\n \n@@ -159,6 +160,12 @@ void AgcConfig::Read(boost::property_tree::ptree const ¶ms)\n \tdefault_analogue_gain = params.get(\"default_analogue_gain\", 1.0);\n }\n \n+Agc::ExposureValues::ExposureValues()\n+\t: shutter(0s), analogue_gain(0),\n+\t total_exposure(0s), total_exposure_no_dg(0s)\n+{\n+}\n+\n Agc::Agc(Controller *controller)\n \t: AgcAlgorithm(controller), metering_mode_(nullptr),\n \t exposure_mode_(nullptr), constraint_mode_(nullptr),\ndiff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\nindex 82063636..c100d312 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n@@ -24,8 +24,6 @@\n \n namespace RPiController {\n \n-using namespace std::literals::chrono_literals;\n-\n struct AgcMeteringMode {\n \tdouble weights[AGC_STATS_SIZE];\n \tvoid Read(boost::property_tree::ptree const ¶ms);\n@@ -112,8 +110,8 @@ private:\n \tuint64_t frame_count_;\n \tAwbStatus awb_;\n \tstruct ExposureValues {\n-\t\tExposureValues() : shutter(0s), analogue_gain(0),\n-\t\t\t\t total_exposure(0s), total_exposure_no_dg(0s) {}\n+\t\tExposureValues();\n+\n \t\tlibcamera::utils::Duration shutter;\n \t\tdouble analogue_gain;\n \t\tlibcamera::utils::Duration total_exposure;\n","prefixes":["libcamera-devel","RFC","1/6"]}