{"id":14013,"url":"https://patchwork.libcamera.org/api/1.1/patches/14013/?format=json","web_url":"https://patchwork.libcamera.org/patch/14013/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210930095513.76213-19-jeanmichel.hautbois@ideasonboard.com>","date":"2021-09-30T09:55:13","name":"[libcamera-devel,18/18] ipa: ipu3: Implement an empty stop() function","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"61baa4020e1838dd21bc58d88a57b964a25f58e2","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14013/mbox/","series":[{"id":2588,"url":"https://patchwork.libcamera.org/api/1.1/series/2588/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2588","date":"2021-09-30T09:54:55","name":"Document IPU3 IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/2588/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14013/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14013/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F03BFC3243\n\tfor ;\n\tThu, 30 Sep 2021 09:55:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8C44691B0;\n\tThu, 30 Sep 2021 11:55:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68B3C691C1\n\tfor ;\n\tThu, 30 Sep 2021 11:55:21 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC2491B48;\n\tThu, 30 Sep 2021 11:55:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZvxOxBKK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632995720;\n\tbh=DDSdwo8bZwyghQYxYyzFaX9+s+vyW6k7QMqpYPha5CM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZvxOxBKKbNf++FzPMxWPPG6E2oVXM7xzVWWHqoHLtaX/gZtycU9rM81/nt4dz+sRH\n\t9f8Sc1s9s71KUAjifVvfkqHiZUdmRUVNO+U2x6b5XPgjznAW4QJzKhOR6tzBZMsWqJ\n\t92Wm3kj59x0+CSfalFZGwolb8kGfztZijLu54YPI=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Sep 2021 11:55:13 +0200","Message-Id":"<20210930095513.76213-19-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 18/18] ipa: ipu3: Implement an empty\n\tstop() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"While the stop() method does not currently perform any action, it forms\npart of the IPA interface and is a public function in the class.\n\nPromote it to a full (but basic) function implementation and begin the\ndocumentation accordingly so that there is an appropriate stub to\nperform stop operations if they come up.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 1b1fc052..4f2fbf34 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -129,7 +129,7 @@ public:\n \t\t ControlInfoMap *ipaControls) override;\n \n \tint start() override;\n-\tvoid stop() override {}\n+\tvoid stop() override;\n \n \tint configure(const IPAConfigInfo &configInfo) override;\n \n@@ -263,6 +263,13 @@ int IPAIPU3::start()\n \treturn 0;\n }\n \n+/**\n+ * \\brief Ensure that all processing has completed.\n+ */\n+void IPAIPU3::stop()\n+{\n+}\n+\n /**\n * \\brief Calculate a grid for the AWB statistics\n *\n","prefixes":["libcamera-devel","18/18"]}