{"id":14012,"url":"https://patchwork.libcamera.org/api/1.1/patches/14012/?format=json","web_url":"https://patchwork.libcamera.org/patch/14012/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210930095513.76213-17-jeanmichel.hautbois@ideasonboard.com>","date":"2021-09-30T09:55:11","name":"[libcamera-devel,16/18] ipa: ipu3: awb: Document the Accumulator::sum variable","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"2c706721b3edc0d789cdae38a221e8f910181657","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14012/mbox/","series":[{"id":2588,"url":"https://patchwork.libcamera.org/api/1.1/series/2588/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2588","date":"2021-09-30T09:54:55","name":"Document IPU3 IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/2588/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14012/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14012/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57B12C3243\n\tfor ;\n\tThu, 30 Sep 2021 09:55:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12464691B1;\n\tThu, 30 Sep 2021 11:55:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21C96691BF\n\tfor ;\n\tThu, 30 Sep 2021 11:55:21 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5368E18BF;\n\tThu, 30 Sep 2021 11:55:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o8HjtiCH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632995720;\n\tbh=A/hOwYdwCOMxXcL/EkM0IZNHF0/YRKXrGjdUpGmcp50=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o8HjtiCH6B2GStnegtqIrLFyKIlU7ezYeUEd6IRFOGACHK6qYjGzyzA8kngy7uHpW\n\tuQr5/xNivLBMMW55L2OjZDfIFEb7ayTg1Mh8ge1i/EqMTW/PVTI18CkLjGX8hacuFg\n\t8PdUsyy2D8GpbGQNrO9n7SphOAP7ZU+PBx1VaYtA=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Sep 2021 11:55:11 +0200","Message-Id":"<20210930095513.76213-17-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 16/18] ipa: ipu3: awb: Document the\n\tAccumulator::sum variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Doxygen warns about the undocumented variable sum. Fix it by adding a\nsmall brief.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/awb.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 59bc6900..af1edd11 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -86,6 +86,9 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;\n *\n * \\var Accumulator::blue\n * \\brief Sum of the average blue values of each unsaturated cell in the zone\n+ *\n+ * \\var Accumulator::sum\n+ * \\brief A structure containing the average red, green and blue sums\n */\n \n /**\n","prefixes":["libcamera-devel","16/18"]}