{"id":14008,"url":"https://patchwork.libcamera.org/api/1.1/patches/14008/?format=json","web_url":"https://patchwork.libcamera.org/patch/14008/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210930095513.76213-13-jeanmichel.hautbois@ideasonboard.com>","date":"2021-09-30T09:55:07","name":"[libcamera-devel,12/18] ipa: ipu3: algorithms: awb: Privatize internal structures","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"358beb25d2ab79f06b591db59e1e6963e6613d05","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14008/mbox/","series":[{"id":2588,"url":"https://patchwork.libcamera.org/api/1.1/series/2588/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2588","date":"2021-09-30T09:54:55","name":"Document IPU3 IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/2588/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14008/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14008/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E19D4C3243\n\tfor ;\n\tThu, 30 Sep 2021 09:55:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A410A691D7;\n\tThu, 30 Sep 2021 11:55:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4185691BB\n\tfor ;\n\tThu, 30 Sep 2021 11:55:19 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B259B2B;\n\tThu, 30 Sep 2021 11:55:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YxAg0xXV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632995719;\n\tbh=b1L0NSvEGUD2zE1QToOQEk16rOfGtL8CZiSqo+WYPUY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YxAg0xXVnY8ZDhwsJWNa8QGqRiXNBG+w7/r63JZc7FWNRKe/sw38NukRF11rq/tiv\n\tn176UUuiDl2FiC4/+oh4d5AR4O8+RGlomxYkd6IleTu2th1YNGLSD3auK8ZmrTnj0n\n\tQ1Rc9yoHCq6Ffmit0etDuRliZ/jQOYagDHayIs8Q=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Sep 2021 11:55:07 +0200","Message-Id":"<20210930095513.76213-13-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 12/18] ipa: ipu3: algorithms: awb:\n\tPrivatize internal structures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Kieran Bingham \n\nThe struct RGB and struct AwbStatus are used only by the internal\nimplementation of the AWB algorithm module.\n\nMove them into the private class declaration.\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/ipu3/algorithms/awb.h | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex 677384ed..a56362ff 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -42,6 +42,7 @@ public:\n \tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n \n+private:\n \t/* \\todo Make these structs available to all the ISPs ? */\n \tstruct RGB {\n \t\tRGB(double _R = 0, double _G = 0, double _B = 0)\n","prefixes":["libcamera-devel","12/18"]}