{"id":14003,"url":"https://patchwork.libcamera.org/api/1.1/patches/14003/?format=json","web_url":"https://patchwork.libcamera.org/patch/14003/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210930095513.76213-8-jeanmichel.hautbois@ideasonboard.com>","date":"2021-09-30T09:55:02","name":"[libcamera-devel,07/18] ipa: ipu3: tonemapping: Generate the LUT only on gamma change","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"42e62ea816b3730008e4c236c451b2ed3ae56f3c","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14003/mbox/","series":[{"id":2588,"url":"https://patchwork.libcamera.org/api/1.1/series/2588/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2588","date":"2021-09-30T09:54:55","name":"Document IPU3 IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/2588/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14003/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14003/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E3B9C3243\n\tfor ;\n\tThu, 30 Sep 2021 09:55:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69366691C2;\n\tThu, 30 Sep 2021 11:55:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB8DC691AF\n\tfor ;\n\tThu, 30 Sep 2021 11:55:18 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71924B2B;\n\tThu, 30 Sep 2021 11:55:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FLLzi0Dk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632995718;\n\tbh=J78eq31SfqKEyjJaVAd2zPmJfXOgqBM/lhSqzO2a36E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FLLzi0Dk1+TbW+c81PClC1jOlFkXcUNeUEGnMlzwRLeG6bZfvPSipGGclh6lIzs5g\n\tvC2/juncGkWE4OVy5OI323V7QzTjrRYzwOGRz/DlElkMFY09IphtuUMgBKE61ejBLu\n\tJ3/DJHQh1BRxMcbF0IcsJWlqI7DjeqWSgjj5taLU=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Sep 2021 11:55:02 +0200","Message-Id":"<20210930095513.76213-8-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 07/18] ipa: ipu3: tonemapping: Generate\n\tthe LUT only on gamma change","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Tonemapping algorithm calculates the gamma curve for every frame,\nregardless of whether the gamma value has changed or not. This issue is\nexasperated as we currently hardcode the gamma to a single value.\n\nOptimise the implementation to only recalculate the look up table when\nthe gamma setting is changed, and store the gamma setting of the LUT\ncurve as part of the IPA context.\n\nSigned-off-by: Jean-Michel Hautbois \nSigned-off-by: Kieran Bingham \n---\n src/ipa/ipu3/algorithms/tone_mapping.cpp | 5 +++++\n src/ipa/ipu3/ipa_context.h | 1 +\n src/ipa/ipu3/ipu3.cpp | 3 +++\n 3 files changed, 9 insertions(+)","diff":"diff --git a/src/ipa/ipu3/algorithms/tone_mapping.cpp b/src/ipa/ipu3/algorithms/tone_mapping.cpp\nindex 3af96261..40337f9d 100644\n--- a/src/ipa/ipu3/algorithms/tone_mapping.cpp\n+++ b/src/ipa/ipu3/algorithms/tone_mapping.cpp\n@@ -43,6 +43,9 @@ void ToneMapping::process([[maybe_unused]] IPAContext &context,\n \t */\n \tgamma_ = 1.1;\n \n+\tif (context.frameContext.toneMapping.gamma == gamma_)\n+\t\treturn;\n+\n \tstruct ipu3_uapi_gamma_corr_lut &lut =\n \t\tcontext.frameContext.toneMapping.gammaCorrection;\n \n@@ -53,6 +56,8 @@ void ToneMapping::process([[maybe_unused]] IPAContext &context,\n \t\t/* The output value is expressed on 13 bits. */\n \t\tlut.lut[i] = gamma * 8191;\n \t}\n+\n+\tcontext.frameContext.toneMapping.gamma = gamma_;\n }\n \n } /* namespace ipa::ipu3::algorithms */\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex 5bab684c..e50de726 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -39,6 +39,7 @@ struct IPAFrameContext {\n \t} awb;\n \n \tstruct {\n+\t\tdouble gamma;\n \t\tstruct ipu3_uapi_gamma_corr_lut gammaCorrection;\n \t} toneMapping;\n };\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex a27f5e98..9867c993 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -131,6 +131,9 @@\n * \\struct IPAFrameContext::toneMapping\n * \\brief Context for ToneMapping and Gamma control\n *\n+ * \\var IPAFrameContext::toneMapping::gamma\n+ * \\brief Gamma value for the LUT\n+ *\n * \\var IPAFrameContext::toneMapping::gammaCorrection\n * \\brief Per-pixel tone mapping implemented as a LUT\n *\n","prefixes":["libcamera-devel","07/18"]}