{"id":140,"url":"https://patchwork.libcamera.org/api/1.1/patches/140/?format=json","web_url":"https://patchwork.libcamera.org/patch/140/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190103013110.6849-6-laurent.pinchart@ideasonboard.com>","date":"2019-01-03T01:31:07","name":"[libcamera-devel,6/9] libcamera: device_enumerator: Constify argument to search function","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6e04c7775fed0c1794bc953d744956504ff897cc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/140/mbox/","series":[{"id":51,"url":"https://patchwork.libcamera.org/api/1.1/series/51/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=51","date":"2019-01-03T01:31:02","name":"[libcamera-devel,1/9] libcamera: camera_manager: Remove put() method","version":1,"mbox":"https://patchwork.libcamera.org/series/51/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/140/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/140/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0320D60B39\n\tfor ;\n\tThu, 3 Jan 2019 02:30:15 +0100 (CET)","from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 873BA573\n\tfor ;\n\tThu, 3 Jan 2019 02:30:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546479014;\n\tbh=7ciHPqbwUpPkROtxXUA2DqAc9svbXM2Z8aWCLFd6h4c=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Skv9S2E1ePh5zK/HFSmi0jNF2ILXjkc9cUu/bGSkD0prUtz0nOpDXzmlkXBPr90ex\n\tIWZNVlO4+ry4Ukqe9ZnGTO+RYU/JSkbLn1auUURiHEWhXH/HEiK3lzCrqC1y8LZ9On\n\tPeUY0zlWFUluNRYuhWDVH8u949hVsNwEDZXN/Ttc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 3 Jan 2019 03:31:07 +0200","Message-Id":"<20190103013110.6849-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>","References":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 6/9] libcamera: device_enumerator:\n\tConstify argument to search function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Jan 2019 01:30:15 -0000"},"content":"The DeviceEnumerator::search() function doesn't need to modify its\nDeviceMatch argument, make it const.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/device_enumerator.cpp | 2 +-\n src/libcamera/include/device_enumerator.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex ecd51bc1d108..a301420f39e1 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -215,7 +215,7 @@ int DeviceEnumerator::addDevice(const std::string &devnode)\n *\n * \\return pointer to the matching MediaDevice, nullptr if no match is found\n */\n-MediaDevice *DeviceEnumerator::search(DeviceMatch &dm) const\n+MediaDevice *DeviceEnumerator::search(const DeviceMatch &dm) const\n {\n \tfor (MediaDevice *dev : devices_) {\n \t\tif (dev->busy())\ndiff --git a/src/libcamera/include/device_enumerator.h b/src/libcamera/include/device_enumerator.h\nindex 0d104667323b..29737da7a225 100644\n--- a/src/libcamera/include/device_enumerator.h\n+++ b/src/libcamera/include/device_enumerator.h\n@@ -41,7 +41,7 @@ public:\n \tvirtual int init() = 0;\n \tvirtual int enumerate() = 0;\n \n-\tMediaDevice *search(DeviceMatch &dm) const;\n+\tMediaDevice *search(const DeviceMatch &dm) const;\n \n protected:\n \tint addDevice(const std::string &devnode);\n","prefixes":["libcamera-devel","6/9"]}