{"id":13988,"url":"https://patchwork.libcamera.org/api/1.1/patches/13988/?format=json","web_url":"https://patchwork.libcamera.org/patch/13988/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210930093715.73293-6-jeanmichel.hautbois@ideasonboard.com>","date":"2021-09-30T09:37:08","name":"[libcamera-devel,v2,05/12] ipa: ipu3: Change the limits of the AWB stats","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a2ed47e6de37316d78dc8010178e50e0c94fee87","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13988/mbox/","series":[{"id":2587,"url":"https://patchwork.libcamera.org/api/1.1/series/2587/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2587","date":"2021-09-30T09:37:03","name":"Improve ImgU statistics usage","version":2,"mbox":"https://patchwork.libcamera.org/series/2587/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13988/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13988/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11820BDC71\n\tfor ;\n\tThu, 30 Sep 2021 09:37:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5427691C9;\n\tThu, 30 Sep 2021 11:37:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5004691B3\n\tfor ;\n\tThu, 30 Sep 2021 11:37:20 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 590D118BF;\n\tThu, 30 Sep 2021 11:37:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O/neG4H+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632994640;\n\tbh=aDIEbCQIZBRLcK5OnUXvXCc8H+HYmCpFIvAIBJhYTok=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=O/neG4H+0SpUywC5k+jDOlbY4+UtgmgtbGkzZuZ1D0XQFX6sd04eJ1AK94gLnKtI8\n\tFMzo2iivCP3WxQjAhp2Nu4nFdz+Riu51xtmNoN2jJl4ZzQfa0YerdHqzRqX1kc6a3i\n\tTxI2nu3ThKDpfZahofXzPHr9AeZw4JTUtu27yGBo=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Sep 2021 11:37:08 +0200","Message-Id":"<20210930093715.73293-6-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210930093715.73293-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210930093715.73293-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 05/12] ipa: ipu3: Change the limits of\n\tthe AWB stats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Until now, the limits used to calculate the grid based on the Bayer Down\nScaler configuration where taken from the kernel documentation [0].\nWhile testing and understanding the format of the ImgU statistics, it\nappears that the ones defined in CrOS [1] are the correct ones. Use\nthose.\n\n[0] https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/pixfmt-meta-intel-ipu3.html?highlight=v4l2_meta_fmt_ipu3_params#intel-ipu3-imgu-uapi-data-types\n[1] https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/refs/heads/master/hal/intel/include/ia_imaging/awb_public.h\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/ipu3.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex ac98a86b..b3ac96ed 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -136,8 +136,8 @@\n * struct ipu3_uapi_gamma_corr_lut for further details.\n */\n \n-static constexpr uint32_t kMaxCellWidthPerSet = 160;\n-static constexpr uint32_t kMaxCellHeightPerSet = 56;\n+static constexpr uint32_t kMaxCellWidthPerSet = 80;\n+static constexpr uint32_t kMaxCellHeightPerSet = 60;\n \n namespace libcamera {\n \n@@ -300,11 +300,11 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n \t/* Set the BDS output size in the IPAConfiguration structure */\n \tcontext_.configuration.grid.bdsOutputSize = bdsOutputSize;\n \n-\tfor (uint32_t widthShift = 3; widthShift <= 7; ++widthShift) {\n+\tfor (uint32_t widthShift = 3; widthShift <= 6; ++widthShift) {\n \t\tuint32_t width = std::min(kMaxCellWidthPerSet,\n \t\t\t\t\t bdsOutputSize.width >> widthShift);\n \t\twidth = width << widthShift;\n-\t\tfor (uint32_t heightShift = 3; heightShift <= 7; ++heightShift) {\n+\t\tfor (uint32_t heightShift = 3; heightShift <= 6; ++heightShift) {\n \t\t\tint32_t height = std::min(kMaxCellHeightPerSet,\n \t\t\t\t\t\t bdsOutputSize.height >> heightShift);\n \t\t\theight = height << heightShift;\n","prefixes":["libcamera-devel","v2","05/12"]}