{"id":13906,"url":"https://patchwork.libcamera.org/api/1.1/patches/13906/?format=json","web_url":"https://patchwork.libcamera.org/patch/13906/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210923083748.146265-3-umang.jain@ideasonboard.com>","date":"2021-09-23T08:37:48","name":"[libcamera-devel,v4,2/2] android: Fix generation of thumbnail for EXIF data","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"447cadf0a3fb446ed4f6de78840da84471a644d6","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13906/mbox/","series":[{"id":2549,"url":"https://patchwork.libcamera.org/api/1.1/series/2549/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2549","date":"2021-09-23T08:37:46","name":"android: Fix generation of thumbnail for EXIF data","version":4,"mbox":"https://patchwork.libcamera.org/series/2549/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13906/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13906/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CA96BF01C\n\tfor ;\n\tThu, 23 Sep 2021 08:38:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0E436918C;\n\tThu, 23 Sep 2021 10:38:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AF42687DC\n\tfor ;\n\tThu, 23 Sep 2021 10:38:04 +0200 (CEST)","from perceval.ideasonboard.com (unknown\n\t[IPv6:2405:204:8203:58de:7651:79c1:5e62:dca9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E937858B;\n\tThu, 23 Sep 2021 10:38:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D3MqJ1xX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632386284;\n\tbh=iB4nwK/QnGjbVfoC9pwEtE8hkWXhxfdiEZDXyH1RBoM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=D3MqJ1xXpPYP0Rmpfru6nzJAWwqCGk7AB9kIeaxRVvA0HLyoATM7vuHNBi3YeX6GV\n\tBnjDpYnHPHPNbwa+H4h+/PSRhJEbJFq5HvE7okjCNYeRyoSRgIM4nmGLJQVc5EK5dY\n\t+UvCeFRQ3S273OOyZl2w5k6MYLVu42gpXntHfLWY=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 23 Sep 2021 14:07:48 +0530","Message-Id":"<20210923083748.146265-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210923083748.146265-1-umang.jain@ideasonboard.com>","References":"<20210923083748.146265-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 2/2] android: Fix generation of\n\tthumbnail for EXIF data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Generation of thumbnail is not occuring currently because\nANDROID_JPEG_THUMBNAIL_SIZE is not set for request metadata passed\nto PostProcessorJpeg::process(). This is a regression introduced in\n1264628d3c92(\"android: jpeg: Configure thumbnailer based on request\nmetadata\").\n\nThe patch fixes this issue by setting ANDROID_JPEG_THUMBNAIL_SIZE in\nthe request metadata template populated by\nCameraCapabilities::requestTemplatePreview(). The value for\nANDROID_JPEG_THUMBNAIL_SIZE is set to be the first non-zero size\nreported by static metadata ANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES.\n\nFixes: 1264628d3c92(\"android: jpeg: Configure thumbnailer based on request metadata\")\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \nReviewed-by: Hirokazu Honda \n---\n src/android/camera_capabilities.cpp | 21 ++++++++++++++++++++-\n 1 file changed, 20 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex edeb6943..ed59ae1c 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1347,7 +1347,7 @@ std::unique_ptr CameraCapabilities::requestTemplatePreview() con\n \t * CameraMetadata is capable of resizing the container on the fly, if\n \t * adding a new entry will exceed its capacity.\n \t */\n-\tauto requestTemplate = std::make_unique(21, 36);\n+\tauto requestTemplate = std::make_unique(22, 38);\n \tif (!requestTemplate->isValid()) {\n \t\treturn nullptr;\n \t}\n@@ -1368,6 +1368,25 @@ std::unique_ptr CameraCapabilities::requestTemplatePreview() con\n \trequestTemplate->addEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n \t\t\t\t entry.data.i32, 2);\n \n+\t/*\n+\t * Get thumbnail sizes from static metadata and add the first non-zero\n+\t * size to the template.\n+\t */\n+\tfound = staticMetadata_->getEntry(ANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES,\n+\t\t\t\t\t &entry);\n+\tASSERT(found && entry.count >= 4);\n+\tunsigned int j = 0;\n+\twhile (j < entry.count / 2) {\n+\t\tif (entry.data.i32[j] == 0 || entry.data.i32[j + 1] == 0) {\n+\t\t\tj += 2;\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\trequestTemplate->addEntry(ANDROID_JPEG_THUMBNAIL_SIZE,\n+\t\t\t\t\t entry.data.i32 + j, 2);\n+\t\tbreak;\n+\t}\n+\n \tuint8_t aeMode = ANDROID_CONTROL_AE_MODE_ON;\n \trequestTemplate->addEntry(ANDROID_CONTROL_AE_MODE, aeMode);\n \n","prefixes":["libcamera-devel","v4","2/2"]}