{"id":13900,"url":"https://patchwork.libcamera.org/api/1.1/patches/13900/?format=json","web_url":"https://patchwork.libcamera.org/patch/13900/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210923081625.60276-9-jeanmichel.hautbois@ideasonboard.com>","date":"2021-09-23T08:16:21","name":"[libcamera-devel,08/12] ipa: ipu3: awb: Correct the gain multipliers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"eba6c607fdbff7a0292a8528ad4725e95404e562","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13900/mbox/","series":[{"id":2548,"url":"https://patchwork.libcamera.org/api/1.1/series/2548/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2548","date":"2021-09-23T08:16:13","name":"Improve ImgU statistics usage","version":1,"mbox":"https://patchwork.libcamera.org/series/2548/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13900/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13900/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41692BF01C\n\tfor ;\n\tThu, 23 Sep 2021 08:16:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 008946919A;\n\tThu, 23 Sep 2021 10:16:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D754869196\n\tfor ;\n\tThu, 23 Sep 2021 10:16:31 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:392e:dcd2:2bf6:d61c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B7F3E52;\n\tThu, 23 Sep 2021 10:16:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rZmvyqTF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632384991;\n\tbh=OdYu2APJ2kVO9dPcr+oIt7r8HIWBLP8lE07g1Vf6XRo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rZmvyqTF9WN8N7wsq9M+xne+WTFZuUtMIurnIBNormMlWJTznr0DcTzM4yKTe9OXJ\n\t6CH7sTOoyUT64JhiGekMjQMIa6PoUizHZM4kMZAC5qMjhoWppoI7jnO28EJc5149uO\n\trfx4RJOLfq6S8eKYxyoQAVSq/ctQ9gjSQxovo+vk=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 23 Sep 2021 10:16:21 +0200","Message-Id":"<20210923081625.60276-9-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210923081625.60276-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210923081625.60276-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 08/12] ipa: ipu3: awb: Correct the gain\n\tmultipliers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The gains have a precision u3.13, range [0, 8) which means that a gain\nmultiplier value of 1.0 is represented as a multiplication by 8192 in\nthe ImgU. Correct the gains as this was misunderstood in the first\nplace.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/awb.cpp | 15 ++++++---------\n 1 file changed, 6 insertions(+), 9 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 800d023c..8a926691 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -313,6 +313,7 @@ void Awb::awbGreyWorld()\n \t/* Color temperature is not relevant in Grey world but still useful to estimate it :-) */\n \tasyncResults_.temperatureK = estimateCCT(sumRed.R, sumRed.G, sumBlue.B);\n \tasyncResults_.redGain = redGain;\n+\t/* Green gains should not be touched and considered 1. */\n \tasyncResults_.greenGain = 1.0;\n \tasyncResults_.blueGain = blueGain;\n }\n@@ -376,15 +377,11 @@ void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n \t\t\t\t\t\t\t* params->acc_param.bnr.opt_center.x_reset;\n \tparams->acc_param.bnr.opt_center_sqr.y_sqr_reset = params->acc_param.bnr.opt_center.y_reset\n \t\t\t\t\t\t\t* params->acc_param.bnr.opt_center.y_reset;\n-\t/*\n-\t * Green gains should not be touched and considered 1.\n-\t * Default is 16, so do not change it at all.\n-\t * 4096 is the value for a gain of 1.0\n-\t */\n-\tparams->acc_param.bnr.wb_gains.gr = 16 * context.frameContext.awb.gains.green;\n-\tparams->acc_param.bnr.wb_gains.r = 4096 * context.frameContext.awb.gains.red;\n-\tparams->acc_param.bnr.wb_gains.b = 4096 * context.frameContext.awb.gains.blue;\n-\tparams->acc_param.bnr.wb_gains.gb = 16 * context.frameContext.awb.gains.green;\n+\t/* 8192 is the multiplier for a gain of 1.0 */\n+\tparams->acc_param.bnr.wb_gains.gr = 8192 * context.frameContext.awb.gains.green;\n+\tparams->acc_param.bnr.wb_gains.r = 8192 * context.frameContext.awb.gains.red;\n+\tparams->acc_param.bnr.wb_gains.b = 8192 * context.frameContext.awb.gains.blue;\n+\tparams->acc_param.bnr.wb_gains.gb = 8192 * context.frameContext.awb.gains.green;\n \n \tLOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n \n","prefixes":["libcamera-devel","08/12"]}