{"id":13882,"url":"https://patchwork.libcamera.org/api/1.1/patches/13882/?format=json","web_url":"https://patchwork.libcamera.org/patch/13882/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210922104454.2963619-1-kieran.bingham@ideasonboard.com>","date":"2021-09-22T10:44:54","name":"[libcamera-devel,v2] gstreamer: Support planar formats","commit_ref":"f9ca897c7fe2846f0a2163563014ca02d3c1624a","pull_url":null,"state":"accepted","archived":false,"hash":"014f946106b3e2c45bd7ffe37e2fe5c4fb1dde90","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13882/mbox/","series":[{"id":2543,"url":"https://patchwork.libcamera.org/api/1.1/series/2543/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2543","date":"2021-09-22T10:44:54","name":"[libcamera-devel,v2] gstreamer: Support planar formats","version":2,"mbox":"https://patchwork.libcamera.org/series/2543/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13882/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13882/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01536BF01C\n\tfor ;\n\tWed, 22 Sep 2021 10:45:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A5F06918C;\n\tWed, 22 Sep 2021 12:45:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 872E86917F\n\tfor ;\n\tWed, 22 Sep 2021 12:44:58 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7C9EF1;\n\tWed, 22 Sep 2021 12:44:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XXfJkjGX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632307498;\n\tbh=8ZJqh09ExosSI3hZDErg79a+MnZXYEERKHII7sbPOkQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=XXfJkjGX8CRNUr7ijBc1OmlB4KoUpw9DrAYKAXfgn8Tr+OiqWVk/LejupDFBA381P\n\tYWIlQ5dXvSCzRomF7qgABB8EU7NgmzBr6AlCp3zExURA+xMm9/8VD0OHk90UPqHGzE\n\tJlm5C/vUCqgknnqmaPO48607/rUq8uB8RCTDtma0=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 22 Sep 2021 11:44:54 +0100","Message-Id":"<20210922104454.2963619-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] gstreamer: Support planar formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Existing pipeline handlers already support planar YUV formats.\nExtend the gstreamer format map to incorporate them.\n\nWhile here, split the formats into distinct groups.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nReviewed-by: Jean-Michel Hautbois \nReviewed-by: Paul Elder \n---\nv2:\n - Move Planar formats to after Semiplanar, and remove redundant\n 'Formats' description keyword.\n\n src/gstreamer/gstlibcamera-utils.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 0af91c1acb67..e1af30c835c4 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -16,19 +16,32 @@ static struct {\n \tGstVideoFormat gst_format;\n \tPixelFormat format;\n } format_map[] = {\n+\t/* Compressed */\n \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n+\n+\t/* RGB */\n \t{ GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n \t{ GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n \t{ GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n+\n+\t/* YUV Semiplanar */\n \t{ GST_VIDEO_FORMAT_NV12, formats::NV12 },\n \t{ GST_VIDEO_FORMAT_NV21, formats::NV21 },\n \t{ GST_VIDEO_FORMAT_NV16, formats::NV16 },\n \t{ GST_VIDEO_FORMAT_NV61, formats::NV61 },\n \t{ GST_VIDEO_FORMAT_NV24, formats::NV24 },\n+\n+\t/* YUV Planar */\n+\t{ GST_VIDEO_FORMAT_I420, formats::YUV420 },\n+\t{ GST_VIDEO_FORMAT_YV12, formats::YVU420 },\n+\t{ GST_VIDEO_FORMAT_Y42B, formats::YUV422 },\n+\n+\t/* YUV Packed */\n \t{ GST_VIDEO_FORMAT_UYVY, formats::UYVY },\n \t{ GST_VIDEO_FORMAT_VYUY, formats::VYUY },\n \t{ GST_VIDEO_FORMAT_YUY2, formats::YUYV },\n \t{ GST_VIDEO_FORMAT_YVYU, formats::YVYU },\n+\n \t/* \\todo NV42 is used in libcamera but is not mapped in GStreamer yet. */\n };\n \n","prefixes":["libcamera-devel","v2"]}