{"id":13833,"url":"https://patchwork.libcamera.org/api/1.1/patches/13833/?format=json","web_url":"https://patchwork.libcamera.org/patch/13833/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210913145810.66515-6-jeanmichel.hautbois@ideasonboard.com>","date":"2021-09-13T14:58:04","name":"[libcamera-devel,05/11] ipa: ipu3: Explicitly use the statistics parameter","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"e8878f21f3d71f0398f6d20542728593317f44d9","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13833/mbox/","series":[{"id":2523,"url":"https://patchwork.libcamera.org/api/1.1/series/2523/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2523","date":"2021-09-13T14:57:59","name":"Document all the IPU3 IPA classes","version":1,"mbox":"https://patchwork.libcamera.org/series/2523/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13833/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13833/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A7D1BDB1D\n\tfor ;\n\tMon, 13 Sep 2021 14:58:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9994669195;\n\tMon, 13 Sep 2021 16:58:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B9D06916F\n\tfor ;\n\tMon, 13 Sep 2021 16:58:15 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:edc5:688b:2ede:8b4b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AEBCD499;\n\tMon, 13 Sep 2021 16:58:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LQzfnweu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631545094;\n\tbh=RQKHVG1Ey3m3oKFmSOjlVgR6IHmAZBd/CKqvo7iXBno=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LQzfnweuwWilfclwwXnM1m4RymzQjfJWbnptpesaLx/OuMbgBY+ydGva40dFPF2Jv\n\tehoGux7SQHP1xVdahchFYieITcrphbFBnoY+/Tz0JHerLwBRqQS8EBgqoqdRIXWRs1\n\tk4aHGxIqu51bFx6urGo9SSiKPBZuE6Ka9qNzMqHY=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Sep 2021 16:58:04 +0200","Message-Id":"<20210913145810.66515-6-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 05/11] ipa: ipu3: Explicitly use the\n\tstatistics parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The stats pointer is marked as [[maybe_unused]]. This is a leftover from\na previous commit which was here to keep the compatibility while\ntransitioning to the new iterative algorithms.\n\nRemove this attribute to make it explicit that stats are really used to\nfeed the algorithms.\n\nSigned-off-by: Jean-Michel Hautbois \nSigned-off-by: Kieran Bingham \n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex df64b0f1..5b487dcd 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -597,7 +597,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n */\n void IPAIPU3::parseStatistics(unsigned int frame,\n \t\t\t [[maybe_unused]] int64_t frameTimestamp,\n-\t\t\t [[maybe_unused]] const ipu3_uapi_stats_3a *stats)\n+\t\t\t const ipu3_uapi_stats_3a *stats)\n {\n \tControlList ctrls(controls::controls);\n \n","prefixes":["libcamera-devel","05/11"]}