{"id":13817,"url":"https://patchwork.libcamera.org/api/1.1/patches/13817/?format=json","web_url":"https://patchwork.libcamera.org/patch/13817/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210913040110.13789-3-umang.jain@ideasonboard.com>","date":"2021-09-13T04:01:10","name":"[libcamera-devel,v2,2/2] android: Fix generation of thumbnail for EXIF data","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"61a6f32d1004b268ee0b00025104b9d1999cd708","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13817/mbox/","series":[{"id":2519,"url":"https://patchwork.libcamera.org/api/1.1/series/2519/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2519","date":"2021-09-13T04:01:08","name":"android: Fix generation of thumbnail for EXIF","version":2,"mbox":"https://patchwork.libcamera.org/series/2519/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13817/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13817/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96BA2BDB1D\n\tfor ;\n\tMon, 13 Sep 2021 04:01:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BB896918E;\n\tMon, 13 Sep 2021 06:01:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 214DA69187\n\tfor ;\n\tMon, 13 Sep 2021 06:01:28 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.152])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D54BD499;\n\tMon, 13 Sep 2021 06:01:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tcNvpQu+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631505687;\n\tbh=3dyxYgZddP5Tb9nd8fCCJY9+0HoNs444IQQAEotTUY4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tcNvpQu+rChrDISw0kEm/Hy0WOZtJYBFHU8Eu02OEOZd85N77iCjnKMZsITxdhlIe\n\tuHwB0boxpflG07HqZj1xBY59Bcmqo0H/I9pEYV2BOVkdIyLfgCgblrQ7GaLk3S35rQ\n\t/r28RU0MhL5sRLB3GH+/C9ATmuPHqVGvjxioQ/80=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Sep 2021 09:31:10 +0530","Message-Id":"<20210913040110.13789-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210913040110.13789-1-umang.jain@ideasonboard.com>","References":"<20210913040110.13789-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/2] android: Fix generation of\n\tthumbnail for EXIF data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Generation of thumbnail is not occuring currently because\nANDROID_JPEG_THUMBNAIL_SIZE is not set for request metadata passed\nto PostProcessorJpeg::process(). This is a regression introduced in\n1264628d3c92(\"android: jpeg: Configure thumbnailer based on request\nmetadata\").\n\nThe patch fixes this issue by setting ANDROID_JPEG_THUMBNAIL_SIZE in\nthe request metadata template populated by\nCameraCapabilities::requestTemplatePreview(). The value for\nANDROID_JPEG_THUMBNAIL_SIZE is set to be the first non-zero size\nreported by static metadata ANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES.\n\nFixes: 1264628d3c92(\"android: jpeg: Configure thumbnailer based on request metadata\")\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_capabilities.cpp | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex e92bca42..76dddafd 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1341,9 +1341,9 @@ std::unique_ptr CameraCapabilities::requestTemplatePreview() con\n {\n \t/*\n \t * \\todo Keep this in sync with the actual number of entries.\n-\t * Currently: 20 entries, 35 bytes\n+\t * Currently: 21 entries, 37 bytes\n \t */\n-\tauto requestTemplate = std::make_unique(21, 36);\n+\tauto requestTemplate = std::make_unique(22, 38);\n \tif (!requestTemplate->isValid()) {\n \t\treturn nullptr;\n \t}\n@@ -1364,6 +1364,16 @@ std::unique_ptr CameraCapabilities::requestTemplatePreview() con\n \trequestTemplate->addEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n \t\t\t\t entry.data.i32, 2);\n \n+\t/*\n+\t * Get thumbnail sizes from static metadata and add the first non-zero\n+\t * size to the template.\n+\t */\n+\tfound = staticMetadata_->getEntry(ANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES,\n+\t\t\t\t\t &entry);\n+\tASSERT(found && entry.count >= 4);\n+\trequestTemplate->addEntry(ANDROID_JPEG_THUMBNAIL_SIZE,\n+\t\t\t\t entry.data.i32 + 2, 2);\n+\n \tuint8_t aeMode = ANDROID_CONTROL_AE_MODE_ON;\n \trequestTemplate->addEntry(ANDROID_CONTROL_AE_MODE, aeMode);\n \n","prefixes":["libcamera-devel","v2","2/2"]}