{"id":13816,"url":"https://patchwork.libcamera.org/api/1.1/patches/13816/?format=json","web_url":"https://patchwork.libcamera.org/patch/13816/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210913040110.13789-2-umang.jain@ideasonboard.com>","date":"2021-09-13T04:01:09","name":"[libcamera-devel,v2,1/2] android: jpeg: Rectify variable naming style.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ac10ca4d4d7d950d59ff912b637db5134121ce0b","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13816/mbox/","series":[{"id":2519,"url":"https://patchwork.libcamera.org/api/1.1/series/2519/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2519","date":"2021-09-13T04:01:08","name":"android: Fix generation of thumbnail for EXIF","version":2,"mbox":"https://patchwork.libcamera.org/series/2519/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13816/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13816/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AACAFBDB1D\n\tfor ;\n\tMon, 13 Sep 2021 04:01:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 510D269189;\n\tMon, 13 Sep 2021 06:01:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AECC60131\n\tfor ;\n\tMon, 13 Sep 2021 06:01:26 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.152])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E1069E;\n\tMon, 13 Sep 2021 06:01:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PNJEMf2w\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631505685;\n\tbh=4ZiwgFktC1OYME/I9VQx99cKAxpxlUrVCuaaf0D5438=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PNJEMf2wyGvLWCmz78VWhEkD+2z+zX2X2cb7INCNSblyQfv5BDfXRZWqcNTs53AmX\n\thg51LkSq52pOGDzINZm47A1FcF4we1U5+TdYRJgGSbL6YcJObLIDOWjLYMJXbkz5EM\n\to9b5ASxP94mKTr9RjyeHl7XO0srQ4z+hg7B9SPow=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Sep 2021 09:31:09 +0530","Message-Id":"<20210913040110.13789-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210913040110.13789-1-umang.jain@ideasonboard.com>","References":"<20210913040110.13789-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/2] android: jpeg: Rectify variable\n\tnaming style.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rectify variable renaming style for YPlaneSize, UVPlaneSize.\nlibcamera uses camelCase where first letter should be in lower case.\n\nFixes: e355ca0087cd9(\"android: jpeg: Split and pass the thumbnail planes to encoder\")\nSigned-off-by: Umang Jain \nReviewed-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \n---\n src/android/jpeg/post_processor_jpeg.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex ef2d98cc..f6d47f63 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -82,10 +82,10 @@ void PostProcessorJpeg::generateThumbnail(const FrameBuffer &source,\n \t\t */\n \t\tstd::vector> thumbnailPlanes;\n \t\tconst PixelFormatInfo &formatNV12 = PixelFormatInfo::info(formats::NV12);\n-\t\tsize_t YPlaneSize = formatNV12.planeSize(targetSize, 0);\n-\t\tsize_t UVPlaneSize = formatNV12.planeSize(targetSize, 1);\n-\t\tthumbnailPlanes.push_back({ rawThumbnail.data(), YPlaneSize });\n-\t\tthumbnailPlanes.push_back({ rawThumbnail.data() + YPlaneSize, UVPlaneSize });\n+\t\tsize_t yPlaneSize = formatNV12.planeSize(targetSize, 0);\n+\t\tsize_t uvPlaneSize = formatNV12.planeSize(targetSize, 1);\n+\t\tthumbnailPlanes.push_back({ rawThumbnail.data(), yPlaneSize });\n+\t\tthumbnailPlanes.push_back({ rawThumbnail.data() + yPlaneSize, uvPlaneSize });\n \n \t\tint jpeg_size = thumbnailEncoder_.encode(thumbnailPlanes,\n \t\t\t\t\t\t\t *thumbnail, {}, quality);\n","prefixes":["libcamera-devel","v2","1/2"]}