{"id":13809,"url":"https://patchwork.libcamera.org/api/1.1/patches/13809/?format=json","web_url":"https://patchwork.libcamera.org/patch/13809/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210910104729.542779-2-umang.jain@ideasonboard.com>","date":"2021-09-10T10:47:28","name":"[libcamera-devel,v1,1/2] android: jpeg: Rectify variable naming style.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ac10ca4d4d7d950d59ff912b637db5134121ce0b","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13809/mbox/","series":[{"id":2514,"url":"https://patchwork.libcamera.org/api/1.1/series/2514/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2514","date":"2021-09-10T10:47:27","name":"android: Fix generation of thumbnail for EXIF data","version":1,"mbox":"https://patchwork.libcamera.org/series/2514/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13809/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13809/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61CF2BDB1D\n\tfor ;\n\tFri, 10 Sep 2021 10:47:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3065069170;\n\tFri, 10 Sep 2021 12:47:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2533469169\n\tfor ;\n\tFri, 10 Sep 2021 12:47:39 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.149])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BC15883;\n\tFri, 10 Sep 2021 12:47:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ntKYrMUV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631270858;\n\tbh=pw0qmNyimkXbhD1+lrgNVu8mGBhDRpBDLJRsy8lHbMM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ntKYrMUV23dh51BnZVuNsHxloT2k1Ht8K9W8LQOmORRHfgvHjbHCuSC2ZRObjCEyS\n\tsKhBC5SMdFtDZ2J9ztzmn3s1Tc88jxiK29ywDhfOIb0SOr0Ay3+1a0m3QItjCltBU3\n\tARAjRt+P0FsQuvwhlbiu+ol+4upcG9LQMbj8RywE=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 10 Sep 2021 16:17:28 +0530","Message-Id":"<20210910104729.542779-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210910104729.542779-1-umang.jain@ideasonboard.com>","References":"<20210910104729.542779-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 1/2] android: jpeg: Rectify variable\n\tnaming style.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rectify variable renaming style for YPlaneSize, UVPlaneSize.\nlibcamera uses camelCase where first letter should be in lower case.\n\nFixes: e355ca0087cd9(\"android: jpeg: Split and pass the thumbnail planes to encoder\")\nSigned-off-by: Umang Jain \n---\n src/android/jpeg/post_processor_jpeg.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex ef2d98cc..f6d47f63 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -82,10 +82,10 @@ void PostProcessorJpeg::generateThumbnail(const FrameBuffer &source,\n \t\t */\n \t\tstd::vector> thumbnailPlanes;\n \t\tconst PixelFormatInfo &formatNV12 = PixelFormatInfo::info(formats::NV12);\n-\t\tsize_t YPlaneSize = formatNV12.planeSize(targetSize, 0);\n-\t\tsize_t UVPlaneSize = formatNV12.planeSize(targetSize, 1);\n-\t\tthumbnailPlanes.push_back({ rawThumbnail.data(), YPlaneSize });\n-\t\tthumbnailPlanes.push_back({ rawThumbnail.data() + YPlaneSize, UVPlaneSize });\n+\t\tsize_t yPlaneSize = formatNV12.planeSize(targetSize, 0);\n+\t\tsize_t uvPlaneSize = formatNV12.planeSize(targetSize, 1);\n+\t\tthumbnailPlanes.push_back({ rawThumbnail.data(), yPlaneSize });\n+\t\tthumbnailPlanes.push_back({ rawThumbnail.data() + yPlaneSize, uvPlaneSize });\n \n \t\tint jpeg_size = thumbnailEncoder_.encode(thumbnailPlanes,\n \t\t\t\t\t\t\t *thumbnail, {}, quality);\n","prefixes":["libcamera-devel","v1","1/2"]}