{"id":13803,"url":"https://patchwork.libcamera.org/api/1.1/patches/13803/?format=json","web_url":"https://patchwork.libcamera.org/patch/13803/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210910070638.467294-6-umang.jain@ideasonboard.com>","date":"2021-09-10T07:06:34","name":"[libcamera-devel,v2,5/9] android: camera_stream: Query post-processing status","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0acffac9d8d39bc6f6272d57f94a2c805cc4f4f4","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/1.1/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13803/mbox/","series":[{"id":2513,"url":"https://patchwork.libcamera.org/api/1.1/series/2513/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2513","date":"2021-09-10T07:06:29","name":"Async Post Processor","version":2,"mbox":"https://patchwork.libcamera.org/series/2513/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13803/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13803/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAB87BDC71\n\tfor ;\n\tFri, 10 Sep 2021 07:06:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 999026916D;\n\tFri, 10 Sep 2021 09:06:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D356369169\n\tfor ;\n\tFri, 10 Sep 2021 09:06:56 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.149])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE520883;\n\tFri, 10 Sep 2021 09:06:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wK8/itDF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631257616;\n\tbh=EjrgOUPInzOsFwr8WIeUqDQz29bU+sJYG1tCgeGwvbw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wK8/itDFrmrBKEYxWXGA7OG4tMnoop7B2QLYY9QfyCyeS7Li4kW0Tatn2xWDvkg8g\n\t9jMp5LkfHUqVD5DT1UPNSKJoEpzg6tm/3spKQdyvU1ppzT9C+tK/yA23ocr9FXw5HW\n\t25CTvQLkrHZ0JhoV6tn4TcYmXShBKgb6NC96Lxrk=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 10 Sep 2021 12:36:34 +0530","Message-Id":"<20210910070638.467294-6-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210910070638.467294-1-umang.jain@ideasonboard.com>","References":"<20210910070638.467294-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/9] android: camera_stream: Query\n\tpost-processing status","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"CameraStream takes care of any post-processing required via the\nCameraStream::process(). Since the post-processor will be moved\nto a separate thread (in subsequent commits), the caller of\nPostProcessor::process() will notify the associated CameraStream\ninstance about the post-processing completion via processComplete\nsignal. The CameraStream class should handle this event to query\nthe status and take next steps of reporting it back to upper layers\n(i.e. CameraDevice).\n\nSigned-off-by: Umang Jain \n---\n src/android/camera_stream.cpp | 13 +++++++++++++\n src/android/camera_stream.h | 13 ++++++++++++-\n 2 files changed, 25 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex d1c54797..996779c4 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -81,6 +81,9 @@ int CameraStream::configure()\n \t\tint ret = postProcessor_->configure(configuration(), output);\n \t\tif (ret)\n \t\t\treturn ret;\n+\n+\t\tpostProcessor_->processComplete.connect(\n+\t\t\tthis, &CameraStream::postProcessingComplete);\n \t}\n \n \tif (allocator_) {\n@@ -123,6 +126,16 @@ int CameraStream::process(const FrameBuffer *source,\n \t\t\t\t resultMetadata, context);\n }\n \n+void CameraStream::postProcessingComplete(PostProcessor::Status status,\n+\t\t\t\t\t const Camera3RequestDescriptor *context)\n+{\n+\tProcessStatus processStatus;\n+\tif (status == PostProcessor::Status::Succeeded)\n+\t\tprocessStatus = ProcessStatus::Succeeded;\n+\telse\n+\t\tprocessStatus = ProcessStatus::Failed;\n+}\n+\n FrameBuffer *CameraStream::getBuffer()\n {\n \tif (!allocator_)\ndiff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\nindex d589f699..be076995 100644\n--- a/src/android/camera_stream.h\n+++ b/src/android/camera_stream.h\n@@ -13,15 +13,18 @@\n \n #include \n \n+#include \n+\n #include \n #include \n #include \n #include \n #include \n \n+#include \"post_processor.h\"\n+\n class CameraDevice;\n class CameraMetadata;\n-class PostProcessor;\n \n struct Camera3RequestDescriptor;\n \n@@ -128,7 +131,15 @@ public:\n \tlibcamera::FrameBuffer *getBuffer();\n \tvoid putBuffer(libcamera::FrameBuffer *buffer);\n \n+\tenum ProcessStatus {\n+\t\tSucceeded,\n+\t\tFailed,\n+\t};\n+\n private:\n+\tvoid postProcessingComplete(PostProcessor::Status status,\n+\t\t\t\t const Camera3RequestDescriptor *context);\n+\n \tCameraDevice *const cameraDevice_;\n \tconst libcamera::CameraConfiguration *config_;\n \tconst Type type_;\n","prefixes":["libcamera-devel","v2","5/9"]}