{"id":1376,"url":"https://patchwork.libcamera.org/api/1.1/patches/1376/?format=json","web_url":"https://patchwork.libcamera.org/patch/1376/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190606205654.9311-5-kieran.bingham@ideasonboard.com>","date":"2019-06-06T20:56:53","name":"[libcamera-devel,RFC,4/5] QCam: Set a read control on each request to get Gain value","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"95f25fff88e792b8d8145b5cb91416d42c57ac9d","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1376/mbox/","series":[{"id":340,"url":"https://patchwork.libcamera.org/api/1.1/series/340/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=340","date":"2019-06-06T20:56:49","name":"Libcamera Controls","version":1,"mbox":"https://patchwork.libcamera.org/series/340/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1376/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1376/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 183D460BB7\n\tfor ;\n\tThu, 6 Jun 2019 22:56:59 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD0A333B;\n\tThu, 6 Jun 2019 22:56:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559854618;\n\tbh=58XtCoTFn85cxKj5vTpGrKDu0gsk3nDFhQGsBwCQNgQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Z323XbTxejOnqd7vy2dLBvZLjIQFBoyTK/VEZiwnl4uYQqNWP+L9WwRpwBmhb22OQ\n\tReWsHnzHKUR7ZrLw1/ZhOMr1F+6Uwe4+LNZqyJ+um71IXFa2mVyN0DWoGEWJyGA2em\n\tI1BxNI9m5T//W+oIvG0vVq2MD0TU9aOI2Df30HFI=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Thu, 6 Jun 2019 21:56:53 +0100","Message-Id":"<20190606205654.9311-5-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190606205654.9311-1-kieran.bingham@ideasonboard.com>","References":"<20190606205654.9311-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 4/5] QCam: Set a read control on each\n\trequest to get Gain value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Jun 2019 20:56:59 -0000"},"content":"---\n src/qcam/main_window.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex c0ab865b46ff..8dbe597e7aa2 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -210,6 +210,10 @@ int MainWindow::startCapture()\n \t}\n \n \tfor (Request *request : requests) {\n+\n+\t\t/* Add a read request for ManualGain */\n+\t\trequest->controls().emplace(ManualBrightness);\n+\n \t\tret = camera_->queueRequest(request);\n \t\tif (ret < 0) {\n \t\t\tstd::cerr << \"Can't queue request\" << std::endl;\n@@ -266,12 +270,18 @@ void MainWindow::requestComplete(Request *request,\n \n \tdisplay(buffer);\n \n+\t/* Parse completed controls */\n+\tfor (Control c : request->controls())\n+\t\tstd::cout << c << std::endl;\n+\n+\t/* Create a new request */\n \trequest = camera_->createRequest();\n \tif (!request) {\n \t\tstd::cerr << \"Can't create request\" << std::endl;\n \t\treturn;\n \t}\n \n+\n \trequest->setBuffers(buffers);\n \tcamera_->queueRequest(request);\n }\n","prefixes":["libcamera-devel","RFC","4/5"]}