{"id":13739,"url":"https://patchwork.libcamera.org/api/1.1/patches/13739/?format=json","web_url":"https://patchwork.libcamera.org/patch/13739/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210907194107.803730-9-jacopo@jmondi.org>","date":"2021-09-07T19:40:58","name":"[libcamera-devel,v2,08/17] android: capabilities: Use per-configuration durations","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bd429a39acad7e802b50fabda1e1a438f4b4bd80","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13739/mbox/","series":[{"id":2492,"url":"https://patchwork.libcamera.org/api/1.1/series/2492/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2492","date":"2021-09-07T19:40:50","name":"IPU3 control info update and HAL frame durations","version":2,"mbox":"https://patchwork.libcamera.org/series/2492/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13739/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13739/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E84DBEFBE\n\tfor ;\n\tTue, 7 Sep 2021 19:40:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB0856918C;\n\tTue, 7 Sep 2021 21:40:37 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A3B669185\n\tfor ;\n\tTue, 7 Sep 2021 21:40:35 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 342D3240004;\n\tTue, 7 Sep 2021 19:40:34 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Sep 2021 21:40:58 +0200","Message-Id":"<20210907194107.803730-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210907194107.803730-1-jacopo@jmondi.org>","References":"<20210907194107.803730-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 08/17] android: capabilities: Use\n\tper-configuration durations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the per-configuration stream durations as collected during\ninitializeStreamConfigurations() to populate the\nANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT static metadata.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Paul Elder \nReviewed-by: Umang Jain \n---\n src/android/camera_capabilities.cpp | 21 +++++++++------------\n 1 file changed, 9 insertions(+), 12 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex ee2883ab2821..5d8293843f57 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1271,19 +1271,16 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n \t\t\t\t availableStallDurations);\n \n-\t/* Use the minimum frame duration for all the YUV/RGB formats. */\n-\tif (minFrameDurationNsec > 0) {\n-\t\tstd::vector minFrameDurations;\n-\t\tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n-\t\tfor (const auto &entry : streamConfigurations_) {\n-\t\t\tminFrameDurations.push_back(entry.androidFormat);\n-\t\t\tminFrameDurations.push_back(entry.resolution.width);\n-\t\t\tminFrameDurations.push_back(entry.resolution.height);\n-\t\t\tminFrameDurations.push_back(minFrameDurationNsec);\n-\t\t}\n-\t\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n-\t\t\t\t\t minFrameDurations);\n+\tstd::vector minFrameDurations;\n+\tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n+\tfor (const auto &entry : streamConfigurations_) {\n+\t\tminFrameDurations.push_back(entry.androidFormat);\n+\t\tminFrameDurations.push_back(entry.resolution.width);\n+\t\tminFrameDurations.push_back(entry.resolution.height);\n+\t\tminFrameDurations.push_back(entry.minFrameDurationNsec);\n \t}\n+\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n+\t\t\t\t minFrameDurations);\n \n \tuint8_t croppingType = ANDROID_SCALER_CROPPING_TYPE_CENTER_ONLY;\n \tstaticMetadata_->addEntry(ANDROID_SCALER_CROPPING_TYPE, croppingType);\n","prefixes":["libcamera-devel","v2","08/17"]}